From patchwork Thu Dec 7 14:27:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 845597 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="CC1xboEa"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ysybD5YBcz9sxR for ; Fri, 8 Dec 2017 01:31:20 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753943AbdLGObR (ORCPT ); Thu, 7 Dec 2017 09:31:17 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:32996 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753453AbdLGO1U (ORCPT ); Thu, 7 Dec 2017 09:27:20 -0500 Received: by mail-wr0-f196.google.com with SMTP id v22so7698709wrb.0 for ; Thu, 07 Dec 2017 06:27:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=bAipUEvgvM1Uc5xrra8bjleth2WsfGM5KkNvI1jPf0A=; b=CC1xboEa/+yuNu3DUMFgtZfwKG6mvHhsf3tEyJba5w+ZjHX6MzkdHF0RDe9SYpbAfe ZDlB2KCb2pidhmUjB7og10UsxiIz/OLR6VbfuZPxaSZhYg7JCXMaEQJAP3FWxxr6y/3z bTDXN9hEopJz/x6DvUJTCCzYHVU7evOyAfRuaIp6d66eDWTlPJ3Nf9cezbzJiJo7QR1u z8KU+oDfPvMEXUXE7AE3M0Ih+PdqOPObZx7BTelnnZQDEMrQxKN+HgoDG735o7ahkX8o dQ3Qv6d0SuATBMKpPNouO+YwNxYdu7LAiW/ENg/qf2oYbzFnpN34vUhwQvajludqpk7T tKNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=bAipUEvgvM1Uc5xrra8bjleth2WsfGM5KkNvI1jPf0A=; b=HT+1JVsRAfaeTj6bHa9gcQWYsJe61BN1XvpLW3WlQGQlbk4MTw53wnk3rtTOiopcax 6XjIxgOQLlPPGjtjb5EHHcuLpSI8k1+C0tz0cexS8oRQQ7jVsSLPzRs+7FnDlC9KQzRP DjIp1Ujp2wl2QYikWO7mw+irdQ5gAbZA1otbxWLQ5oKWRwmsWnyc78eUcR8SrAhRXkcv 7eevHHeEdVXhhC/n33yv+HEc1l8LwROcIkiSQUnil3MSiDuOw92YSIFAPWhCJYwE1WtQ kcmcd+KmIUEykR/zkxsj+ZHCjNNbyO4DSST1yXS+/tVnfFOhkC4HU+kkTnK5xOGm7HE0 UThQ== X-Gm-Message-State: AJaThX5+tyQPOSZSmRWSMxzT2fKeTTz+TPxx8LL5gW4dI8DIHUrhF/yn PmlR1vBVmHypEXRi+DLOTFFKyJ0W X-Google-Smtp-Source: AGs4zMZrdGFRiTm5ziG0APj0ZTs05DlIr+OeaTmwm+CucYtVMWKUdHIM6vvDAUyKxIHPWPcR3+e38A== X-Received: by 10.223.195.22 with SMTP id n22mr25876908wrf.212.1512656839229; Thu, 07 Dec 2017 06:27:19 -0800 (PST) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id t138sm6264520wme.16.2017.12.07.06.27.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Dec 2017 06:27:18 -0800 (PST) From: Jerome Brunet To: Andrew Lunn , Florian Fainelli Cc: Jerome Brunet , Kevin Hilman , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 1/8] net: phy: meson-gxl: check phy_write return value Date: Thu, 7 Dec 2017 15:27:08 +0100 Message-Id: <20171207142715.32578-2-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20171207142715.32578-1-jbrunet@baylibre.com> References: <20171207142715.32578-1-jbrunet@baylibre.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Always check phy_write return values. Better to be safe than sorry Signed-off-by: Jerome Brunet Reviewed-by: Andrew Lunn --- drivers/net/phy/meson-gxl.c | 50 ++++++++++++++++++++++++++++++++++----------- 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c index 1ea69b7585d9..7ddb709f69fc 100644 --- a/drivers/net/phy/meson-gxl.c +++ b/drivers/net/phy/meson-gxl.c @@ -25,27 +25,53 @@ static int meson_gxl_config_init(struct phy_device *phydev) { + int ret; + /* Enable Analog and DSP register Bank access by */ - phy_write(phydev, 0x14, 0x0000); - phy_write(phydev, 0x14, 0x0400); - phy_write(phydev, 0x14, 0x0000); - phy_write(phydev, 0x14, 0x0400); + ret = phy_write(phydev, 0x14, 0x0000); + if (ret) + return ret; + ret = phy_write(phydev, 0x14, 0x0400); + if (ret) + return ret; + ret = phy_write(phydev, 0x14, 0x0000); + if (ret) + return ret; + ret = phy_write(phydev, 0x14, 0x0400); + if (ret) + return ret; /* Write Analog register 23 */ - phy_write(phydev, 0x17, 0x8E0D); - phy_write(phydev, 0x14, 0x4417); + ret = phy_write(phydev, 0x17, 0x8E0D); + if (ret) + return ret; + ret = phy_write(phydev, 0x14, 0x4417); + if (ret) + return ret; /* Enable fractional PLL */ - phy_write(phydev, 0x17, 0x0005); - phy_write(phydev, 0x14, 0x5C1B); + ret = phy_write(phydev, 0x17, 0x0005); + if (ret) + return ret; + ret = phy_write(phydev, 0x14, 0x5C1B); + if (ret) + return ret; /* Program fraction FR_PLL_DIV1 */ - phy_write(phydev, 0x17, 0x029A); - phy_write(phydev, 0x14, 0x5C1D); + ret = phy_write(phydev, 0x17, 0x029A); + if (ret) + return ret; + ret = phy_write(phydev, 0x14, 0x5C1D); + if (ret) + return ret; /* Program fraction FR_PLL_DIV1 */ - phy_write(phydev, 0x17, 0xAAAA); - phy_write(phydev, 0x14, 0x5C1C); + ret = phy_write(phydev, 0x17, 0xAAAA); + if (ret) + return ret; + ret = phy_write(phydev, 0x14, 0x5C1C); + if (ret) + return ret; return 0; }