From patchwork Thu Oct 19 02:43:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Mendoza-Jonas X-Patchwork-Id: 827907 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=mendozajonas.com header.i=@mendozajonas.com header.b="Vj6RqKlZ"; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="Wusckbph"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yHYCg1x2Bz9t7q for ; Thu, 19 Oct 2017 13:43:59 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751660AbdJSCnf (ORCPT ); Wed, 18 Oct 2017 22:43:35 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:42787 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751576AbdJSCnZ (ORCPT ); Wed, 18 Oct 2017 22:43:25 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 2065620E04; Wed, 18 Oct 2017 22:43:25 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute2.internal (MEProxy); Wed, 18 Oct 2017 22:43:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= mendozajonas.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=lPG5DVfQMUR/iQq4L5aozTNF9x747wdDhfzxGI/BK5I=; b=Vj6RqKlZ Mrto/k9xNJ0d/lhiLLKGoDGklgOhPrMxHQqbabnj20dNSF/hrTGqRCGNip/46UOW jlb8loijx+vIhHN8YMEKp+SiJYqLYxRLnZYlJObCEVav5chAAO6lJt6C+bk1JVe4 0q5lZbPfxAKbKTxdfUy6cJp1ngEjzfAh5NL6qRLCvDVeW0TmZ59whorHt3dLxtYh 9RdSMxQRJd/pecmNrGmxZrSoRjNv/d9ZSAk9CTMb9GPCCc2loZSOG1joupq8uOiL vvGuVko/6Lfqev1pHY0KucmNc3TvOE36/U1LhvCXGgN92ICyTLznllgM1FIT68Yt M2PjQwFW0yZPvg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=lPG5DVfQMUR/iQq4L5aozTNF9x747wdDhfzxGI/BK5I=; b=Wusckbph 0GS1oXP/s0CqUdrEC/zgFb43FTaWVuidOTBcauQh03a0jNZay3oO8LhbV5KDpngL s1fdsLVAWXCfLXAat737Ahq2reoL/FIKqF3+yukLjAdm8J5y+45pm6LHFhxHxTes zfxxvXY4tCfIrXKgbCb3w0KNrWP/X67jF5Fw3OWnt0e7LV0jDxYqjApWzSNQnbDb 4AumHcdtEJxb9VzAbLrbCLRGHsn+xYiqnfknTxcnTQivnZyZX4/cc+slKdxSv44t 47ynDIxoWd4XtpeNXj9cOBEmvwU09U/Boy43xM5GD3IjQWV71GXjaqdG4nZoQnV/ JCu5aRticDLrRA== X-ME-Sender: Received: from v4.ozlabs.ibm.com (unknown [122.99.82.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 551447F9D0; Wed, 18 Oct 2017 22:43:23 -0400 (EDT) From: Samuel Mendoza-Jonas To: netdev@vger.kernel.org Cc: Gavin Shan , "David S . Miller" , linux-kernel@vger.kernel.org, Samuel Mendoza-Jonas Subject: [PATCH net 5/5] net/ncsi: Fix length of GVI response packet Date: Thu, 19 Oct 2017 13:43:09 +1100 Message-Id: <20171019024309.13628-5-sam@mendozajonas.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20171019024309.13628-1-sam@mendozajonas.com> References: <20171019024309.13628-1-sam@mendozajonas.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Gavin Shan The length of GVI (GetVersionInfo) response packet should be 40 instead of 36. This issue was found from /sys/kernel/debug/ncsi/eth0/stats. # ethtool --ncsi eth0 swstats : RESPONSE OK TIMEOUT ERROR ======================================= GVI 0 0 2 With this applied, no error reported on GVI response packets: # ethtool --ncsi eth0 swstats : RESPONSE OK TIMEOUT ERROR ======================================= GVI 2 0 0 Signed-off-by: Gavin Shan Signed-off-by: Samuel Mendoza-Jonas --- net/ncsi/ncsi-rsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ncsi/ncsi-rsp.c b/net/ncsi/ncsi-rsp.c index 265b9a892d41..927dad4759d1 100644 --- a/net/ncsi/ncsi-rsp.c +++ b/net/ncsi/ncsi-rsp.c @@ -959,7 +959,7 @@ static struct ncsi_rsp_handler { { NCSI_PKT_RSP_EGMF, 4, ncsi_rsp_handler_egmf }, { NCSI_PKT_RSP_DGMF, 4, ncsi_rsp_handler_dgmf }, { NCSI_PKT_RSP_SNFC, 4, ncsi_rsp_handler_snfc }, - { NCSI_PKT_RSP_GVI, 36, ncsi_rsp_handler_gvi }, + { NCSI_PKT_RSP_GVI, 40, ncsi_rsp_handler_gvi }, { NCSI_PKT_RSP_GC, 32, ncsi_rsp_handler_gc }, { NCSI_PKT_RSP_GP, -1, ncsi_rsp_handler_gp }, { NCSI_PKT_RSP_GCPS, 172, ncsi_rsp_handler_gcps },