From patchwork Tue Sep 26 18:48:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Manlunas, Felix" X-Patchwork-Id: 818781 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com header.i=@CAVIUMNETWORKS.onmicrosoft.com header.b="ODxJAdap"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3y1qjk5qlYz9t43 for ; Wed, 27 Sep 2017 04:48:52 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031654AbdIZSsv (ORCPT ); Tue, 26 Sep 2017 14:48:51 -0400 Received: from mail-cys01nam02on0059.outbound.protection.outlook.com ([104.47.37.59]:59643 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754339AbdIZSsb (ORCPT ); Tue, 26 Sep 2017 14:48:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=7BfeOUoa/vbmvJMFlifDgBPR2web17uc04QlOGI2/Qg=; b=ODxJAdap+e7XHcrzZMCF5Ek/NJSu3P2K+iO6Q+4LUzw73FTMTtHZwhopuZ6D2Dhi3HvqJa1//B1qkJf9MTGOLgDLTGLchVQHFdbMJHHcBqqzM21UxcSgyBobB6sA/seQj3awe6Y5K04+r4ZHhRC13pTH/+Q52AP7sqaa71exkaA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Felix.Manlunas@cavium.com; Received: from localhost (50.233.148.156) by MWHPR07MB3183.namprd07.prod.outlook.com (10.172.96.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Tue, 26 Sep 2017 18:48:29 +0000 Date: Tue, 26 Sep 2017 11:48:27 -0700 From: Felix Manlunas To: davem@davemloft.net Cc: netdev@vger.kernel.org, raghu.vatsavayi@cavium.com, derek.chickles@cavium.com, satananda.burla@cavium.com Subject: [PATCH net-next] liquidio: fix format truncation warning reported by gcc 7.1.1 Message-ID: <20170926184827.GA3512@felix-thinkpad.cavium.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: MWHPR20CA0044.namprd20.prod.outlook.com (10.172.102.158) To MWHPR07MB3183.namprd07.prod.outlook.com (10.172.96.141) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c32b6c6b-f8c3-448e-f403-08d5050f2e09 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:MWHPR07MB3183; X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3183; 3:FZBZPEJdZAvidK/OCp/P4MKiTN5Dh3yEG9pDL3+729MVb2nCxe/3+RuDAeIaqhE1Q36igxvjloKIX3V+Y0phe1av0bQTYfy2fIJfxDk+z/+K7rMxOGmCnYXl1Tm4ursqebOTMDQBh9ZJ3i4AvI4Wmh8ojJN945FGDgztjKsMs49NxhGTN1GJSeZlXT5G0pwk+h8wb2YPOmI1Qga6O3ijl/uyOASV3i/WiM+k2bAdfrSbQ2Un5x73A3AedD6x4QBE; 25:gMH8mdpoHIJyZYg9ZjLMimzzSWL6hDcsO0Ao2HYyXbkNXyp5K+5Phi3JI8jQXa6E5u7Q63DzFWleMawz3FShusfHanaCMfopPp19dUKmO0CmKr29/mxa/RsOohZnGkNecK38gAAc+wha+PQWva7Bn6riyiBXcXH45D1yiJDqVgR/OGEtytT9zssnLgnCdY38A1A/ATOthHRtUL6eGvYZH8NH2jjVFNA8z2DjD6/ayo+vYMlTQ4f4A7LoSkxp+S5QwJpA9cqUZejiMLntY0vreo7jf2JtATjcU0ZWiiUauNol4HJPw7550HOGigSu6tRrpGhTRR2lsFwDvJrGYr/sPg==; 31:UUHc4c7OysuVQZpf9aFAMo1WVyqyeCD3nkBN1Cl+f1MK3evv8Yphg8gOcBWDuwtF+JxPtgEEP2S8qBuyBMm6mOwmzwkrFpLO9dpGck/CNAQ8+q8YFjHgc7NRLBRQol0tkJZi/2K4S9ujpRk5yKI3yoC2wqrrnYK2zTIP055TkaytMekSGRrQGmT7NKfUPAmnAynSORyyeepf3+n5Me9ovb2LPBA5Kp9ZSGowT151d+M= X-MS-TrafficTypeDiagnostic: MWHPR07MB3183: X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3183; 20:ilrkkl1M1nnJU/P8fbiscALEuS7Q9xxET9OAzxbF3Wp95vVE4VLDFbjS0HR25YVQeMgZwBRIycAdQDA8qB9ENHnh7dGE8IEGDWKe6UrfBI+6cwSGvgJMjPUbCA0E0pgQnlgQqHRmqN/X/EIbsYOTF20IiCMQ1MOW+WyRvmxKsMfkU6p8zI+8J3XeAjajRAiZG2E2kUivF7bTL6/9mqIxSSuK7jtHW+Sq3cwiGKdMZT6aGPapGpikpsSZcK3VMliz9A7o/1Sx9SnrKDePvvXbPllxOCPWcQ44TUu2Anzs8eIYvuG9yHrvovxspVPbjX5J8kUZz4cc27DjRS0lHb0KxI/+KKZ7SWT7z02kESm6wHkD25DfaRkZKFlx7BMj5rf0ZprhvkYDtmMStygRoL+dhNhrVnGLs3MSx2yIkqixLAnLuNtFzFb78c3XwG/Mk+bPLLs0+i9/qcoOEyPopjYDD2IwAOR+3Nqrflbq3x3OuYygWrNWunI6poYADEYKZIQm; 4:mpsSa3YJCaiyFHrkzjs4+L4RnyYyfYbcpxMfgBRXSev/jkpQl7c+t7Twvh7gScAqHDJoYXx4CpQOEJftkNqbVo4hZNnxnK1M+BK79gRGhlS6A1wDWbIsHVwk7No+0FLlndDdviZrg0D7Pe0tSu2soQ04VYQW+rafyZR5y/6KO6TSR03Oow74qwMxQwx0ZjZKVI6lzFU3m9vUCt3alOS8pXa7wOtOPWb8hXlnmlNPCx2TCqfU0z+6/orbL7Eve9CgK9adpWMT4j2dPDRNQLHdNrTHQ6PQDIEmETVaONzVsvw= X-Exchange-Antispam-Report-Test: UriScan:(20558992708506); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6041248)(20161123560025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:MWHPR07MB3183; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:MWHPR07MB3183; X-Forefront-PRVS: 0442E569BC X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6069001)(346002)(376002)(199003)(189002)(2361001)(8936002)(6916009)(50986999)(6486002)(5660300001)(16526017)(86362001)(97736004)(305945005)(8676002)(54356999)(58126008)(101416001)(316002)(81156014)(81166006)(66066001)(16586007)(83506001)(106356001)(7736002)(47776003)(4326008)(105586002)(76506005)(33656002)(2351001)(50466002)(1076002)(3846002)(25786009)(107886003)(72206003)(6116002)(68736007)(53936002)(478600001)(2906002)(189998001)(23726003)(6496005)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR07MB3183; H:localhost; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3183; 23:HY9tHbJeg4nT3y40RCogxHUVzUGI2WERgUOU7nhc5T7LOb7FEU7pI97VwxVwdgCO4Iem1gkfUw6wJahjYRSZaA48ULs0rxsEA3A5xcK4urXBntd5aIgNtGHSqsRgxInbnd5rJPW75GpuXFdPPJZmUWy/DuS6g0Xy1MS8+wPD/mcFip2miJXrtEFfXyLYOM7NPqH4Na26UYyARMCejw/EaZ3KDb/uxW79K2UHlH8akA3lkIkcLU8i1Ypjhmx/QTPZV9Zvsc2hLDlA2HgliOuTYbg8MOXAZksZWVsUPhIu5mFOEcofcT9Hsae4rviumMZHEB/996PMY64gnPLL16k+IGfDyKvRQLjr1GiVVym7FrMLVxMilaHQezaEw0XFfnslbUUlmxgnibpw+Q2grFYjO/ij71TOYzdLA2x9TXg882L2vUurdcrBMq5mxcPXtv8zECJFi8g1QQcSsOunlUgSpDQZYkVZP7eO7FPcTUAGA51hYfO4L/VBxDczyZ1u5XlO7LXjubDG/BdHYE7fMrOpxBhtOHZIRer4xLCbWV8FlKkuls1hdGz6OQIl2LA0L9+IWHWhjKJ5fJmbqlY856GBQkid9ebxG9WHd+y5dlXUKJrXkG0IgcqlQuKuJq+LnaP1HgoW0vF7muVmUGRHCgTO3F1SLZ7HRdDCBNzyqX2MB51+eCXvmEvKE1ZyP8fmIFzQgDd9JXUobZBGqGvQHaaKcM6ToXqVC9p6J5FaP3WAdtC5QBPm/GNx1VvOyHtoQN5gshVmBdn9ncpS0c+TnPMyGe4/ZZwy1LhZLB7/3h/MY8q6KbiRyeyG3MptFi4MWW4vaQsswB1vfwrgIpKjHkDFoJjvaUoJdND+XdzrhpPvU48Dh6I6bluHatyB2QUgedRoFj6H2roJUd8vqGMTi4mXO0byPXyhd3sDqDw8Y7br6zA6P/gBb2B1jjZX6wrIXVnFSbzIWlJpUAxrSt/5sPBDfkb7Xf0hYD1/Zdz9hS1RyTwdxYl6JgHjyNIck9mniegGRDLqbN8NJ0HwVbR5WHXTtzOC7d7KdpObsDeg40iTfc5CLM1Puq/bYHIti8LvcVCuonT/TuLQppTFmeobh+KF6on1A+FD+PbCI/Wsn1Sk8TX8chcVehYSVAVZrneD68j5 X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3183; 6:hOOTofrKPMa3yfhxU2TVpCYUIjr0uFB3E+VEUjGF5SLHrSTRPk+YFruIl2EN4iJmnsAjksnAG/t2VpJakiNChsZ/VoP6TKCm5Ow+38eY96sdp+poiN1R6NOOI8XG1iwm90fbn/dd6EgRcExSplo0GO6JH1dycmc+ncWAreAixeSjtzOMVg9LfqONO9Hnlv076CMfpvAWwnvM+6ZYy8z3ohAbG0moO3a4TRSQ7WU/CvWsixBZKA5XVjmOOza5izag6abLsMVANB5fabrYDtihF+Cit2Qm6Duu3FBwonpAErI/RE4MPEeM1fS3M0NYhEzMkz1YT9WfWUiN+BDLEzL/ng==; 5:oADxbgpIIefKi5fo3qkPKMUutXaYqNStiDjaMHhK2IGrXV1dyIoBYGmMDUdTLuOyVAv5j/bXskBXyOw1tAdnvKMU2RkSae6SbZye0F1PBRQ6uxY40/tcBSyRCXAkoxCbFf/nYqhIKrC7u3TNVyWPqw==; 24:bj2P05eiTWRghchkmyHQ90O9nuwi1qyPUQNHHRIwHS5IzL31fCSF8XsZfn6XaSVJwG6Vnb2bY2XUJ9NNAwPd6hVMuaVp6cLRLzo12VE/JrA=; 7:reImchp61jH836J+k/t+2RxFC8ff34zD0j7FEo7Mdnojqh6Teh2qdZjjG+aQlGVeqE+GrAN69GO2Mqg9lABrqxyStuHzMTMW/fzwOnScgrWg1VanXoeil0dQRYU9f5cZ38Bhgj4DRdv14o1AvG6qUMyCq7SRbtLvPoQqNf0IqjTYIuXwj9NPkRMkpq5C8edJbSx/KARq1LylPkzK/cZ5rrEu10vwNJkQoiwWJjvYfZ8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2017 18:48:29.6439 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3183 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Satanand Burla gcc 7.1.1 with -Wformat-truncation reports these warnings: drivers/net/ethernet/cavium/liquidio/lio_core.c: In function `octeon_setup_interrupt': drivers/net/ethernet/cavium/liquidio/lio_core.c:1003:41: warning: `%u' directive output may be truncated writing between 1 and 10 bytes into a region of size between 0 and 13 [-Wformat-truncation=] INTRNAMSIZ, "LiquidIO%u-pf%u-rxtx-%u", ^~ drivers/net/ethernet/cavium/liquidio/lio_core.c:1003:19: note: directive argument in the range [0, 2147483647] INTRNAMSIZ, "LiquidIO%u-pf%u-rxtx-%u", ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/cavium/liquidio/lio_core.c:1002:5: note: `snprintf' output between 21 and 43 bytes into a destination of size 32 snprintf(&queue_irq_names[IRQ_NAME_OFF(i)], ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ INTRNAMSIZ, "LiquidIO%u-pf%u-rxtx-%u", ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ oct->octeon_id, oct->pf_num, i); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/cavium/liquidio/lio_core.c:1008:41: warning: `%u' directive output may be truncated writing between 1 and 10 bytes into a region of size between 0 and 13 [-Wformat-truncation=] INTRNAMSIZ, "LiquidIO%u-vf%u-rxtx-%u", ^~ drivers/net/ethernet/cavium/liquidio/lio_core.c:1008:19: note: directive argument in the range [0, 2147483647] INTRNAMSIZ, "LiquidIO%u-vf%u-rxtx-%u", ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/cavium/liquidio/lio_core.c:1007:5: note: `snprintf' output between 21 and 43 bytes into a destination of size 32 snprintf(&queue_irq_names[IRQ_NAME_OFF(i)], ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ INTRNAMSIZ, "LiquidIO%u-vf%u-rxtx-%u", ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ oct->octeon_id, oct->vf_num, i); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fix them by changing the type of the "i" local variable from int to short. Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c index 23f6b60..55c5d44 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_core.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c @@ -899,11 +899,12 @@ int octeon_setup_interrupt(struct octeon_device *oct, u32 num_ioqs) { struct msix_entry *msix_entries; char *queue_irq_names = NULL; - int i, num_interrupts = 0; + int num_interrupts = 0; int num_alloc_ioq_vectors; char *aux_irq_name = NULL; int num_ioq_vectors; int irqret, err; + short i; oct->num_msix_irqs = num_ioqs; if (oct->msix_on) {