Message ID | 20170910132201.15576-1-dav.lebrun@gmail.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
Series | [net] ipv6: sr: remove duplicate routing header type check | expand |
From: David Lebrun <dav.lebrun@gmail.com> Date: Sun, 10 Sep 2017 14:22:01 +0100 > From: David Lebrun <dlebrun@google.com> > > As seg6_validate_srh() already checks that the Routing Header type is > correct, it is not necessary to do it again in get_srh(). > > Fixes: 5829d70b ("ipv6: sr: fix get_srh() to comply with IPv6 standard "RFC 8200") > Signed-off-by: David Lebrun <dlebrun@google.com> Applied thanks.
diff --git a/net/ipv6/seg6_local.c b/net/ipv6/seg6_local.c index 7ff54db..825b8e0 100644 --- a/net/ipv6/seg6_local.c +++ b/net/ipv6/seg6_local.c @@ -72,10 +72,6 @@ static struct ipv6_sr_hdr *get_srh(struct sk_buff *skb) srh = (struct ipv6_sr_hdr *)(skb->data + srhoff); - /* make sure it's a Segment Routing header (Routing Type 4) */ - if (srh->type != IPV6_SRCRT_TYPE_4) - return NULL; - len = (srh->hdrlen + 1) << 3; if (!pskb_may_pull(skb, srhoff + len))