From patchwork Fri Aug 18 00:02:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Lendacky X-Patchwork-Id: 802975 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="JPoYvTOy"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xYNZ11KRlz9t3m for ; Fri, 18 Aug 2017 10:02:33 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753828AbdHRAC2 (ORCPT ); Thu, 17 Aug 2017 20:02:28 -0400 Received: from mail-co1nam03on0089.outbound.protection.outlook.com ([104.47.40.89]:6368 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753806AbdHRAC0 (ORCPT ); Thu, 17 Aug 2017 20:02:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vQjHERRe9OPkOYaqEyrolFHWorvMEPcchZEdzzatKFM=; b=JPoYvTOyiHwreBQAU6fBmszgH6wTgHx0lod9QN5qy0zldjtRe1EKU6/xNPd1uUfl2addeq+Wrpu/2JAE6G7xr7Zyv3GHwKiaFjS5JcgwW4j7rgQeqsdgAeFwOmjAt/5QfA0qqnJxwb6tuEsXR+ftapG2AEDrLkiPgmXatmAlsTM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Received: from tlendack-t1.amdoffice.net (165.204.77.1) by BN6PR12MB1139.namprd12.prod.outlook.com (10.168.226.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1362.18; Fri, 18 Aug 2017 00:02:24 +0000 From: Tom Lendacky Subject: [PATCH net-next v1 02/14] amd-xgbe: Set the MII control width for the MAC interface To: netdev@vger.kernel.org Cc: David Miller Date: Thu, 17 Aug 2017 19:02:20 -0500 Message-ID: <20170818000220.10005.98781.stgit@tlendack-t1.amdoffice.net> In-Reply-To: <20170818000201.10005.36182.stgit@tlendack-t1.amdoffice.net> References: <20170818000201.10005.36182.stgit@tlendack-t1.amdoffice.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: CY4PR04CA0050.namprd04.prod.outlook.com (10.171.243.143) To BN6PR12MB1139.namprd12.prod.outlook.com (10.168.226.141) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f8224388-bdac-411d-b3e0-08d4e5cc681e X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BN6PR12MB1139; X-Microsoft-Exchange-Diagnostics: 1; BN6PR12MB1139; 3:lh5qq3OBjUud20dMwXJwCHmu1jDfDa77kEMbYjXXd+Nchw9HdZsBDrUO1bQf+uHxlvFC8T+CtnCuPsk8AoCR+5QNotO/quV+i076LyONOVnZCtrpnmatl+dZNWfxomcXwHosw39VEAamQJtIEp2zyH07hhA57ULxIZr6rzN4dWeMXYbbNiC8uKENXXuFoX0cQO5sbxb9dG3rO7m5YN6jsxEvm1ygJLe8fW9koM86E83qU7945B0Ct0klnPTYYj+Y; 25:QRk+1i2AyUsa6G2xUTx8tq36wDGUbasQ39IBxI+WVVc9FZ91ZjwHqzeEwxgemG56j6JCdNoXlu4tPaprpNN7RJDajxk3EysVmJ1+bj9sC5ylyCcMEqmGT/DdmTl/fVOyZhEJIPPiTqBXxVOvts5rwhaUQA80GKaBxueFFvGrlIMjnDFPNZA5nRf9o7Ztktb1BqUBuzTMFBtZEUhrTOYU1VpH1+pqcJY5ybPEa8HaJ1FtABbrR8eWgO22SZV0jFwgdfbn02yhev1mT8ShKdCgim9WbtM4P9qpqKBQDeP15ofwgbmGVJYbrW+WFA6jxzqy5ET9WfUiXJbGs+r/ZWVEsA==; 31:LkhJI+EhIAx6KL3D7Ogq5xu1NWL5OwWM40IKmnA5aUeWRjDDhUdN9aXZHKhUmfsSezdYhkt9kepWU3tQc0cz9wSp1UyszE4h0LKL2qk/wfnQwBMrGc7Wk/o0r8c6F/w/VIElwGX5xBDGIYdfbncmfB8Z5pk69NyJTZ57u0copk7aTskF/j17/2Rn0CX582j4Y0JJpW3bbMWZ/rsWtv7xzru/7fi1VPZzBnYEVoeHxqk= X-MS-TrafficTypeDiagnostic: BN6PR12MB1139: X-Microsoft-Exchange-Diagnostics: 1; BN6PR12MB1139; 20:ADqJu+0PcW/sWuy1fA6gNgBeqlbpAaqUgMpC/RXy4+yHoj3gll2I0T41wiyCrxGy7WgQ2hli/p+i8MdUwECLkpp32sukL5PPokvMc2b1YMID6Q+RsgdwA20rrgXsR/AUM2zUdBFR6LppRAD81HDPUhqQQxJ5M94dpbfomp90YtF8LtQY/q8zaLbTFVOM97gi6yLW/GLbyeE2s1xd2ZAtA6q5Lg6vk/+LP1g26+ZwtpbF7FHdZTilgz1lM30vz3fDOPVh1R8M83N8lDbhOM/iYky3P2KmrHgt6jlPgUp4I4fLLft1rfDnphOvaFhl7Hc6jRpyrPkka6yIUmwLkoNIJGTgboVCELXC/AmwMe3lsuGnPB4HE7EgQV+qdMhM3siAkz3ToNpYXH2Qa8p7uGikQIzBVqsJs5qCHQy+YwtA04nR0jhc3JsHzsBfrRNNI1lnWJuKK96g9ZWTtMfvjLt1JZO7tcqcKpYXQBGOh8zvZY+gohppYoRXDspnASkdNJ2d; 4:UQg9owobzWiNiVsgUPbddguC1Nn2xJsmwims60NUf3SZtp6TBv99SvwCk9oTsHoGtoSreuxSyZWqRZtovOy+otSBIeXyekB3dMP1LS+nipTYCUCwsXNpwd7Zuu8sz0I00vLBewicgNKo77MBoTBn54qbBMP/SLmMH/SXcEIngdYdlmMIfR8UBSW7MJ3FA42IiQZCdBTvUkM7JEGFkBfR9s5oqZ1i74H/bU+7t119tbbe3T7QUQDPkTNHoh27rdULnY49xEoDhdUpl8092ssb6Z7DKsHulLaJS/909Hn6Xdc= X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(3002001)(6055026)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN6PR12MB1139; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN6PR12MB1139; X-Forefront-PRVS: 040359335D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7370300001)(4630300001)(6009001)(39860400002)(199003)(189002)(81156014)(8676002)(230700001)(2906002)(6916009)(23676002)(50466002)(2351001)(4001350100001)(305945005)(33646002)(7736002)(97736004)(1076002)(6116002)(3846002)(106356001)(81166006)(478600001)(6666003)(105586002)(103116003)(83506001)(2950100002)(53416004)(69596002)(53936002)(42186005)(110136004)(101416001)(54356999)(7350300001)(189998001)(4326008)(76176999)(50986999)(2361001)(55016002)(5660300001)(68736007)(6506006)(72206003)(86362001)(47776003)(97746001)(25786009)(66066001)(9686003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR12MB1139; H:tlendack-t1.amdoffice.net; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjEyTUIxMTM5OzIzOllnZ2FJMkNyTlpma2s4ZElTWVp2dVVDclMy?= =?utf-8?B?RkFHVHJsNGo1R1ltbEZER0IreDRuNTRoNldEU3ZDQThXS2MwbUFEVzV1UzE1?= =?utf-8?B?SEJlZjhFYWhPY1U2N2ovM0FiZTRIQ3JtTmJ3NFMvMlA4bjhMUHZ3OWVkeXhx?= =?utf-8?B?OFpOZ20wT0pqaTBpNDMvZmYxREdPTTNLUk15Z0I5dnRzZnNmbXJHSFhaMzFt?= =?utf-8?B?VFFuWUFUM2tyOWMrVDRQS1VPM0pZRUMrVmRReHM2RHNxMnRYclR4d0s4Vk9S?= =?utf-8?B?SzQ1VTlpaWJJVGFHQW9mSmJsRzEyQzRZUHVjajBZVGdlakZ6cW1jcC80Rzh6?= =?utf-8?B?c1NKSXN2MEhhUzJsWmE4M25YWE1UTHVZUHZtcW40TTN5Vmx2djlSS051VjNo?= =?utf-8?B?OHBydU5YZTdqcUExeDBIWVlKK2NIaktLa0Q4SmwvR2ZQL1ZkVng1TkJlaE1t?= =?utf-8?B?Zi9PZHY0TkE4TTZtVmNyL2MxekducDRLTGZ1WGVoaSsyTUN5VjA1MnI4Yldv?= =?utf-8?B?bHVuOHBYWDAvcXJIYUFCNnQ4T09sZ2FZcDhQbE9qT3FXOVZoRHFIK2h4TDNa?= =?utf-8?B?YlIvYWdaVXdEY0RBU05BTGR4YkZHNWJxZ21WSFBDVCt5bWpsZFNXSmZycWFZ?= =?utf-8?B?TkpHM280dUdEV09hYXA4d0VVYkViUnBkRDByaUQ2Z3B1NUZLcU00U1dPdk1w?= =?utf-8?B?ZkNySkhvRXU1MVpDeGdRdm1Ib0NlQytaSVJGczJyRXhISkJGK0JzbWRiSmZT?= =?utf-8?B?b2lqRXE5RnhWeU05anJmeVBlbS9NUk9MZmVWZUxnZnk4MDhzYlpOU0FYWmIz?= =?utf-8?B?OFdFMklacEJkR3hxSWZWMXM0NGdyc09KK2pyUytwU1dLSlZXU0pzQ3l5Qzlu?= =?utf-8?B?WXErUDNtL0xBTEIyeXZ3aE4zbXVqNVJ3S29WbjlUS1hObXNPVHlXbndVWFVy?= =?utf-8?B?WVZEZE1ja0VQNjg1WlFiR2tiQUlDZTBZRlVsL01BaloyZ0hEZmFSUGhhazhx?= =?utf-8?B?Um5yZkZidXlGUzhSaWxZUk9FNUw5YXNTZkQwQ0k1VktKNStVSWF0aERIaHVL?= =?utf-8?B?UlN1dDNsNTU2dE9teWNrQWIwRWNad0VCS3NPTCs1alBRZGduVHJzdHpvM09H?= =?utf-8?B?TGhYMkVIY1BPNjBKSkFzVkVSZGw3ODhJSWxQbVpxaDFGWCswNVM1ZXpxZDdD?= =?utf-8?B?VnBIWmk1b3JBcDQ1VjZWQkJOcWJ2WjY0SjdFVWhBeHdTVHQ3SXE5dHNnVnpl?= =?utf-8?B?WUdKYWpOc2RpaHJCVmQyRFJUdythU0JtS2s1a1VPV2dJd1J2aEc5TC9KdTl4?= =?utf-8?B?Y2dNb3crVXppN0NraFczQnJqNmhMa2VOZlgvZGxleEF5MkdNYkNpM2JZZ2h2?= =?utf-8?B?NEJONFFROWtYUk8rM2ZwbnpIRWw4WmZRY1g2dGhIMGJDamdwSUo5R3JhVERV?= =?utf-8?B?cFI3dGVCV01sdzNzQlpIWENyWGlBQ2s4Q3VDNFRVYXZRNis3SXhRUlM3STZZ?= =?utf-8?B?WklPZ3I5NU02TkxyYllkMmpBWngvYjNwbzNveEpEak9BQWJ1VXhwa2N3dHl1?= =?utf-8?B?endRbmlid0VjMU5STmhhMFB0dnBhVTI1OWZCMXlMekh0bldNMGMrUVM2MlM2?= =?utf-8?B?ejk0eFdDMVpPdUtOelg3NTNWdUgxdEgxQXZJQlBzVTRyYmkwSFIvejRpMVBi?= =?utf-8?B?MWRhT1hvM21hSkRKVFIvU01hWFAwa2tCbHBCMzNQYS9MUWtxVmNIU1lkZFZl?= =?utf-8?B?WGFPNUZNVC9zVzF6QStuZz09?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR12MB1139; 6:w3ffJXfdolsMnAiRuI6jaafQfjRGndOVSwK+T04AasOu+l065dIig64WCUaf1M6zhNyQU3nf3piwmYRI/KUGZsFOCa//2LpZY5fDGOri/nhkh+eYgfqeug+FDfPhz/bqXhA5wytptQ4D6q6YNPMwRKHsm3uzMhbD2LuSrvHwDXXthKFPt0Bs03nSPLRdDq79ky81gKyXMMF6PM7Kx9hI08H1hPX07nTVbisCzNcgzSg/Ua/LrvQiRuRxTb/WMNYW2+9ua/74Qw1swSoBdZ2vDht9OZ2YvJ4wkCgzdoEU2QXmfrKL8ePcCs2tHBLzsLosLvt/IADoXdmShDe67xReWw==; 5:P9JBxRzub+jcP5edKo4amw+EXrflxph+QnnsfNPUkrHU/sKq5Ogjv1ZhmJ4TqkMY56K9UXH0qksT0VTNgjSAZRzrHKWeP/A0+uV2oaXynSbDo8U5Q6SWSrkiKfN9dGPYlPF5SyAlFmZfz4DPAPMIoQ==; 24:cq2VB/6cYgq+Ml9EzkN7nqzA153h5ug2PsmFXuF3oUB42OgDAWxXJTrrIfwdjgs7kcthQExtAcWaMaxxOCJjbOJXa5q3W/Ky1WYIIcA1tbQ=; 7:us3Mq0kIC0ngfRu7UVlG09sMzTjjtB4WBFWnVpIkfPEZ/4yYQ/F2F4/Ot+qLEA5F5K0InwMKPlBII6Vm4FGSVJ36dOSokbvECOaiQ7t0R/U0nzTiyA0sui0+Sn7878rT4Cq2nKaxY82YicFTlx1VvBttO4MSacEGBOM/lJq0NczV6cyIKPtnmo2Yi7V8px/OXaf0je9ie2KeC1dEJIFMP4KVNYDZuKTY0KSACO8FgjE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR12MB1139; 20:QqNx3x8h/s8SBaGqlqLMMGyBSPj1tef2YFgCdsfOArwCs8q0+dspIAiMufggsJl6nMZlsaH7k3BsSeEtj6o7uNbQrBZk0KkLj+8IMgZF2D/ZB7vFvnklfPqAXFwXkpz7penuUDhbxT1X5KXXski449nqnaBOEiF+5+/WCrJjkmztL3YH1hKEvyJOsHV21jcqOKPpjFCfIMtH8HbSSNEYT+wtJjl85H6uI6FkToSHgEh8gkG5tfw7tZVQ+70kTecp X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2017 00:02:24.4795 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1139 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When running in SGMII mode at speeds below 1000Mbps, the auto-negotition control register must set the MII control width for the MAC interface to be 8-bits wide. By default the width is 4-bits. Signed-off-by: Tom Lendacky --- drivers/net/ethernet/amd/xgbe/xgbe-common.h | 1 + drivers/net/ethernet/amd/xgbe/xgbe-mdio.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-common.h b/drivers/net/ethernet/amd/xgbe/xgbe-common.h index 9795419..d07edf9 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-common.h +++ b/drivers/net/ethernet/amd/xgbe/xgbe-common.h @@ -1339,6 +1339,7 @@ #define XGBE_AN_CL37_PCS_MODE_BASEX 0x00 #define XGBE_AN_CL37_PCS_MODE_SGMII 0x04 #define XGBE_AN_CL37_TX_CONFIG_MASK 0x08 +#define XGBE_AN_CL37_MII_CTRL_8BIT 0x0100 /* Bit setting and getting macros * The get macro will extract the current bit field value from within diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c index 8068491..2222bbf8 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c @@ -982,6 +982,8 @@ static void xgbe_an37_init(struct xgbe_prv_data *pdata) break; } + reg |= XGBE_AN_CL37_MII_CTRL_8BIT; + XMDIO_WRITE(pdata, MDIO_MMD_VEND2, MDIO_VEND2_AN_CTRL, reg); netif_dbg(pdata, link, pdata->netdev, "CL37 AN (%s) initialized\n",