From patchwork Thu Aug 3 14:30:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?UTF-8?q?Jo=C3=A3o=20Paulo=20Rechi=20Vita?= X-Patchwork-Id: 797240 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="mM2q9KIx"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xNXXf3tWLz9s82 for ; Fri, 4 Aug 2017 00:30:42 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751773AbdHCOad (ORCPT ); Thu, 3 Aug 2017 10:30:33 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:37576 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751144AbdHCOab (ORCPT ); Thu, 3 Aug 2017 10:30:31 -0400 Received: by mail-pf0-f193.google.com with SMTP id p13so1660639pfd.4; Thu, 03 Aug 2017 07:30:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JNH2mDigppKAD9+tLTzD1BQNKiPoQ2tgxd+s+reBVlw=; b=mM2q9KIxj8iwJkTqFaHnuxWpfi4mCRzICyMMJaPpkU2atE8rwhVRq3rVBFm+TKrZR0 +JTp8H3jeRBbCZkZYbs/CY9W46AXH6GnBgTSKaD5J0mP/KGtZrFgD1lHimN0z5E/wQjP 8PQ6tP6F3Xhkbkdq+ybBdQjsMjG2UYJWvI2FzW9ks/j1vpoIYQaOqbf3kM+ArL+1coTe 4cMkDbJi0sPSHIX8DL9jHloSKwuEL0ogbbxma8f4ZQ0WfsLGVYcmlyci5or1xjg0FZSG EuFDARlMTgjktaQ2gSNm1HNXrwbrTjL2lJgk09oMrAazS7Ksa6CtGtwXwVBpguBNyjPo To1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JNH2mDigppKAD9+tLTzD1BQNKiPoQ2tgxd+s+reBVlw=; b=ph33ArKEAxqszTXDmJ4Ny4qMgxb2J/YPum3DdidkuD9yI40AaueRz5WPWMvH0HxxsH hfjhuaAAtnJHJ3zt5LnfkiZ/cY/zV5ZTpy8l+zp7DXU80vyQ0QaTJRUJ6cNY8rLGW3JW icYLLAlMPxUE9KGVMIpQwCAu1rUer13rkjM3Ru8kiS6zJgFWz4sN59U724RRojQ8FGht cG05yVHxJhmQ+2sq0kFoZPjLkfX1lI1x9ax7VNYr2c401WjvmVLGvgmtzDyIuC8eLRbn OYfW/48x6muog4FoHI3TXhfynykdF76YZ1aXj7GuTCGmo1mLbVYH5KyuBldtswsflmdc torw== X-Gm-Message-State: AIVw111/sRD+Uaxl20q7ry2X2B/2B9NBH7Cc1PFGQAHJ9m6UM43PSbsx SVpa1HYkR4d8JQ== X-Received: by 10.84.236.70 with SMTP id h6mr2146740pln.348.1501770630386; Thu, 03 Aug 2017 07:30:30 -0700 (PDT) Received: from kiddo.endlessm-sf.com ([2601:602:9602:62b7:9d4e:d979:4672:3ce]) by smtp.gmail.com with ESMTPSA id x25sm21759670pfk.80.2017.08.03.07.30.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Aug 2017 07:30:29 -0700 (PDT) From: "=?UTF-8?q?Jo=C3=A3o=20Paulo=20Rechi=20Vita?=" X-Google-Original-From: =?UTF-8?q?Jo=C3=A3o=20Paulo=20Rechi=20Vita?= To: Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , Kalle Valo Cc: linux@endlessm.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Jo=C3=A3o=20Paulo=20Rechi=20Vita?= Subject: [PATCH v2] iwlwifi: Demote messages about fw flags size to info Date: Thu, 3 Aug 2017 07:30:05 -0700 Message-Id: <20170803143005.31379-1-jprvita@endlessm.com> X-Mailer: git-send-email 2.13.2 In-Reply-To: <1501649208.2588.55.camel@coelho.fi> References: <1501649208.2588.55.camel@coelho.fi> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org These messages are not reporting a real error, just the fact that the firmware knows about more flags then the driver. Currently these messages are presented to the user during boot if there is no bootsplash covering the console, even when booting the kernel with "quiet". Demoting it to the warn level helps having a clean boot process. Signed-off-by: João Paulo Rechi Vita --- v2 changes: - Set to warn level instead of info drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c index be466a074c1d..c98a254bbd4d 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c @@ -461,9 +461,9 @@ static int iwl_set_ucode_api_flags(struct iwl_drv *drv, const u8 *data, int i; if (api_index >= DIV_ROUND_UP(NUM_IWL_UCODE_TLV_API, 32)) { - IWL_ERR(drv, - "api flags index %d larger than supported by driver\n", - api_index); + IWL_WARN(drv, + "api flags index %d larger than supported by driver\n", + api_index); /* don't return an error so we can load FW that has more bits */ return 0; } @@ -485,9 +485,9 @@ static int iwl_set_ucode_capabilities(struct iwl_drv *drv, const u8 *data, int i; if (api_index >= DIV_ROUND_UP(NUM_IWL_UCODE_TLV_CAPA, 32)) { - IWL_ERR(drv, - "capa flags index %d larger than supported by driver\n", - api_index); + IWL_WARN(drv, + "capa flags index %d larger than supported by driver\n", + api_index); /* don't return an error so we can load FW that has more bits */ return 0; }