From patchwork Tue Jul 4 19:16:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mahesh Bandewar X-Patchwork-Id: 784233 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3x2DJJ28j3z9sNc for ; Wed, 5 Jul 2017 05:16:32 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bandewar-net.20150623.gappssmtp.com header.i=@bandewar-net.20150623.gappssmtp.com header.b="0xh+Thio"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752202AbdGDTQ1 (ORCPT ); Tue, 4 Jul 2017 15:16:27 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:34029 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751960AbdGDTQ0 (ORCPT ); Tue, 4 Jul 2017 15:16:26 -0400 Received: by mail-pg0-f66.google.com with SMTP id j186so28407007pge.1 for ; Tue, 04 Jul 2017 12:16:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bandewar-net.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=/oOSlRQI3fyu6b7DNBQX3qhSobO1SmGXLCsmMAQFc1U=; b=0xh+Thioz92x7dqKEL1O5SwLiTbpI4NET1VpvJ+HYl8fjVdyCJQlIdwmLw32+id4Wm bUY4IzyLfL+JDvkpxIUUu5BKrKubyhFSsdn6WZ8iSHC+tV/sTXnuMEzTb8EcjvpehTB/ c68yxdncSF8GVbBBebTG0V53+Pk5IcWfF1HLHZE9gEQkk7g+5UxF1a22YGLvMJ2VpOkt XC77/SWTmA0ajSqeAJBG6Q1JiFyk5dPkEmCT0GlUI+OG6dXNCWyphyQKsA8LXFpMeRQ6 //1wyvNg4O6MyLUpaAnsjNyaYShrJfKMse1nQHEk0NifpP7xMZm8SJdty7S8iWcYWmt7 1aEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=/oOSlRQI3fyu6b7DNBQX3qhSobO1SmGXLCsmMAQFc1U=; b=Ra10x7oMkA4P0cbFOnO4LCx+f4cVzr1wzIUFTMu4HMGb3vHekSSJyJihLQnGpzUk6+ +f34m/tsY3OQ+Z0abjhnahNSGojK44hECKv+Gu2map8BEyqmWPxwE3IY8sH9DWa8lG3o fCtU9qFLeuT7gLvLwB/3OQbDxj766t7Zy3uhTvWDd/V6tgM1KiRiYpYxvG5CwyZ+Hcaf HooTqCnja/Q0EubLYRwUuSa2veODLTPfEpma44La0LJ/srvASx9S02+rSfxuhkc8TF/j SujV8ylbSnG7t3AvDV9WuvxRAnnji9T16oY9wI+HGXaCvkEUwP4+TfgXgtd96h1asJYA /iYg== X-Gm-Message-State: AIVw111fAUgSdT6IVPz2JspSam5Bz0L6p+4U8Gf3+b20UJ1flgxCrHbK 7WsVgIfF7Pm52bhj X-Received: by 10.99.185.5 with SMTP id z5mr17168343pge.231.1499195785386; Tue, 04 Jul 2017 12:16:25 -0700 (PDT) Received: from localhost ([2620:15c:2cb:201:7058:d186:e0ac:c77e]) by smtp.gmail.com with ESMTPSA id d70sm21143748pga.49.2017.07.04.12.16.24 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 04 Jul 2017 12:16:24 -0700 (PDT) From: Mahesh Bandewar To: James Morris , Hideaki YOSHIFUJI , Patrick McHardy , David Miller , Eric Dumazet , Eric Biederman Cc: netdev , Mahesh Bandewar , Mahesh Bandewar Subject: [PATCH 2/2] loopback: bringup 'lo' by default at initialization Date: Tue, 4 Jul 2017 12:16:23 -0700 Message-Id: <20170704191623.6583-1-mahesh@bandewar.net> X-Mailer: git-send-email 2.13.2.725.g09c95d1e9-goog Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Mahesh Bandewar loopback devices are always brought up right after its initialization including the case of network namespace creation. e.g. ip netns add foo ip -netns foo link set lo up This patch will eliminate the need to do that separately and would bring it up as part of the loopback initialization. Signed-off-by: Mahesh Bandewar --- drivers/net/loopback.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c index 30612497643c..3216977935d1 100644 --- a/drivers/net/loopback.c +++ b/drivers/net/loopback.c @@ -217,6 +217,12 @@ static __net_init int loopback_net_init(struct net *net) BUG_ON(dev->ifindex != LOOPBACK_IFINDEX); net->loopback_dev = dev; + + /* Set the loopback device UP */ + rtnl_lock(); + dev_open(net->loopback_dev); + rtnl_unlock(); + return 0; out_free_netdev: