From patchwork Fri May 12 10:09:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 761517 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wPQgw0YR6z9s4q for ; Fri, 12 May 2017 20:09:48 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ot5xbbUF"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757025AbdELKJp (ORCPT ); Fri, 12 May 2017 06:09:45 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:33155 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756326AbdELKJo (ORCPT ); Fri, 12 May 2017 06:09:44 -0400 Received: by mail-wr0-f194.google.com with SMTP id w50so6970299wrc.0; Fri, 12 May 2017 03:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=BvgjLoDYHFBJ9rqF92Nz1nw9sAaZc663zJFRFhSYN5Q=; b=ot5xbbUFh3uyxtnnqB3WIjyaTYXSbW191jT0MVUTAP+ZqyKCRpWvFNPL27wcxnQor7 UYj34z7TXc8IC+YSbdjgQyatQaGpQ8KEi3JGsDC48denWhdXGRQgxY9ag1gnXw3iRUq5 MjUemR0OIYB4rnL66YWqTH2XIEbML5unm3zozSisiZD/yO5AEp+I4vy025XJFA1yUTDl WqL19wqzq0L7w/lXczTARe4kosz2A1d2EPjE+MXF6ntSLqfLcNqb+GYLSG9eB8KZ2AH9 QyytTHtbT3aaIn82+vZUom1ezZyqm7fuMm87lr0mGF9ShKBHiyUvvqlyFuNsYWG5u6VX 9/kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=BvgjLoDYHFBJ9rqF92Nz1nw9sAaZc663zJFRFhSYN5Q=; b=nZW4n/+oJlPQAZoRQ2PmcJ4cNv8/6koOtnzFTzf89uj4VbMSX1HleZMcCmakY82FL2 zf8JUInrCnojt4H7H1dUNDDg6ICbuq3c1nIkscYINisE3gA5L4o+twwAIfTwDpx8FTpB iWO5FnM24o5tYiAWXjsJycRZmgp4NzmL6nS2eyjhSp5QuaGNy4sO1mtALdaFpaBqRWo1 gZ0fJ2EZGbs5myfBDW6fboHooh7k+opfmqGtLvzALB5ciRgVrqHBCvv/PyaJ5Okxgk6p /YVvXdOeoj3IL5qpOSVjQVmsUUBy31vkLB2nzTNNPR8/B7ks6fSifpD/K915ybpKKgqg IL/g== X-Gm-Message-State: AODbwcCoLx2dO4MxipH8y+RnjZLFHPzJq83/bNSEzdl2abV3aAK6XwhF tjvzzbJOxShIFA== X-Received: by 10.46.77.204 with SMTP id c73mr828773ljd.73.1494583782908; Fri, 12 May 2017 03:09:42 -0700 (PDT) Received: from xi.terra (c-42c8e255.07-184-6d6c6d4.cust.bredbandsbolaget.se. [85.226.200.66]) by smtp.gmail.com with ESMTPSA id y1sm198563lja.24.2017.05.12.03.09.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 May 2017 03:09:42 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.89) (envelope-from ) id 1d97Vw-0000UN-Td; Fri, 12 May 2017 12:09:36 +0200 From: Johan Hovold To: Wolfgang Grandegger , Marc Kleine-Budde Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, Johan Hovold Subject: [PATCH] net: can: peak: fix product-id endianness in error message Date: Fri, 12 May 2017 12:09:25 +0200 Message-Id: <20170512100925.1841-1-johan@kernel.org> X-Mailer: git-send-email 2.13.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Make sure to use the USB device product-id stored in host-byte order in a probe error message. Also remove a redundant reassignment of the local usb_dev variable which had already been used to retrieve the product id. Signed-off-by: Johan Hovold --- drivers/net/can/usb/peak_usb/pcan_usb_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_core.c b/drivers/net/can/usb/peak_usb/pcan_usb_core.c index 57913dbbae0a..1ca76e03e965 100644 --- a/drivers/net/can/usb/peak_usb/pcan_usb_core.c +++ b/drivers/net/can/usb/peak_usb/pcan_usb_core.c @@ -908,8 +908,6 @@ static int peak_usb_probe(struct usb_interface *intf, const struct peak_usb_adapter *peak_usb_adapter = NULL; int i, err = -ENOMEM; - usb_dev = interface_to_usbdev(intf); - /* get corresponding PCAN-USB adapter */ for (i = 0; i < ARRAY_SIZE(peak_usb_adapters_list); i++) if (peak_usb_adapters_list[i]->device_id == usb_id_product) { @@ -920,7 +918,7 @@ static int peak_usb_probe(struct usb_interface *intf, if (!peak_usb_adapter) { /* should never come except device_id bad usage in this file */ pr_err("%s: didn't find device id. 0x%x in devices list\n", - PCAN_USB_DRIVER_NAME, usb_dev->descriptor.idProduct); + PCAN_USB_DRIVER_NAME, usb_id_product); return -ENODEV; }