From patchwork Tue Apr 18 10:13:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfgang Bumiller X-Patchwork-Id: 751755 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3w6gvK3TlVz9s7M for ; Tue, 18 Apr 2017 20:13:33 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756125AbdDRKNa (ORCPT ); Tue, 18 Apr 2017 06:13:30 -0400 Received: from proxmox.maurer-it.com ([212.186.127.180]:2471 "EHLO proxmox.maurer-it.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932288AbdDRKNZ (ORCPT ); Tue, 18 Apr 2017 06:13:25 -0400 Received: from proxmox.maurer-it.com (localhost [127.0.0.1]) by proxmox.maurer-it.com (Proxmox) with ESMTP id CE9F010C79A7; Tue, 18 Apr 2017 12:13:23 +0200 (CEST) From: Wolfgang Bumiller To: netdev@vger.kernel.org Cc: Jamal Hadi Salim , "David S. Miller" , Cong Wang Subject: [PATCH v2 net 1/2] net sched actions: fix access to uninitialized data Date: Tue, 18 Apr 2017 12:13:21 +0200 Message-Id: <20170418101322.27666-1-w.bumiller@proxmox.com> X-Mailer: git-send-email 2.11.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Signed-off-by: Wolfgang Bumiller Acked-by: Cong Wang Acked-by: Jamal Hadi Salim --- (same as v1) net/sched/act_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/act_api.c b/net/sched/act_api.c index b70aa57319ea..8cc883c063f0 100644 --- a/net/sched/act_api.c +++ b/net/sched/act_api.c @@ -604,7 +604,7 @@ struct tc_action *tcf_action_init_1(struct net *net, struct nlattr *nla, if (err < 0) goto err_mod; - if (tb[TCA_ACT_COOKIE]) { + if (name == NULL && tb[TCA_ACT_COOKIE]) { int cklen = nla_len(tb[TCA_ACT_COOKIE]); if (cklen > TC_COOKIE_MAX_SIZE) {