From patchwork Tue Apr 18 06:21:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Thelen X-Patchwork-Id: 751673 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3w6Zm2181gz9s3s for ; Tue, 18 Apr 2017 16:21:54 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="uWLqIbgZ"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753852AbdDRGVu (ORCPT ); Tue, 18 Apr 2017 02:21:50 -0400 Received: from mail-pg0-f52.google.com ([74.125.83.52]:35679 "EHLO mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751675AbdDRGVt (ORCPT ); Tue, 18 Apr 2017 02:21:49 -0400 Received: by mail-pg0-f52.google.com with SMTP id 72so74406509pge.2 for ; Mon, 17 Apr 2017 23:21:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=4WG2vqDFDrVPTuqA62EywGBcB6n9dp/k1ZVijyI5X3I=; b=uWLqIbgZBphP79NA+LUBMQb9v2Xd3uGTTAc2oNhjsXu9DsvUHdl7G6Ys7Fu61hVO1o PEFW9X11kOz4n5OomYle4ifqX0DTT9Ho2KRE5pBiEtmcU6kR80AO/eIvWQIWNH/4932R 45A3IT/2nJ0Wq9s5dTWpaGHpxFqT49H3jpZD/8QniMmWokDKD+gf+5RqdrWs8+qLzdX7 IpUzYkQGmyJrNzCO8JUi5mnhkliNPFXZL1JAkMfkURE1aBpyqiLuITWmnHs+XgomVzrj gQBJ5LvNXogd4hcUQ3keMxfUsoF7zd8p6VJH7g8lUydd+DZieoXuNjOjHSHW42w7eppp hU4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=4WG2vqDFDrVPTuqA62EywGBcB6n9dp/k1ZVijyI5X3I=; b=jYFPaWB7xniwqu6eQYMxuuyiMKazEGhvILvReuvBLOZW76WGVqZiou+p1REz4nid2m YslBAGj3lZ9UypsuM1Pr5K25JeC1AoGiq1l5bDXZ2r4gRqsWbbaukGE1IrveD5/o0MHk jq9nit57wZQHlgfczWsnU6huA7wXQJTKypCTexBno8XxlzYfZxkvsRO/1YEXl+Um+5oI LZFG1ARkXHgTVeectBhHdSXIR8AibmaKyc42KQ6gnWLvrDrrD9YDsCtKQymtgQ7wi/TM I9HJTHkWjhlyPfpzvtw+9MDjSI1483xIM4ltN9ouI3+f9IRLBWyLPmPWUhnbNDk3XDE5 KwDQ== X-Gm-Message-State: AN3rC/4gpqbRyVr2q+GqzLttMOUmhYpxLY701VVTiFohQbSnnjq55Wyl ZDqUBjoeEU/vtp+J X-Received: by 10.98.131.67 with SMTP id h64mr15368729pfe.61.1492496508065; Mon, 17 Apr 2017 23:21:48 -0700 (PDT) Received: from gthelen.mtv.corp.google.com ([100.99.140.58]) by smtp.gmail.com with ESMTPSA id y78sm1184548pff.107.2017.04.17.23.21.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 17 Apr 2017 23:21:47 -0700 (PDT) From: Greg Thelen To: Or Gerlitz , Jack Morgenstein , Matan Barak Cc: Ido Shamay , Yishai Hadas , Amir Vadai , Roland Dreier , "David S. Miller" , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Thelen Subject: [PATCH] net/mlx4: suppress 'may be used uninitialized' warning Date: Mon, 17 Apr 2017 23:21:35 -0700 Message-Id: <20170418062135.76698-1-gthelen@google.com> X-Mailer: git-send-email 2.12.2.762.g0e3151a226-goog Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org gcc 4.8.4 complains that mlx4_SW2HW_MPT_wrapper() uses an uninitialized 'mpt' variable: drivers/net/ethernet/mellanox/mlx4/resource_tracker.c: In function 'mlx4_SW2HW_MPT_wrapper': drivers/net/ethernet/mellanox/mlx4/resource_tracker.c:2802:12: warning: 'mpt' may be used uninitialized in this function [-Wmaybe-uninitialized] mpt->mtt = mtt; I think this warning is a false complaint. mpt is only used when mr_res_start_move_to() return zero, and in all such cases it initializes mpt. But apparently gcc cannot see that. Initialize mpt to avoid the warning. Signed-off-by: Greg Thelen --- drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c index d8d5d161b8c7..4aa29ee93013 100644 --- a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c +++ b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c @@ -2749,7 +2749,7 @@ int mlx4_SW2HW_MPT_wrapper(struct mlx4_dev *dev, int slave, int err; int index = vhcr->in_modifier; struct res_mtt *mtt; - struct res_mpt *mpt; + struct res_mpt *mpt = NULL; int mtt_base = mr_get_mtt_addr(inbox->buf) / dev->caps.mtt_entry_sz; int phys; int id;