| Message ID | 20170330160012.14824-1-broonie@kernel.org |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Fri, Mar 31, 2017 at 2:30 AM, Mark Brown <broonie@kernel.org> wrote: > This driver uses interfaces from linux/of.h and linux/property.h but > relies on implict inclusion of those headers which means that changes in > other headers could break the build, as happened in -next for arm today. > Add a explicit includes. > > Signed-off-by: Mark Brown <broonie@kernel.org> Acked-by: Joel Stanley <joel@jms.id.au> Thank you for fixing this Mark. Cheers, Joel > --- > drivers/net/ethernet/faraday/ftgmac100.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c > index 928b0df2b8e0..ade6b3e4ed13 100644 > --- a/drivers/net/ethernet/faraday/ftgmac100.c > +++ b/drivers/net/ethernet/faraday/ftgmac100.c > @@ -28,8 +28,10 @@ > #include <linux/io.h> > #include <linux/module.h> > #include <linux/netdevice.h> > +#include <linux/of.h> > #include <linux/phy.h> > #include <linux/platform_device.h> > +#include <linux/property.h> > #include <net/ip.h> > #include <net/ncsi.h> > > -- > 2.11.0 >
From: Mark Brown <broonie@kernel.org> Date: Thu, 30 Mar 2017 17:00:12 +0100 > This driver uses interfaces from linux/of.h and linux/property.h but > relies on implict inclusion of those headers which means that changes in > other headers could break the build, as happened in -next for arm today. > Add a explicit includes. > > Signed-off-by: Mark Brown <broonie@kernel.org> Applied, thank you.
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c index 928b0df2b8e0..ade6b3e4ed13 100644 --- a/drivers/net/ethernet/faraday/ftgmac100.c +++ b/drivers/net/ethernet/faraday/ftgmac100.c @@ -28,8 +28,10 @@ #include <linux/io.h> #include <linux/module.h> #include <linux/netdevice.h> +#include <linux/of.h> #include <linux/phy.h> #include <linux/platform_device.h> +#include <linux/property.h> #include <net/ip.h> #include <net/ncsi.h>
This driver uses interfaces from linux/of.h and linux/property.h but relies on implict inclusion of those headers which means that changes in other headers could break the build, as happened in -next for arm today. Add a explicit includes. Signed-off-by: Mark Brown <broonie@kernel.org> --- drivers/net/ethernet/faraday/ftgmac100.c | 2 ++ 1 file changed, 2 insertions(+)