From patchwork Tue Mar 28 13:57:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 744288 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vssv51T3Yz9s7N for ; Wed, 29 Mar 2017 00:58:57 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Uxz32Fex"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755748AbdC1N6N (ORCPT ); Tue, 28 Mar 2017 09:58:13 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:34074 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755683AbdC1N6I (ORCPT ); Tue, 28 Mar 2017 09:58:08 -0400 Received: by mail-wr0-f196.google.com with SMTP id w43so20143951wrb.1 for ; Tue, 28 Mar 2017 06:57:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jrdCmICpepxkTQfBxRJVI50bR+deFA/w9pGlEwmx5Dk=; b=Uxz32FexJDFiTsi3Gu1qHWrAK4j8JEk0evuyAm1LFRkqxtd47ziPyqwAD1eaL8FGiu Z0TatFw5sMrAcPm82pnZYg6al4mxYuc3qVmWdwlh1CHjoAxx6xSlwNvmGAoxymXA7Lw9 qr4+RZ1zp2KPcqB9DUo/ee2DLJxzqrfDpUOzTBVPIP78/1VJjXqZI2FS76Cs3DAlJBja R83s3kh5ixZeB5UzZIUl+DTcK/zPvWwNHAHQiG6DyVxxFOrnT2KGREsqQVu16Nr4qR1N z8zghOaQ3mR6c4vYR3PEP8y2EWfbOjBaPuqjm520Txn8AJS+qOzlDDu0z7+6XDG7Eueb VZpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jrdCmICpepxkTQfBxRJVI50bR+deFA/w9pGlEwmx5Dk=; b=IxoitXmBxrcPzplNI/bjThfQgHOMHEp2ZfThkmm97Javt1ok+2rxzcOeodcwpBQzuQ JQsheXCEDcUvyOjszIM4KLRGt/in2BAAawMxEYnTv0JVfMoTnMfTS8iku4nyYS8Gccxy ZWVxwC4PTDmu605OXHwV5GbK5+W2Ao7RLm9ogEYbCQS8qujuGjgoQQHr8z2ULemmPzA6 qXnSHhvTlJmntS18RvjzR7txPi81q3xNJw1z1D6It/9lBYELg5/lA8jumtGIYNBioZUB mMQpapx03yi6LbEvo0jLD1qCG/xZUQVw8r/QLS0FxbG9ANzavFN7iLUA7gnXolO/7MSr bDMw== X-Gm-Message-State: AFeK/H3EqINcQ0SxunCAMa+pfAvOItRMn4CydI0V1/iRADRivcFF9q6QDbRTrEoKFQYKmw== X-Received: by 10.223.148.230 with SMTP id 93mr27186013wrr.111.1490709427600; Tue, 28 Mar 2017 06:57:07 -0700 (PDT) Received: from localhost (port-17979.pppoe.wtnet.de. [46.59.131.215]) by smtp.gmail.com with ESMTPSA id i133sm3737226wmg.26.2017.03.28.06.57.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Mar 2017 06:57:07 -0700 (PDT) From: Thierry Reding To: Niklas Cassel Cc: Joao Pinto , David Miller , clabbe.montjoie@gmail.com, peppe.cavallaro@st.com, alexandre.torgue@st.com, sergei.shtylyov@cogentembedded.com, f.fainelli@gmail.com, netdev@vger.kernel.org Subject: [PATCH 1/3] net: stmmac: Remove unneeded checks for NULL pointer Date: Tue, 28 Mar 2017 15:57:04 +0200 Message-Id: <20170328135706.7605-1-thierry.reding@gmail.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <71d841cd-b07b-2635-c2cf-f7af5f5ed2c9@axis.com> References: <71d841cd-b07b-2635-c2cf-f7af5f5ed2c9@axis.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Thierry Reding Taking the address of an element within a non-NULL array will never be zero. This condition isn't checked anywhere else, so drop it in these two instances as well. Signed-off-by: Thierry Reding --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index c78f444ad423..106ace3781b3 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -1332,9 +1332,6 @@ static void free_rx_dma_desc_resources(struct stmmac_priv *priv) for (queue = 0; queue < rx_count; queue++) { struct stmmac_rx_queue *rx_q = &priv->rx_queue[queue]; - if (!rx_q) - break; - /* Release the DMA RX socket buffers */ dma_free_rx_skbufs(priv, queue); @@ -1373,9 +1370,6 @@ static void free_tx_dma_desc_resources(struct stmmac_priv *priv) for (queue = 0; queue < tx_count; queue++) { struct stmmac_tx_queue *tx_q = &priv->tx_queue[queue]; - if (!tx_q) - break; - /* Release the DMA TX socket buffers */ dma_free_tx_skbufs(priv, queue);