From patchwork Mon Mar 27 18:37:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mahesh Bandewar X-Patchwork-Id: 743949 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vsN8140y7z9s73 for ; Tue, 28 Mar 2017 05:38:25 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bandewar-net.20150623.gappssmtp.com header.i=@bandewar-net.20150623.gappssmtp.com header.b="nw/+f41e"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752176AbdC0SiP (ORCPT ); Mon, 27 Mar 2017 14:38:15 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:32818 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752149AbdC0SiL (ORCPT ); Mon, 27 Mar 2017 14:38:11 -0400 Received: by mail-pg0-f65.google.com with SMTP id 79so15027604pgf.0 for ; Mon, 27 Mar 2017 11:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bandewar-net.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=OYv/ZI0dG/YVKL8CT6pbyoZ6p0RLJYP29LP84sneubY=; b=nw/+f41eDq78fo758GFfnIgpH3IUDwm3ajSLPF2pXS01o16QUyWnR6KKexfE9ac2BS ZAjs5eSqkC+EUmFxWdugZ8awtmScyM18nFyrBHqyETkSQS4aFNBe48Om3gUeM1EQaYuG KeqW/zjlaxijkuDZbFAyvcF2lqV6/SYt2XYo2/X/g+iSsD7OMNQVIRrcQTVkMcWPbEbH yHVvagOIZDDqSXokfvs8a7JT4bgMpvSHY29pgphhjthPSbGxUrnwmfxmmPF/PGx3HqYJ koZjWdyoyUhp9BVsHah0zm/6GWIWFXotkZsbQgjDes/1qeravDiGUYSFjmt3WZ6XNFiF BeZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=OYv/ZI0dG/YVKL8CT6pbyoZ6p0RLJYP29LP84sneubY=; b=JZ0k5nLsAdHgxsFapkHEN11VkIQAduzdwtY7d19Jl+uyA/bhcWb1vfTUt3vqUWOzhv HfAJbtqlwsdW6rGg2I/E3EYhLC93WHQt06o1Z99M0z7aQ2ZsjguC5nK6QsU9Mk5sAg20 aQbSqw9fXITMY9rD3Fl1ZzIaEekVywGlKmmttIIOJ3GaigP998QKw9ixRkM0c4w7SKBT Z/uj2bmi/AXmUejLOiLmlWpt03HGG1oe+6xL7pU2l1Z8YhHZIIwfphobdqm36cCDWFvc gmwmzGEhJppW6vhF8QDIp5b/P76lxfYC1+KH0P6Axbm5Y0Kcf6xldS39+DQMSny4Opcq azTQ== X-Gm-Message-State: AFeK/H0qY0Pe2NNah9k2c5L88DTNOKpPvHfogFuj7N1pOegdc63IwRqpla8Q/Rqk2eu9Tg== X-Received: by 10.84.239.8 with SMTP id w8mr30754272plk.73.1490639862155; Mon, 27 Mar 2017 11:37:42 -0700 (PDT) Received: from localhost ([2620:0:1000:3012:18b6:8c75:2322:90f6]) by smtp.gmail.com with ESMTPSA id v9sm2514934pfg.133.2017.03.27.11.37.41 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 27 Mar 2017 11:37:41 -0700 (PDT) From: Mahesh Bandewar To: Jay Vosburgh , Andy Gospodarek , Veaceslav Falico , Nikolay Aleksandrov , David Miller , Eric Dumazet Cc: netdev , Mahesh Bandewar , Mahesh Bandewar Subject: [PATCH next 5/5] bonding: avoid printing while holding a spinlock Date: Mon, 27 Mar 2017 11:37:40 -0700 Message-Id: <20170327183740.31056-1-mahesh@bandewar.net> X-Mailer: git-send-email 2.12.1.578.ge9c3154ca4-goog Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Mahesh Bandewar Signed-off-by: Mahesh Bandewar --- drivers/net/bonding/bond_3ad.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c index 508713b4e533..c5fd4259da33 100644 --- a/drivers/net/bonding/bond_3ad.c +++ b/drivers/net/bonding/bond_3ad.c @@ -2446,9 +2446,9 @@ void bond_3ad_adapter_speed_duplex_changed(struct slave *slave) spin_lock_bh(&slave->bond->mode_lock); ad_update_actor_keys(port, false); + spin_unlock_bh(&slave->bond->mode_lock); netdev_dbg(slave->bond->dev, "Port %d slave %s changed speed/duplex\n", port->actor_port_number, slave->dev->name); - spin_unlock_bh(&slave->bond->mode_lock); } /** @@ -2492,12 +2492,12 @@ void bond_3ad_handle_link_change(struct slave *slave, char link) agg = __get_first_agg(port); ad_agg_selection_logic(agg, &dummy); + spin_unlock_bh(&slave->bond->mode_lock); + netdev_dbg(slave->bond->dev, "Port %d changed link status to %s\n", port->actor_port_number, link == BOND_LINK_UP ? "UP" : "DOWN"); - spin_unlock_bh(&slave->bond->mode_lock); - /* RTNL is held and mode_lock is released so it's safe * to update slave_array here. */