From patchwork Sun Mar 12 23:01:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Frederic Sowa X-Patchwork-Id: 737901 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vhGhp0Q33z9s7K for ; Mon, 13 Mar 2017 10:01:46 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=stressinduktion.org header.i=@stressinduktion.org header.b="ijxALuc8"; dkim=pass (1024-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="d0VsWmYz"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933224AbdCLXBi (ORCPT ); Sun, 12 Mar 2017 19:01:38 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:40126 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755789AbdCLXBf (ORCPT ); Sun, 12 Mar 2017 19:01:35 -0400 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id DBF6F2067F for ; Sun, 12 Mar 2017 19:01:33 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute7.internal (MEProxy); Sun, 12 Mar 2017 19:01:33 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= stressinduktion.org; h=date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=KTF FMs8EmD6Dj0nhIdg/7Cxtv2M=; b=ijxALuc8tJ0D6of9FOCZ3EXoyNe/eTVYe6w Ru/vANLP+O/XyjDLrrrbM0BLbzLKB9Au/kN6fOTssp0x33i0c2NrpKPKgXSFBu8t TcqHYDygbxTArZaSRfgtHI0M0c/DdnJnQPGn7EE9r/+gaMz4NpIJFKjHv9CVmySB sh73oh8M= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=KT FFMs8EmD6Dj0nhIdg/7Cxtv2M=; b=d0VsWmYzaWdh6qhz78ztxKiTNfAeP34FFc z1vqLMzPewWi16oD/olRzSo65iQxH9mRNpQA7qcCWty+juvxnPks1dOwJCkv8sMK dBNREm+i/1NoIk52Jpcg1cdP1kyDOT6iqdrC7lTuFKRl0iWaEZWF322tBnuga9Om 9bEpO7eNM= X-ME-Sender: X-Sasl-enc: 70yrvX/rJs6ggOlQlRpf14z3PeCXiy86GMOVuPv4gGFw 1489359693 Received: from m.localhost.localhost (unknown [213.55.211.72]) by mail.messagingengine.com (Postfix) with ESMTPA id F35482423E for ; Sun, 12 Mar 2017 19:01:32 -0400 (EDT) From: Hannes Frederic Sowa To: netdev@vger.kernel.org Subject: [PATCH net] dccp: fix memory leak during tear-down of unsuccessful connection request Date: Mon, 13 Mar 2017 00:01:30 +0100 Message-Id: <20170312230130.5013-1-hannes@stressinduktion.org> X-Mailer: git-send-email 2.9.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch fixes a memory leak, which happens if the connection request is not fulfilled between parsing the DCCP options and handling the SYN (because e.g. the backlog is full), because we forgot to free the list of ack vectors. Reported-by: Jianwen Ji Signed-off-by: Hannes Frederic Sowa --- net/dccp/ccids/ccid2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/dccp/ccids/ccid2.c b/net/dccp/ccids/ccid2.c index f053198e730c48..5e3a7302f7747e 100644 --- a/net/dccp/ccids/ccid2.c +++ b/net/dccp/ccids/ccid2.c @@ -749,6 +749,7 @@ static void ccid2_hc_tx_exit(struct sock *sk) for (i = 0; i < hc->tx_seqbufc; i++) kfree(hc->tx_seqbuf[i]); hc->tx_seqbufc = 0; + dccp_ackvec_parsed_cleanup(&hc->tx_av_chunks); } static void ccid2_hc_rx_packet_recv(struct sock *sk, struct sk_buff *skb)