From patchwork Tue Feb 28 21:02:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Lendacky X-Patchwork-Id: 733864 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vXs2G4lPmz9s7v for ; Wed, 1 Mar 2017 08:21:10 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="SivX4ILh"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751862AbdB1VVH (ORCPT ); Tue, 28 Feb 2017 16:21:07 -0500 Received: from mail-co1nam03on0053.outbound.protection.outlook.com ([104.47.40.53]:62642 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751793AbdB1VVE (ORCPT ); Tue, 28 Feb 2017 16:21:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=go5Eepo9zrpOezQ66DPimrd0rHKglQH71fWgQ4x5GSE=; b=SivX4ILhJDISp7vRRd3QSWYKSvFx7efi/p7gYBqI7WYfJMFQwiKxTinXj1YyK6N5DWTAoYJKCcaVBgbdGlgNVlcR92grXh2SKKYdUSJUmKwzc6+kbCPl17jnWK2SJERGXicDIylh6ozjhkwqmSiz1YdZ6+2PQwuYw8xsMLceqAQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Received: from tlendack-t1.amdoffice.net (165.204.77.1) by CY4PR12MB1141.namprd12.prod.outlook.com (10.168.163.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.933.12; Tue, 28 Feb 2017 21:02:55 +0000 From: Tom Lendacky Subject: [PATCH net v1 1/3] amd-xgbe: Stop the PHY before releasing interrupts To: CC: David Miller Date: Tue, 28 Feb 2017 15:02:51 -0600 Message-ID: <20170228210251.32166.39747.stgit@tlendack-t1.amdoffice.net> In-Reply-To: <20170228210242.32166.30038.stgit@tlendack-t1.amdoffice.net> References: <20170228210242.32166.30038.stgit@tlendack-t1.amdoffice.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BN6PR03CA0040.namprd03.prod.outlook.com (10.175.124.26) To CY4PR12MB1141.namprd12.prod.outlook.com (10.168.163.149) X-MS-Office365-Filtering-Correlation-Id: f48678d2-463d-4bac-f185-08d4601d2b35 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:CY4PR12MB1141; X-Microsoft-Exchange-Diagnostics: 1; CY4PR12MB1141; 3:YESOdrU4ZGQ8X9YQrt9GFv34RGeTR2Ofdq8WlSYxTNp8HpdNRhn6U9SdHwi/8nvKWHwlxDjxF3BnOeDHF0+Xy295GYiiJ8VGdYQ4kHRNubPuhM9ZF+MeQS52iL4W07eHW75HikomCSRg+0xoP/lr36Q8v4bsLepL/SR6u2/oVY1J1zNEtOtA1OhSxOgZTpbjEUKsYX3lWO810ckMbgsaMecuAEjD8o2O/zez8G/XRhhhNLusLGcBlud3+f3h8vavq1/IHZsShGG9kg7+DI6WbqRz7gAQRY0Qjzc5oJcS+EY=; 25:g9XkzVAydTuN+PhS/0PDQUgAgsQMj5H5mQgmUDHfIfGI/uVGhlwqaOXlX5jKfc4rxcdRYH7tIiPcUu+eIEUMvEfnOa8pdC0f3oCCH4hhf+W3I0CbwNMw8p2Y+8B49cG11ctNCQfqFEHIFr+fzEoOcZTA9K/9p2xlKOh4u+tpuR31OiBGA9zRm7yw/X81CWyW/O3/ziqmgjq7x/liBZP4Q4rLd/XjuLH/YSUX3NLlM7cbWfSn6Z2aSXYqlpV1/1MvlKSTQ3LnRfy0rv0f70sBGUWyEenlGsyl6bqReiR1ald0Mcg6ukXRFd5Skdb2/xUEhDjNqvqo1woCApKn3J87tWqz2mR3v+93qHaIwpUhZCf41d0SIAt95/Ey53jrK41BipHbv7cFs+cD/eByVzA63KN+Za5Tg1C9njxyR0A/GPXcaf4ScJpRCcIkX6ROCamkMFLwZj1mxC6BqSTCenKVyQ== X-Microsoft-Exchange-Diagnostics: 1; CY4PR12MB1141; 31:NHa4j3m+g/HDlVPUESv0vzSK/oHQRCNup3FbguURDQ5QHYr7uiTEMPaH1Jyt3ttdXC5jvB6JEv2SBO7Vz9o0AEYLyTNUW2em35DMhli2iCZqZraLtsN+3U62yCK3o2R7s1nOL9DhlDic6Mrh8e7/gN6Ra1NlKemxDUvjia1FI8d/e+P0b1Q3lwSg9h8QZ4eTHEyvmeZfL64ASa1L/Etf3xK8wFeBYfAPsBNV6ViBnnk=; 20:LImNEAgrcmaLw14xA8fwEYkMuz+gCi9S0dNbRawL85zIfzshSkmHmqRtv+9dEutG7JRRTlAfvTDxUFxz5p+204SAIHHz5t9ECpNSA4BvbIQ4fmm/+zGb+2aWjQsbHGSfhyIkRiIAcqjlpf3T7jr3NKB+gR6GyvOipS7/uc+A/MGH8o6KHhK9S+sPkG5H+5AnDzdEIi2WjsTAvc3BcEQLFy5ckigiCN89reSS/ojNWeF8eIkD00YmqPmB364kD9yzZpv87HaKlMot6RnIlBoMrvRMlZBfGBwxpBqGry6mnI/LE9FG4bPN8/GLNLk8uqfWETE74XGci1tOiWjm/bXmrTm5/BYTFoeZNCmFJVXUd7ZrCCeAlOBfr8+KiEg4SU/WP6HjjPd1HE6cAzSmmx09ydtpOFINVQFEDVUol5xI0JIf2+QYFuR7Km1kJ60pmgcQxmhw0W71FRVndY0K3q7xa8jaEogeG/pPvZkKCy/759yELSESMiA2Q8l7FEN8LpIj X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123558025)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(6072148); SRVR:CY4PR12MB1141; BCL:0; PCL:0; RULEID:; SRVR:CY4PR12MB1141; X-Microsoft-Exchange-Diagnostics: 1; CY4PR12MB1141; 4:RbFEdtGCGirIYYsZnh2OwHEDthfls5fTajnJBj4mOBzLAgyL39uFlU8TYAZTSPfOOpv1THpLyuJUKzox8x/PGebbkDk4arEid98gf5kfHlWYUiAPsZ3uZysbOWm18Ji5prnhny6xb0H8Bo7mY/MrB2LGL3vJc1PYBkX6pIX/nzYyf0JCHGO7MVVKrhIE1fWRUrOD6fnhVaA72y62Y0xSPpn0Ef9lz6iN8b2mrN/6f9QdR4iw3mxsgMdkzMRrREhwK1rKP9e34THIBCwMvEH/oEXNiowdssGsVBEjYvKbMLEhofOHbHj3IfZjLBHEGppwgRALhkj/fPFLrDSLRstqsmu6rV5QvrurpiUuVssm4iNA7BTXPHA7jappouszWoQOSmWZ7H6aBjNNukgFPmw6H8a95v4H7z7htlKyX9bIpc1JMe7stWXa8k+ISliYwFqxJoylqwZGHcpD1T5VQ5faoB/YElLLWpcK5OAO4JTeqJ95IjihTLl69pZZ0Jm7mbCn8Tw6UmGxXVmgwTQhLpVeB302anE/BHWiIw2SyusreC2jjKUOr6K3iXDZNdtJqnm67iC2aANoRZtcTOHdMQPw3Trq6e2RCMZpnC5QJiaoOUpFKJ29sSp1GLJsUT30AEleJCoeh5Wh1yjgGf2bYmmZadZ7/F4PsCSn+LWcB3DqokE= X-Forefront-PRVS: 0232B30BBC X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(39850400002)(39410400002)(39860400002)(39450400003)(39840400002)(199003)(189002)(38730400002)(86362001)(55016002)(23676002)(110136004)(81166006)(8676002)(81156014)(5660300001)(25786008)(69596002)(97746001)(47776003)(305945005)(53936002)(7736002)(6916009)(6666003)(83506001)(2950100002)(33646002)(6506006)(230700001)(3846002)(6116002)(2906002)(92566002)(54356999)(76176999)(9686003)(106356001)(105586002)(101416001)(53416004)(68736007)(4001350100001)(2351001)(66066001)(97736004)(103116003)(189998001)(50986999)(50466002)(1076002)(4326008)(42186005)(71626007); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR12MB1141; H:tlendack-t1.amdoffice.net; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjEyTUIxMTQxOzIzOmZZRVMybkhMNmk3TVpRWFkwNDdqRVp5cE1q?= =?utf-8?B?ODZIZjRnSVpXVGhZbEVDQ2duUEIrNkk2Ri8yMUp4UGdxVTBwMm1GSndTSEVD?= =?utf-8?B?SkJDVUpoRmtXODZiVzFMR0dtV2RybkNnVjh0bmJ3T3pxcnFHbFdYcWVkNERY?= =?utf-8?B?dFVvZzdTNHVWUkdlZ1o2cWljVk5aKzhabzl1bVNjMWhvMWxtdGZFWi94VEVS?= =?utf-8?B?M3dEanFtOEt5SWxmNkxEWDF2RG4ydG9kb0EyR0pEMUxsVWE3Tm0xRUsycjlv?= =?utf-8?B?T3dhcGpnbWJQQXl3TFk3SFNCMEl1bHFTU0VrWGF5K1loRFJBQzBRY21kTW1Y?= =?utf-8?B?UjJaQjM5bjdvZFFzaFVNNmJrWmpkMExoWThUbXVlVFZtNGFIK2cxeFFKL09Y?= =?utf-8?B?SC9lZ0ZKcnE0aXJKTGVtRnBJZmFuSzRsV29pWlpFYlh6elF1bHprejlhYU9O?= =?utf-8?B?OS91NW5KR203a0VYQ3E1UVNLNXZ1YWFKOC9IV2tjeEZOSldIRjBYZ1J6V3VZ?= =?utf-8?B?QjBhQ2JEeUJuOGxaU0pGN1dBV0ljMGFxQ0M4aUREMzJPQ2JhWkszM2dCLzFM?= =?utf-8?B?NUxISHgyTGw5cjZzYWF0UnFmS0ZMOEN0R3p4cmlGQUJ2QnpmZXY3VG1sbzgv?= =?utf-8?B?RUFuZ0dQY1NQcUpFMlJFNFQrS3M1ckd5SkdxRkN0SmlRakV0dUlLa0crdU5T?= =?utf-8?B?M1M1cmJQYmlqZTZ0VkVGVmhNQ2ZjVEMxNDRPdTE1OWhEcW14TVN3YnA4NlRq?= =?utf-8?B?d3ZPL0szbUhlTzYzWGdaOFhmQUNscGVFQ3hVRFhGc21BMnRyNWxQNEJwTThS?= =?utf-8?B?d05VS0QySVR5eUsxcDdiS1gxc0xneTlQWGtvdXBtWmkwZUFBZkFoZ2hGZjhu?= =?utf-8?B?NmIvZ1d2VGh3aDFnRm1VT2UyWFZmRzg0WSsycTVqd2lQT3Q3M3pFM0VBb2lQ?= =?utf-8?B?WWRkVUZBSllGTnNvZUdpblBLRGZjMW5zaWFyWHluRFd0ZWlDK2xPOUJ3WTFX?= =?utf-8?B?NmhYcGtjUVhTUWVjdUlLczNCZWcvQUVhdVNkQ3JIdXA3amp5QjB4THhQY2V2?= =?utf-8?B?SjR4TlBlRUJxcFF2K2E0dDdtdHpOVDFBclFrdnhMR2FIcWRaYW0vdWwxOHg0?= =?utf-8?B?K3htY0J1dzlSN3pxODU4aGRRMWVIWi96bTRYMnlvaEcyYzFNNFB6ZkkzWXM0?= =?utf-8?B?emFnNGROelk4dGgxU0k4NDJlcUIzeXdQRU55bmFvNDltTFlOVVY0NXZtQVdr?= =?utf-8?B?T2JkRU85NEdJWnNVME9NLy9LY05DQzlLTVVOeDltemZ2UHlWRllCcW1oeFJ2?= =?utf-8?B?ZHJDM0tjZ3M5OHJ2NlJhZ2pEZlJyMlM0U3pIeXNUWGphV1hHWDJ1VENnSFRn?= =?utf-8?B?MEhmQUZGNktuSExnRjRpT1laYjI4UzQraFZZN0F2M0s4enlMeFY0TEJPUytH?= =?utf-8?B?dlZsNHVteXFIcVBVVkJOT1FnS0ZoWnFaLzFrNjBBWDRVSjNRL2E3QzhHeEFH?= =?utf-8?B?MnBKclkxK2FHdDVKbkNYdVh5bGRXeHE1TkEwenpGZmE1eFVOTWZ5RVFxZng0?= =?utf-8?B?S2dpbENlTXhUTDVTNUtpTjkrdWJYWUZvMWY0RWd4dFZETHhEOUdpbHpWaU42?= =?utf-8?B?TlhzcXRXVE0vaWFPZ1d1SWpjUy9xYVV3OFo5Q1ZOOFFiMVkyeTNZMFp4bCtB?= =?utf-8?B?VDVVVzYyWVd2WHQxV0hYakFtQktXa0pwVXQ1aXRZK01aNFVueGFSeVNiek5G?= =?utf-8?B?WFlJSDMvUWlXY0JLbXhlNDVtRkVWYXhNbEllRjljc01jamNSaXNNVllkZ0Yz?= =?utf-8?B?d2Z3Ynprd3lSV2g5bWJoNFJyeUwzN3hLTS9lNVVBai84UHdqM0F4VkdiSElw?= =?utf-8?Q?uQKIJ/Cud3A=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR12MB1141; 6:iFokml2ReNmsyd8+L6cyaafM97eU302+iHYolUwZvRVMm6vqAn7++YNwhyg5er8FimYahnNz3N7AXGUGT/TWOF95qHTWsZzfC3uDNw2ZCxT5TQdOqXOrlBbl+Ole7NAgNQ3uCOVeJac+eHdC0XxY1vNuDJLdGIBuwzJswCEqsjbujqAAtggfC4T+PcXG5rJ3N7UKOnFXoQ0JaMeP0+vR5XB8CxSRJS1V2Z7dOip9+rMk4o9dcVkWFtfKP60sCP9LPCZrAtkzm6p6DNS5mSUWFONZhLZZQ2davIPtUH+mbdc8rNtvHWxhxPJTz8dkPoYBzJKUknY4amsCifYKbCg7a2PyuP4MriWuTlb5VCON+KpiyryBhZl6pszF/SNDH2UcAE16zzLzyDoaIVQZaT2oS/B2mSyz2vZ5F7IxfccuFR0=; 5:56uCpoIxtYS8Ntg5h+EbOOA+p5HxC8D8OxVYu8y3KjOolbATfP1ngGNKyXoDJmBfjRXHkTQul2u58b368OHPLZCrb5XBs0HkEpXqJgLCrgqKGvnpdD1j/w1BgfF+DrnfQLPTKDssZnLQEPlDQY/5tA==; 24:mFGKeds4Duu9g1Ls86BM5kJA1lK/hGBA16wkg4UFCmBDAaNZTEqubn/To6lYum/GZ+ktmvUMbIm1zB0tEaBTeGoUcT//O9AVzN8JRH8iYSM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR12MB1141; 7:ixHXEQRACwVJ+tiaxSeY/gWG79P3fxPclW0hNmAm2rhQLoB62HK75tojlK/1sIWHsGlos3CeKdXk+tlWNuCsOpexes/b2SyfJP0ScUwoXAWCuQ8hLQR+lHnYnHIyrVe0H2MlbGvC9reOULp84ouH0XVHrNUI9vgcEdC9wRsxRFZGjDszFKuDxyOzrEeA0rTKfum0Kz548lpP/z4IzOtAS3HiUCINABGV9kKyPjxHj7nPO7VFDPtUEQIR6xFCQCByAlPPdEzJ2dY/IFRgcjt8k8yaVMITJqc1gkNl0ctYcDnYchKmO0i/c5Sh5WpSDZ9GjNm6Q+wczyy7lyM+U05PJQ==; 20:s/NEdi2aJE0CwJp+hmkfpgnCuN7bMqvk5YdxaLDV5SjgL1obnlkezNUaYjPHmX9R3+UGUVa+P5pcKB5obG1AjeEJ007VRwGB5niyrxCysM8FzAR3mLUw8yVhxiXINgcHYXEm3KNeoJUuguZLJ7OWkdxQIUaInP5bnhzYnWTFb9evxPmqTK/Wa3HGhtLxZrGBBwGkVCs8FyGcm0VHINaHaUqTbywFP7ORAE8t1ztcSDMjnAVmf+MPqCjpDPKN6HX5 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2017 21:02:55.6321 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1141 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Some configurations require the use of the hardware's MDIO support to communicate with external PHYs. The MDIO commands indicate completion through the device interrupt. When bringing down the device the interrupts were released before stopping the external PHY, resulting in MDIO command timeouts. Move the stopping of the PHY to before the releasing of the interrupts. Signed-off-by: Tom Lendacky --- drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c index 3aa457c..248f60d 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c @@ -1131,12 +1131,12 @@ static void xgbe_stop(struct xgbe_prv_data *pdata) hw_if->disable_tx(pdata); hw_if->disable_rx(pdata); + phy_if->phy_stop(pdata); + xgbe_free_irqs(pdata); xgbe_napi_disable(pdata, 1); - phy_if->phy_stop(pdata); - hw_if->exit(pdata); channel = pdata->channel;