From patchwork Tue Feb 14 18:23:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 727945 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vN9mg0Qk5z9s7D for ; Wed, 15 Feb 2017 05:24:19 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="NkYaBDJs"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751799AbdBNSYR (ORCPT ); Tue, 14 Feb 2017 13:24:17 -0500 Received: from mail-oi0-f65.google.com ([209.85.218.65]:32997 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751530AbdBNSXk (ORCPT ); Tue, 14 Feb 2017 13:23:40 -0500 Received: by mail-oi0-f65.google.com with SMTP id j15so1800576oih.0; Tue, 14 Feb 2017 10:23:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=nY73muNJJva+HFAtAzfA97reo9xOeKng0vNSkbgc+oo=; b=NkYaBDJsIFNW0c389E0io8a0mw5ZzkoVcdNmO8vxaUiKD2GS7cCVUpzA3AvvCRYw5C 5N0pU/Me3zQQNpXyTS4iPkNqQhxoJLcDX8ZU/693VGuRQINJCFaxbdHusbxJ4zIzpS53 0HKb1AxHWGdNlBweE7fIyGWfW6sORh9zn38Ev96ZxM2PXKBbAevePBW9SoVot9SinkZy hxhIFB5bPn7aVtahccSkO26ZXq8PqLTxC1hKfZxvA6fILXv9rLnUJPCSYzFXBrJFuZtt Ccw1onUrlJgcU4AjzliaJAMneyx201wX7UDyZBHg3e7YKzG8I3vZTiq5fRoCCL7bA4St 1sWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nY73muNJJva+HFAtAzfA97reo9xOeKng0vNSkbgc+oo=; b=ZWGqbwUeVARNKrsbFg51lz6IzNqmVWs8+orRzVTghS6VWGk63L3PFs78LYmBr/4OZM NWy04F5PNVPSvTgO1nqnNutkktdgyO/JAOT5n0pQcEDNOnsmbwnUiRn23Qg/vlhJ6OaG 2jcaf1rh24P9dMozaCadbQXVn6oE9pcJl95L7VxwS3gMwojKcVO6dZ2VbHthKKijmb2V Jl7pEQfNo4AwkPx8z5Z/TLkyCvMmqC4TnHJFOuoBknfLWcnLJALtETsy/AXYZ77ESOTb deqywdkYv8ZqFIASIMKuHbucZSYRnXEufTQjMvZBVJHiEBu3isTiD1FSW69etgAWBvmT f2gw== X-Gm-Message-State: AMke39lqaxH1tiUejZ7Nda27mhXHj4hSogtV3JOSNHd53TPXZ/nYKGfFAI/RU0If/pPzCw== X-Received: by 10.84.218.78 with SMTP id f14mr22842646plm.146.1487096618367; Tue, 14 Feb 2017 10:23:38 -0800 (PST) Received: from dtor-ws.mtv.corp.google.com ([172.22.152.34]) by smtp.gmail.com with ESMTPSA id a62sm2571399pgc.60.2017.02.14.10.23.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 14 Feb 2017 10:23:37 -0800 (PST) From: Dmitry Torokhov To: Richard Cochran Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/4] ptp: use kcalloc when allocating arrays Date: Tue, 14 Feb 2017 10:23:32 -0800 Message-Id: <20170214182334.23296-3-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.11.0.483.g087da7b7c-goog In-Reply-To: <20170214182334.23296-1-dmitry.torokhov@gmail.com> References: <20170214182334.23296-1-dmitry.torokhov@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org kcalloc is more semantically correct when allocating arrays of objects, and overflow-safe. Signed-off-by: Dmitry Torokhov --- drivers/ptp/ptp_sysfs.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/ptp/ptp_sysfs.c b/drivers/ptp/ptp_sysfs.c index 53d43954a974..27cd46ab5e32 100644 --- a/drivers/ptp/ptp_sysfs.c +++ b/drivers/ptp/ptp_sysfs.c @@ -269,13 +269,12 @@ static int ptp_populate_pins(struct ptp_clock *ptp) struct ptp_clock_info *info = ptp->info; int err = -ENOMEM, i, n_pins = info->n_pins; - ptp->pin_dev_attr = kzalloc(n_pins * sizeof(*ptp->pin_dev_attr), + ptp->pin_dev_attr = kcalloc(n_pins, sizeof(*ptp->pin_dev_attr), GFP_KERNEL); if (!ptp->pin_dev_attr) goto no_dev_attr; - ptp->pin_attr = kzalloc((1 + n_pins) * sizeof(struct attribute *), - GFP_KERNEL); + ptp->pin_attr = kcalloc(1 + n_pins, sizeof(*ptp->pin_attr), GFP_KERNEL); if (!ptp->pin_attr) goto no_pin_attr;