From patchwork Mon Jan 30 14:06:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Vincent_Stehl=C3=A9?= X-Patchwork-Id: 721547 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vBsrr0hMZz9s3T for ; Tue, 31 Jan 2017 01:55:40 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=laposte.net header.i=@laposte.net header.b="D31CaxU4"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932122AbdA3Ozh (ORCPT ); Mon, 30 Jan 2017 09:55:37 -0500 Received: from smtpoutz27.laposte.net ([194.117.213.102]:49641 "EHLO smtp.laposte.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753624AbdA3Ozf (ORCPT ); Mon, 30 Jan 2017 09:55:35 -0500 X-Greylist: delayed 1509 seconds by postgrey-1.27 at vger.kernel.org; Mon, 30 Jan 2017 09:55:34 EST Received: from smtp.laposte.net (localhost [127.0.0.1]) by lpn-prd-vrout015 (Postfix) with ESMTP id A47281CD4E4 for ; Mon, 30 Jan 2017 15:06:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=laposte.net; s=mail0; t=1485785212; bh=5xIXKSAVdEOWOuD017sCwknjrfKhq5wVeL1fypDo8WY=; h=From:To:Cc:Subject:Date; b=D31CaxU4Bq9QJUIjmMO2O0ehypFBYBenacqHc6UV4qmaCV52TuIkHO7qjzBpkqmRz T6D7juqgx9TeO9MmNfqdhYNE4gd4prBH1ZJBfiWjZiNgUF1GmmMBBarbvEIqlLrWJe ShXNHTJqgtfqxN/egX1qRvnf61fIGfb+XShAqUrsMjr+sXD1dX6wEjcZbooNwCujCN x9a+usTcxN/yelnKzTY9OjEuzAMd9wHZ5vCRjBeCBhS2A+2gxFkTF4J8AeIru9SUNz GccutX9JBRTLNdnXAHXvTCppINdjJeV/WGzbYkzHGuBOLZXF8z+epjMrvdlxaushKG PrFc+fS05HEQA== Received: from smtp.laposte.net (localhost [127.0.0.1]) by lpn-prd-vrout015 (Postfix) with ESMTP id 948FE1CD4E5 for ; Mon, 30 Jan 2017 15:06:52 +0100 (CET) Received: from lpn-prd-vrin004 (lpn-prd-vrin004.laposte [10.128.63.5]) by lpn-prd-vrout015 (Postfix) with ESMTP id 8F8BA1CD4E4 for ; Mon, 30 Jan 2017 15:06:52 +0100 (CET) Received: from lpn-prd-vrin004 (localhost [127.0.0.1]) by lpn-prd-vrin004 (Postfix) with ESMTP id 78FC171039A for ; Mon, 30 Jan 2017 15:06:52 +0100 (CET) Received: from romuald.bergerie (rqp06-1-88-178-86-202.fbx.proxad.net [88.178.86.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lpn-prd-vrin004 (Postfix) with ESMTPSA id 2828C710395; Mon, 30 Jan 2017 15:06:51 +0100 (CET) Received: from radicelle.bergerie (radicelle.bergerie [192.168.124.12]) by romuald.bergerie (Postfix) with ESMTPS id 67F9119E5D55; Mon, 30 Jan 2017 15:06:51 +0100 (CET) Received: from vincent by radicelle.bergerie with local (Exim 4.88) (envelope-from ) id 1cYCbb-0006Ip-B4; Mon, 30 Jan 2017 15:06:51 +0100 From: =?UTF-8?q?Vincent=20Stehl=C3=A9?= To: linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, =?UTF-8?q?Vincent=20Stehl=C3=A9?= , Sunil Goutham Subject: [PATCH] net: thunderx: avoid dereferencing xcv when NULL Date: Mon, 30 Jan 2017 15:06:43 +0100 Message-Id: <20170130140643.24182-1-vincent.stehle@laposte.net> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 X-VR-SrcIP: 88.178.86.202 X-VR-FullState: 0 X-VR-Score: -100 X-VR-Cause-1: gggruggvucftvghtrhhoucdtuddrfeelgedrieefgdeifecutefuodetggdotefrodftvfcurfhrohhf X-VR-Cause-2: ihhlvgemucfntefrqffuvffgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhs X-VR-Cause-3: ucdlqddutddtmdenucfjughrpefhvffufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeggihhn X-VR-Cause-4: tggvnhhtucfuthgvhhhlrocuoehvihhntggvnhhtrdhsthgvhhhlvgeslhgrphhoshhtvgdrnhgvtheq X-VR-Cause-5: necukfhppeekkedrudejkedrkeeirddvtddvnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhh X-VR-Cause-6: vghloheprhhomhhurghlugdrsggvrhhgvghrihgvpdhinhgvthepkeekrddujeekrdekiedrvddtvddp X-VR-Cause-7: mhgrihhlfhhrohhmpehvihhntggvnhhtrdhsthgvhhhlvgeslhgrphhoshhtvgdrnhgvthdprhgtphht X-VR-Cause-8: thhopehnvghtuggvvhesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-VR-AvState: No X-VR-State: 0 X-VR-State: 0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This fixes the following smatch and coccinelle warnings: drivers/net/ethernet/cavium/thunder/thunder_xcv.c:119 xcv_setup_link() error: we previously assumed 'xcv' could be null (see line 118) [smatch] drivers/net/ethernet/cavium/thunder/thunder_xcv.c:119:16-20: ERROR: xcv is NULL but dereferenced. [coccinelle] Fixes: 6465859aba1e66a5 ("net: thunderx: Add RGMII interface type support") Signed-off-by: Vincent Stehlé Cc: Sunil Goutham --- drivers/net/ethernet/cavium/thunder/thunder_xcv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cavium/thunder/thunder_xcv.c b/drivers/net/ethernet/cavium/thunder/thunder_xcv.c index 67befedef709..578c7f8f11bf 100644 --- a/drivers/net/ethernet/cavium/thunder/thunder_xcv.c +++ b/drivers/net/ethernet/cavium/thunder/thunder_xcv.c @@ -116,8 +116,7 @@ void xcv_setup_link(bool link_up, int link_speed) int speed = 2; if (!xcv) { - dev_err(&xcv->pdev->dev, - "XCV init not done, probe may have failed\n"); + pr_err("XCV init not done, probe may have failed\n"); return; }