From patchwork Fri Jan 20 18:14:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Lendacky X-Patchwork-Id: 717858 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3v4pkw5dymz9t1F for ; Sat, 21 Jan 2017 05:14:32 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="2OfL6IoH"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753103AbdATSOY (ORCPT ); Fri, 20 Jan 2017 13:14:24 -0500 Received: from mail-by2nam03on0087.outbound.protection.outlook.com ([104.47.42.87]:2657 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752592AbdATSOV (ORCPT ); Fri, 20 Jan 2017 13:14:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=FJqUtODUPlG/t9Y4gqFsAbxLehrT4Nm7/bgW6Yr7Q2I=; b=2OfL6IoH/resSbo2BQitIwWmbWsCgw3UZ6phuXEcJVGCNw9+nFBGT9FDsicD27vuRfGSEQwGuAr8GrbNFBOyXFA5gJPcJMUlpxwAH/mFY0zTQlrCw707vBJX2foBJFpznhF+MgHXtyNA5B5MzWwAyIIE1yeRQfRoCG5wU/QluAc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Received: from tlendack-t1.amdoffice.net (165.204.78.1) by BN6PR12MB1140.namprd12.prod.outlook.com (10.168.226.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.860.13; Fri, 20 Jan 2017 18:14:18 +0000 From: Tom Lendacky Subject: [PATCH net v1 2/2] amd-xgbe: Check xgbe_init() return code To: CC: David Miller Date: Fri, 20 Jan 2017 12:14:13 -0600 Message-ID: <20170120181413.2321.52046.stgit@tlendack-t1.amdoffice.net> In-Reply-To: <20170120181352.2321.63733.stgit@tlendack-t1.amdoffice.net> References: <20170120181352.2321.63733.stgit@tlendack-t1.amdoffice.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: MWHPR22CA0062.namprd22.prod.outlook.com (10.171.142.24) To BN6PR12MB1140.namprd12.prod.outlook.com (10.168.226.142) X-MS-Office365-Filtering-Correlation-Id: 2652dfb4-00fd-4c63-bf42-08d4416026ec X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BN6PR12MB1140; X-Microsoft-Exchange-Diagnostics: 1; BN6PR12MB1140; 3:j6eOSuBU89ly4pyrMghaSlOH0jnCicGG5L1YsehTLOkoizWX77vyRFANTpYLYfmr/g5aA4NA23J3HHZeXYoulx9P2DV05mIPMNoE+r0SFJQopYosZpZlSFqkBCaupiO4px51bGEY+P++7ihQ27W6axPIklQeZec57Q/XsD2GwammEkoWhYgnSUSAzh+8U+oGDHN7Zc6kL6sZUeri7fkT1kc9K4tVPNn2W73rNDcth7pgZNo/9u9zhMu1zQSFM0ADKbHIthaRahvIY5ALI8q4Qw==; 25:5AV1X0MR/s+dKtnkhBEH3VyFIWTFzEVlmO6WIhybkMaGbXg4LUJ6AA2aA1aFyVE2ch2wcTPU95V5ctL+EhojXte1F3ZiU7i1QyDQRLMhJHfmOXRM+fft8+mjHaIbOQhWx4SKTlU0W7ecFyBzhLYXLprZyoV5E6rUfktMXC4vmNxRQ02Be0A2cd1GMWXRPytxJoPVtJ8zms4MvVl9PZeVE5F/QKv+An7px7BqLF7eyvfA+MB8Bd1d1MzP3ciStzoQ5YqkoIGFYjV1orTl4s5eoKFHSi2zmT9Eb6BIfRhHMCWEejOADKaCdA5gWSE2vVDVaYV/PNpabFUxuvWhW+pC1YIHqsAHGmWDjJWhX67U5+RQWGseclRdVTj7Rq09ILImUhgoBULgbrDDgC63e52L+NW3Dw57E0TjR7pwxSFDeTTSXn5dPWKTxmesPGcFOoSsKgq24tdZw1P665Dx/M3r+w== X-Microsoft-Exchange-Diagnostics: 1; BN6PR12MB1140; 31:LPE55EDb4FGRgBfDEK3TrcBcomUjovC1PpXq395XxAJYMmvLnBqWj6rcGcr3Kngn2GbJ1QoHXIY5N40IWtP6hyrVqh8gBKh7ggEIGIxxfrAoIgKL3C5nqSPivU7RLWDTyvuNqXfacf9ts9jh1tHFfygJ0mlvJuM36YyzjYBIpEskltgIQqx7b1OoKl9hEP2kxaE/pFHwQWOOfYNSq8h13qqfjKRFsM84w0PiBnXaNzzdSKPotLA+M4W7z9AJxfZK; 20:foFtqPRyb66yMwsDBDyuUhtVAzx2q/yokmXDUw8u5H1WX1SFCfhqmfjCPtucM8o6obkiG5J9CqVhT+rRJJhNCAVstIqgTzYC9MKJt0ZzGRb1s2xXXZC64hy0NNvg6pzqiBNaiDIKqVolqQo3PH1xYd73VXgB4p+8njv6tuoqZTSS7vACj0TLOWpXuaNnRGYfki4tViu+VvNVJzTi/O4118jriB3cKwvfxm5Qih9vt0ygfM5LuJn4oxrdGbl7y1ntzFXwX/ZVhINLjsfDeKlraWYaKQ89rxChYJvOW5U25UgMS1An3pZT9WSa3il4gyunwqAL2xvAxfnZfWGXvVA+HcACmYkNAcFQ/5Js40xriSHWE7kxliZm0LYwugUqcq1zYyAlyDDh6G7EA7X3mEOh27Vd/xrYG9mYXqmsAu+K1fzy2d+0LJOAbEiZ0ZXfxBDsw1dKUNc1lnvDGIoPRdQnyImxGN6rWm9ln/m5PCBqTXpSjc7D2aHn3Ixz925fdkGI X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123555025)(20161123564025)(20161123562025)(20161123560025)(6072148); SRVR:BN6PR12MB1140; BCL:0; PCL:0; RULEID:; SRVR:BN6PR12MB1140; X-Microsoft-Exchange-Diagnostics: 1; BN6PR12MB1140; 4:obZRA+K/B9CD4EHOE5D+Q4AFnOBp80Qe1vZ0Ra5C9W7cx6vlN51LjZRZ8aP7+u6M8qEXgs6R9c5kOUVxOCMBdzEr9OW1ehauJv4GjYkBo9CXc4zBVrq8uFGBUaTuHJSpjzqGDkmkIZaX45+zTvz1puXCQIPccIzEFQoff6RZA99qhw35Eirvz12Jzm/vjib7WWB9cpfiMrr6aRMWln8R9hIXvavrsyNqpZ1YYVxdqmPdheXpqwzYCjuxjtcFEBZsgI2epzCGpjabZ7HBxUjtAng/Ofblz8tHc6Qxs3O04+J/sUjjPpic1NHVyedUJwA1bxD7y4uMYf4r4O2rS8oV4+mVriaGIdJigiEUikdFZ+5YKao7zncQgy/vJ8RsYWEMX3/NEtJgvzB5/GUw3P8lPvsszP4UfwXwoVPMkVPJCnYV7gNYSp7UzE6zLMuXQdpy6zZCILydtqj3oLCePxHQ5CDPYrkpsE+LOscs7J+UKYKilSY6obb+5ww0APRrTNvLFtLHMRNB2BLoRp0z73uobyoJsP9qm4IWgCzPRqSwnNPThZRjwInuf/44OyffNnJgdtX5LZpsNyuWjFuAPDLCK5O4Zpq8CX2HDa6frbuX08s0Gbf8qw1JEWOGukpVmKqW X-Forefront-PRVS: 01930B2BA8 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(39410400002)(39840400002)(39450400003)(39860400002)(39850400002)(189002)(199003)(2351001)(68736007)(101416001)(8676002)(76176999)(42186005)(33646002)(54356999)(66066001)(103116003)(47776003)(50986999)(3846002)(81156014)(81166006)(1076002)(230700001)(92566002)(5660300001)(110136003)(6116002)(86362001)(25786008)(23676002)(6666003)(4001350100001)(2950100002)(305945005)(50466002)(97746001)(7736002)(6916009)(55016002)(9686003)(69596002)(83506001)(97736004)(53416004)(4326007)(105586002)(53936002)(189998001)(106356001)(6506006)(38730400001)(2906002)(71626007); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR12MB1140; H:tlendack-t1.amdoffice.net; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjEyTUIxMTQwOzIzOlpxYXY3RExSM0pwd3J1TzgyNDMzREhQMWFa?= =?utf-8?B?cXJHQndCeHNXbFIrVlN2ZVVsd0g3RFpvdzRpWlJUVEJJWFViTkRyTEpmVWR5?= =?utf-8?B?eVd6OXFTMkJLTVFWQnkycHVMOGFmQjZ0a3ovbVlWYlpUcHJnT01nRmI1bXBz?= =?utf-8?B?c3hTZXRmZUNVTDI2UitRUEgzS2tvcGJHVmR1eDROeU5JTitzWkNpak9hQi9J?= =?utf-8?B?Q0JmWjQyeFNlYVV6KzVSeUxmTEZWMUM4SWg4Z1pNMDNFZUNQNkw4WU5DbHNx?= =?utf-8?B?Y2IyMkJCYTRIdVRCRlJXYUFhQTJFeGVHRGk5KzBhR0V5dFNlSkNMZmFjemI2?= =?utf-8?B?b0w1dEVNbEpQNGI2cGxxOVhCbnlYTXpUMEthWlVsZTd4SVpNeEkrOWRteWhw?= =?utf-8?B?R0NpdEZXc1czVkJhblh6dTlDcWg4NUw1M2F1cktseE9LRkw0ZTVXQ0RIeXdD?= =?utf-8?B?d1hRTU95QTZwWTdPQS94WERwSXZGRGJZcUluSVhKN1ZiYk9WUTM4ajBqc3Vx?= =?utf-8?B?dEVnMGJsb1FEaUxvUHliaVgvQXZhL3Q2aStreXh6c2JDcFgrSFBEc2ZiRjZp?= =?utf-8?B?b3R6UEk1RjNkelY3N2RyWXJTRVE5bGt4d21IYmczM0FubWlmRm1oRGtoNG50?= =?utf-8?B?STFkN3hrODMybFl1NW5XRDFpUS84ai9DNGRWSFF1aCtZbnk4VjNLRHNZYXRh?= =?utf-8?B?WkNOWTJ1dnN3Z0NtM21jcEgyRHdLL2UySEtCRkkxZ1RJalB1Q0cyMlRkZGxF?= =?utf-8?B?YjQwbUptbXI2ZlBqOEJ6VnFqQm9mTm9PMkxtaURSUWZQVVpwQnd5SzgxUGtB?= =?utf-8?B?QUkyRDBEbS92d1lNcWFjenRHbGFjclRYdXp5a1l3MG1nbzRVdnFkM25ubDI1?= =?utf-8?B?N0NXMXV1Qkk5NTJ0cWwwVmhnaGFXeTFtQVBJa3NTNFBBMURBSmlEc2pKeWZQ?= =?utf-8?B?bG5BOHVSVE9GeGplWlNiMlpZK1U1R1JjN2RlVkZDeG1CQlJaVWcwLy9CV1Zh?= =?utf-8?B?Zy9vUm9sd0pzVFNGNWV4TERtZzhFSVF3TXU0a0RmRFd3VmRialRSaEplWm1a?= =?utf-8?B?M0FpS1lmKy85V2xnazFCTmROYk5VL0tkZ0JkNURTbnZGcGcvekV6R2NsQkM5?= =?utf-8?B?a0JaNFVPN1oxeC80Qng3dWg4YnJGQ0thU2J3NHJndGZId2FWaWY0WXhEN0VL?= =?utf-8?B?WVp3L04rWFluU1BIU1M2WXJSU2ZEcmFTYkVTZzI2SFUrd0tOc3RlTXFZenYw?= =?utf-8?B?K1cweFEzelc1NFF4azlxVk9FY3crWG54TW8zV1N2NjZaTXBuRjUzR3BEY0hO?= =?utf-8?B?bVlqNmdwZEcyMDdkV1pVbnQ1V1BBOFFaOTVjK2crT1lyL1hka3NVbnprWjQw?= =?utf-8?B?bDh5a2lSRHc1SmVHdEpyWkMwZndRZk1NTDJMbGV2cHBnbThKcjVqdzNHcTFy?= =?utf-8?B?V3ptREZkUFBRemxSMXAyTlNWb1I2SWkyYlVSZnNUTHVyNFhwUHlwd3JkSmdy?= =?utf-8?B?ZFpLeSt2SDgyTVArTG9XdC9HcjNIZjBCMllVam8zRVp4cEZIM1RzeXlRUHJQ?= =?utf-8?B?em9DM1BGTFJoU3JOTXEzZnJuYS9lYmw2ZEZJYS9nNm5mTUsvV203WFJ5YXBa?= =?utf-8?B?Nzh6aGptWXIvTjFCSTZiMVdYTTU2YVpvdHBSd0J4eUkwYWhKM2x4TTM0ZDRT?= =?utf-8?B?SVVHaVN4SFNUQmgvMjdkY2V0MGJoMWh6MlQyc0EzVjZkQlRCQW9zMTFHUm5J?= =?utf-8?B?QlNlWlIvTFpYbFpabUNWejhwSEFLT0ZRNVROaXRTVHZHRExiMUcvb1lVQlBn?= =?utf-8?B?THIxTzJubkVUY1NvVmdSV0ppWXhtOXo3RzBUSEZXY2tINklWcVduQlVkaUhT?= =?utf-8?Q?w6IFwgELaiQ=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR12MB1140; 6:ln9YsdS8puyZYwQq2dDKkD5jfqwwPae4yC8v9oNAV4vTe0yKEo+plfXgUCL9sCgVjL2vnmBi8celT8xywzwPWUM5uc12wPIGc80VzimEKR9nrCQBcK0hVJx1tEIoglGK4/Mms/a6ctnRTEgPURtW79NQfowltJlHh1yl23mdB8dN/GwBeaJ8OpAeX8iviZBlOpKCSrY4psvwZhDwMl2fcz4pZ/pnP6Te/sWEb22avgzecGkkPjeJTmDV5J8F8CqLCgr5XJEl/KvrLEw3LsmpZA0EuLb0zfSp+tm5CP6N7J9YX+Sq/XAls3zepsQ+NMsat9gw416Z/FuFKvY0iy584CliCMx71fZpRkPXa1nXfFK0YBzxNnH0NPNs0ZzV/O6vTpYrvN4tlXM23zbejLoD3V8pqRchfJ4lfE2WmJwkn5+qUrSUQmlwLxs7oW0/gDloW6PBigvlRaK7t4X9ohFnAQ==; 5:2n9hClO2NaQhJxh7hAY//CD9oaNF9dc96jTeKC+fsU9yWYUgNBOsMMclmwidw5KICwriJvGiRdzQ7iwuixundIhoJQ9Cz2fCWKBemO8GrFXTzGPuD6KetK/Go69Cjup4SdSAFpVqL031pm65JQ1m/w==; 24:j39kV1pjwFXeERLevo8xC2iv6TO4bZU6dp8s3pJIkmt3H/TGBSU2EsXte4IZcsJDjVOBxVDij3Hqm49PC4E4SLLKgavAkEaqAW9MUEQgbgg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR12MB1140; 7:nB4SAq3Q/gWFBuY6HAYM+Rt1V3iWDOb5+XPKJvybHwKnfxJtRgiQewLDgJIwO5dzdQCXxNaOmsupdY3v2iwsb440dviVc52ryGSmA68ZSxjC4qq09pw5+dwTMU1KLWg5kKEMc8UAPEYxyvTTdFHwCnyLEjGGPswe/2x/gYW0jo0+a9qvrDTpm32brzKFVZQN6bocPZ9im6LWOJoQxsLLXlCBJxGYq+EHifAYc1PrVs8sYPS7t2C9ymxvM5zmOdXmd4P/u7hERMG5Irn3h/ht1LfUkKOw6B1Xlibb2YqHnrd8Z7ZFC7aT8wOh5Tux3f80YKIrrbVcCSCAwtxK5eYI1iwo8M7vk+XX/hF/sZpGUZQ+owIl5D4jROykihF0wolvVIsJ8yS0VEpr0VTuy5RdE6z1OvuT7UtxTp7PC4emPexsvNPN5yb4vR/UVUrYGaCnx1oBssNlvxUM6vDDVpLCAQ==; 20:FK947ginjE+nsdH/Nc7UNPWwpEBtyNvOKfaoLsfBEgECnfHgRC1l8V0N222oR1p+BSvVa1ToKm7YNM6+EJulc+sg7toFmn1zYQAPQQLL1tTNft2xkVercEI5aMRNVFJzqfxGZTErLzw5vvYrRskWpff/Y6VxdlziiZ7Tv3kWIOjuW+UQMHSk+EP9uQ6T3nAS4XxQXZzM+5+TRKz8zN1XKvoY3PvmDx+5yXDHbOxWUollTJuFe8rtua1+cwX7G8pO X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2017 18:14:18.4642 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1140 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The xgbe_init() routine returns a return code indicating success or failure, but the return code is not checked. Add code to xgbe_init() to issue a message when failures are seen and add code to check the xgbe_init() return code. Signed-off-by: Tom Lendacky --- drivers/net/ethernet/amd/xgbe/xgbe-dev.c | 4 +++- drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c index c8e8a4a..a7d16db 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c @@ -3407,8 +3407,10 @@ static int xgbe_init(struct xgbe_prv_data *pdata) /* Flush Tx queues */ ret = xgbe_flush_tx_queues(pdata); - if (ret) + if (ret) { + netdev_err(pdata->netdev, "error flushing TX queues\n"); return ret; + } /* * Initialize DMA related features diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c index 9943629..1c87cc2 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c @@ -1070,7 +1070,9 @@ static int xgbe_start(struct xgbe_prv_data *pdata) DBGPR("-->xgbe_start\n"); - hw_if->init(pdata); + ret = hw_if->init(pdata); + if (ret) + return ret; xgbe_napi_enable(pdata, 1);