Message ID | 20170104210716.8401.99717.stgit@tlendack-t1.amdoffice.net |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show
Return-Path: <netdev-owner@vger.kernel.org> X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3tv3Mq1QM0z9svs for <patchwork-incoming@ozlabs.org>; Thu, 5 Jan 2017 08:09:11 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="rQe7nGP1"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967062AbdADVID (ORCPT <rfc822;patchwork-incoming@ozlabs.org>); Wed, 4 Jan 2017 16:08:03 -0500 Received: from mail-by2nam01on0083.outbound.protection.outlook.com ([104.47.34.83]:52145 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S937254AbdADVHm (ORCPT <rfc822;netdev@vger.kernel.org>); Wed, 4 Jan 2017 16:07:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8CkXHkcRmkxM7HNsI2H3atJijxPuQDIjhNbet6e1/rY=; b=rQe7nGP1lOJoncwADxb19a/IwpJtwZsb2kNRWJkZ3b4BNRxKhbMAQOgmtJE/9uh0Daj6XVlGnrP+WL8KG2uspEPAepjN1iGDhBHEdSKK7NqFE3R5cT6LQFNmvc8AzTgJzKFQb0TWFCwv0hY0wQ5WLuF0ZswexTtuM1SjSeBjV1U= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Received: from tlendack-t1.amdoffice.net (165.204.77.1) by DM5PR12MB1148.namprd12.prod.outlook.com (10.168.236.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.817.10; Wed, 4 Jan 2017 21:07:19 +0000 From: Tom Lendacky <thomas.lendacky@amd.com> Subject: [PATCH net] amd-xgbe: Fix IRQ processing when running in single IRQ mode To: <netdev@vger.kernel.org> CC: David Miller <davem@davemloft.net> Date: Wed, 4 Jan 2017 15:07:16 -0600 Message-ID: <20170104210716.8401.99717.stgit@tlendack-t1.amdoffice.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: CY4PR2201CA0006.namprd22.prod.outlook.com (10.171.208.144) To DM5PR12MB1148.namprd12.prod.outlook.com (10.168.236.143) X-MS-Office365-Filtering-Correlation-Id: bb217794-ff39-4101-e450-08d434e5ab9b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:DM5PR12MB1148; X-Microsoft-Exchange-Diagnostics: 1; DM5PR12MB1148; 3:jfC67DV5927XN2QFJKKB8pV1mDkh7EQXKHJKbydrJWgpHo7ACI7YcNnM2BPFfq/DiwRXWwBtNUrnqBf+H1UxUQGbpiyx++kxGzfQOQet3feqtS7dUHEE196HjOFi+GyjECskAWI11ufIIsVoHejpyJPUyVMKKk8Q+qAkwzg6nC6bxSDz9p8qOuMP+siUsf83CjYIrDg2w3xPvDfueP/PHFU3Ln27aLNc/boXoBimlr2QTHxFiyDyLA2GHwaCPe5tbO5omxj/BtRJrs4f3PP8Aw==; 25:GUDNlRafX1WRXBgMhwZP1vEyxG6FmxCXghr8/c5DB2AeKXBL1XZbmZel0Wmm3ELfQxXaOrhJSyxQai/roMx6rtj72hKRH/I1trA6m3FRYmq0qomxL4+AazuXyA7cDqWnMuVUeIRMrW1C4NHzbL3UdSIpVmctcPso9XHrDFTwXo3Mon4zw1h4SL4bsLp3aM4wRKLSdGQdPsngwi+5UIJcLueKhELypvguuOzZ+Qoge/qO43wGuVBCy4vf/hB6hVkWMoctx3ohVJKOD7m/0MnHkR5Svkq9BgGprvZOHR8DtVnxjxqYc7q39RBeIK+gVz1MTKT/DYChz6ubkzRKtA4C2nzYtPNU4zr4txVJy4ZrTWxMYE1++McB/6lgGMg2RY4xUtquUTW5wxGqIoyQHQIpnV/gUKUCPAyoiErQLEJfUN4JdRvhL2t/Xl83VGvGnxoQTlS0c6rjJ3dLEe6Lku8YZg== X-Microsoft-Exchange-Diagnostics: 1; DM5PR12MB1148; 31:wCwl/4WsHhlhvWl8kEJiT3p78Q7f+9UDu44aS4YMiycxoeo7dfnduLt0TlWRLzfEQB/9eZVn39VmnKQmf+X83HHtt52lTgPmWYf92M6A7xLMWHEjBC8XCSjPeHKmGFPmbdvlZgY/VOMflnp0t9/XS/4GW1tRLp9fsZWuLAyOYrsuefOPClda5ZX5q8jUdL1MDcPY3zpKc/939X93mEpPbI6JFhYPucDlDp4Ygawh2aCfrT6gN50fIzB2j6xs0LOhWEAcFrQuiMab7trWx4otJg==; 20:YiMuARd/ygMgcX5LYPTjygrg9lJwoybDtQJovHU2NX/lmYcAkwKEnZDFR49iswYNZ6OEcyfRzJ5osnSGmEAyCNLxBMD2sG7xm93Og6R1vQgeL/MVDl7etCf8rLhd32RG2VwpMP8t/hTt3qlZgJsdSw3m6+3JFdrCHzeW057JmUQqjeUJK7r6tW9Aqw95ihlsCp7weYWtnFiL9HqngCO2UGcl7zYWjzK3guJq+QfXvh+oPgfwTXdaH9/6im/3pYuqGfPy0cPGvjAUOOXrm/gWv2Bq/4vQEuzn8j/OXkbUa1GfrlJcEFg1Rr/O1mUSDx9zBd4fXsUSzBjNU82HaQQ9sWKQbzF/yIphxp3NOyFvXU7uT1zmudhE4GGvjmOZbhCma8BwmggECn6JiGydcfv96Cv6Rx11n0ug1at52X4XsuDdLauhwtbGbx9Gkq1nbC/ysDKD/bKX8xj/U0ulsvj6t1n0NSID3WyhSh1wHHFyvXpGQMsJM8eY3K1YxpVvJ0ed X-Microsoft-Antispam-PRVS: <DM5PR12MB114806CB54E169CD16CF7997EC610@DM5PR12MB1148.namprd12.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123558021)(20161123562025)(6072148); SRVR:DM5PR12MB1148; BCL:0; PCL:0; RULEID:; SRVR:DM5PR12MB1148; X-Microsoft-Exchange-Diagnostics: 1; DM5PR12MB1148; 4:NyhiCgr1oDMRppVxpcuz0Yd6XviMar0u0zkFeepik0syzvd+Qe4Q+nSrxJBv8rB0sL/d5T9CZem/tCdpxsHLIKxRU8eu02y8b6kID9kbK9BGEYVZdnvuco7YvJXXPtOhCjNInY+E2mv/smV+dSyI60FNinCcKN75fjwsvs3r4rDJKRZGuwK5TMBEA2RksG9TlNjzU5l2S/GFGC0amYEUfuTugz99sMuOrCdLbJS8bhfpnlKEMM9syBOj0YrpTOhqNIl6gztaVQ0gJlr2F24n8hvGWMZ1t73TF5m4SzryxFkLYJ05NBjucyjTIHGUnfOM8RrYJoTtYIeZ4vbHfryKZmmkRKXHVgyW6jFOR9p+yHAoJxKGgH5/eyt/kqT33g8iXZ0527grexEV8nuSA5tkW1kSf6KGi2uHXZhaL/MbCXT4C6/j/+0M5kqL1l51u+xGe+dkM7ezIJimsEOPm+Wkfb4F622FvISIFIX+9ZXylaXRRq4bj9EKkOsh/XDYZIsmvwnUW7zxwDdEM1TssLjzhX2SIdJR+7aKHl25uAxTDQd5haBiUcZ6HcxR5POgwBJsx763iSGPscN85QzfBoTHSjO6J14hBrLU8pdhbxSnpW1s87M0vw3+LXd5EtYftOup4iFUVdm+zTBlL4C2pLCKgH6UKKJBlGMvpqUQmPYGH1s= X-Forefront-PRVS: 0177904E6B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(39840400002)(39860400002)(39850400002)(39410400002)(39450400003)(189002)(199003)(83506001)(23676002)(2351001)(106356001)(69596002)(189998001)(230700001)(42186005)(53416004)(2906002)(105586002)(305945005)(103116003)(38730400001)(25786008)(55016002)(1076002)(7736002)(3846002)(6506006)(86362001)(8676002)(5660300001)(97736004)(4001350100001)(33646002)(110136003)(101416001)(81166006)(6916009)(47776003)(9686002)(6116002)(6666003)(97746001)(66066001)(92566002)(54356999)(68736007)(50986999)(81156014)(4326007)(50466002)(71626007); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR12MB1148; H:tlendack-t1.amdoffice.net; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjEyTUIxMTQ4OzIzOmVtYUhjVWRsVEptT0ZpUml3c1Q0ejRCMThn?= =?utf-8?B?K01NYkd0NUR3VGVkTmlJQWtENi9KY0xBK0lvY1FINnM4Um4xcE02bVRnMWF3?= =?utf-8?B?T3A4VWZGMmhzclJtNndQaytBcUF2WnNWMlpkeVJyYWs5cGxyWmpCTGZDa0FN?= =?utf-8?B?eG83dlNERDc0bTBHNnRNdExrNzdFYzNBZFFLQVo4UEhRVWQxY2FwL2ZNUEhn?= =?utf-8?B?MDEzWnN3WkJIZzhwS2lPNDJ4bndoWW9yb2IwdUlJT0pGOUJzRHdOVU81NnRL?= =?utf-8?B?R3NBbWZiVXFZWktxbGlmZ1FLTUZCMU40dGtSeEhmWlVzei92dTUrZGx5U0ZM?= =?utf-8?B?SmhWWnlkUmZmSmgzT1h1ZHBwdEhoS1RRWUwzQkpQbjBWei9mNVREYkhXZmtO?= =?utf-8?B?RzRFWU91ZldDSmtDTHJNNlpGbllBNEllanprbC9jL0FYeU0wK2xXNjZndjUv?= =?utf-8?B?WXRWeFBWbXRsMFJFVm5vN0lZR2pwOGx2azRIYlAreElpVTRJOEQyTEM5eE8x?= =?utf-8?B?YXQzclRBTFIvRFNpNnpFNXphZS90MUNFMEZjeGI0aldGM0t1SzdkTzV2S3A4?= =?utf-8?B?UlNPcVltbmNFUjVMUTBmQUpMcnIxRkZMVEtlUHVhaFZORGEzaHMrSVoxRFVP?= =?utf-8?B?MDFUQTFMS2N5MlV1K0o4bVMrdnJFVG9aZHF6bjdyQW5DcVcvQXJIRDBCVDJj?= =?utf-8?B?aXQxaFo2R2RWNmpSZUoxZ0VSdytHVzRuYzkrOHpuS1Fxak9NMDJWSFpsMEJY?= =?utf-8?B?M2ZqM3B5MUlFNERaVm9pVmFtMk8rTEkxaEl6RFlFaE52VDNKV0IwUWZEbm1O?= =?utf-8?B?eksvQnVIUVRLcXpmNHRJN3NyTlk0YmdySW5uMkFRNlJqblcwNGhra3JkZ1Fi?= =?utf-8?B?dVFIVnhwZUEwaXZQRDJDYjZra2tkQTRzVFRudE9BNHhQK2hyMi9ka25rRVFW?= =?utf-8?B?eThzSkZkcS9jU0pEeEdaSlcwUnlNbHFUV25Rb2IxZTdzL1VzZkFIN2ZueGh6?= =?utf-8?B?MmlUUDB5eWxmQU15T3M2ZjR1NHdMZjdjMkVXU0l0RkJYV2V6WDBFaXRPcFN3?= =?utf-8?B?RzFCSFhoVDhPQldycWEvL3dPRW5YNUhSaTh0RDAvTW9ZZS8xWlg1ZGg4YzBY?= =?utf-8?B?TEVpdFo4UUl6SE5xa3gzdjBydEhRWmQvQ1dUWVFwM09CK3NQYlFlVll2bno0?= =?utf-8?B?ZnJGL3F6cWtSbnI5U1lpbjFlZHI3N3VPMkZUV0dBYmh5cmRnNXduVmUzcVM2?= =?utf-8?B?OEJ2YWlsSy9HWkJwaHlJcndVZk5FNTZxUjdiZ1AwOFBoKzBXaUlPY041RFpK?= =?utf-8?B?cUdyN3RKbEF3dkdjclFGbGFBMFkyR2dsbnBBKzVhWitXM3pEL0l5Y1NPMlN5?= =?utf-8?B?V245UE1sREVQMS85TkJBZ2dnbkxhR2pHekNRQnEyN0xpYzVWMkFESlhNYjVJ?= =?utf-8?B?VUhoUENSdDgzOHh6MjZ3NVpQV2dCb2VIajAzK1BhZkRtRWFxNjhJQXJkNmZF?= =?utf-8?B?SW5jaG9sOExzWUROZmJmQXJsQng2TlhTMXJnTi8zdXI3ZGp6Vk5HMWJIT1Zt?= =?utf-8?B?WGc1Rm5WYkNmSTludEI3ZXYwU3hzVmNuZDRnRUduWlFpUTdWQStmeU9XM1Np?= =?utf-8?B?aEhFSEJJbGFmR2N5aUVaMkp0b0tSREYxTzR0dU41d2EzYzNPUW9OWG9aUXRp?= =?utf-8?B?TFhPbmJlTXJvK21zMnJ6aFpjR1NmZjN1RERKblhnK2kwRU8yeDFGZWVmZ1NC?= =?utf-8?Q?bNXgkmFxl7ofyf39uTvvKE647FBQL7Iq4wc5E=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR12MB1148; 6:Bp3gdjYNIlqmSJYpxFhYA/AgjzDZ6RMthtZEbx7Gjr1q1e+fgd8E3g4QWKzH482OOel2sk3Q795Vk9ewNqgelBTvW0Ph+p9YWEmOxumzALELV48opa2hY4iMoUPT9rni0CH5PZqPTnK0Tql162mwjvg86Rg836M8h1tcb/Pz2nZkUGgtnSvcr87sAUUgOSmQifHQ+ENMgxsauZkDx/srVv7wzaf3SSBhoe2a4kWsmlMddaoflPJpA4MXVidxdL1w0tMfo2kfYENbxI0KguAKhYTt4bCbAqYXUIbrthGOqfjyHVgUBCrUqHC2yjgfN3LrhPMJqDEL4e1e4XR0mS/u/UCWkubHxZZB2/O+TcQ5CGPJ2/1uVPD6eGlDWLl1rgQWxUoSSS497XGI8gQe63gcgB6tDV3zM4omiQa/++3mUji9ARoYZBniuMQKx2IgUoVqaTL6NhWBgG++FXmAFzclGw==; 5:FAXl6WADIRbWEIBmvGVp2SB5gRJh/EoIQvILEmHOJcffeMbufHopaWhd7ceGmV3EFXuSxQqhnaesnb3f9xxVjWFOseS0xqR866UmAvOsmRAahFBAGPlEGA8VCTa/DfagJJVhcfJEWTCoXC5w6ILZsw==; 24:B7BQGtozk0l7qruTtrn7giXL5H2+wNeLy8JNWtQInPi6Ks38uCpulCCJyfi/UVMt25GOsL+pp30lgu+KQrnuUzM4k+vxTlFyIBKyBFqwWuY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR12MB1148; 7:I0hFX6qIQdwo4GwjNZESKLd5bxAg41w74B3tfhUGIYliYC/5YNbYotnqgx/F7CQ8LJyArFM9+GrksJZJBOyRvUkp1j46+fEBvGLcOa4UEjsT5cqXCMDic7vYzygS5XLtO0VgecC+LXCVeRavIl/Ogz5CAA9kQobNJjqRlk+jLgpC3nhJ/PHUWawkE4om63FcU2lnlkupCFeUX6TVsgUroMcEYAAs2fJLXsC0JElnaJ2bYfHnCwjYs+l9H3iOkcYRZ8QMFaW6l3vN3BMO9C3quSOE/rhvxqhy8sY2qIdZy/sxymdsinFDpdKcCKjRE8whzbb3kurSAt4CQOnYS5s1kWM0/tNWPFzVe3DjN875vEMcX67mgf5g1cFLxC5Dx/s/Poxz2iYza5DoisX8N8WcF9S6fQ6q2ChK17FugsGIs8UwPi25BQsch/sW9FcO2AV+xNLkpLIr1D456teHl+laUQ==; 20:bi71kt9lMIOk1lHGL9FzNIcduP47Lq/oBLgjrdyt4c/G4SPUKGAM2mzJUialVQOx9k5pRsdK/lBQY9qxM686d6QNKkf+qgK2QzeAZ6eNk4vDOzkIoUffEo5bBYSx/F93fAhOjzxgx0/2D/VEtdMYneBy3ha7y8U/kq8kJV32RQ0Sm2wSSXwxb4yAh1bgFq41+jMwUITW3xCoRRphAg7wP4jOdexIXf6JN0NX5EkNsi8JyylrH/XzV/VLL6SFoIlc X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2017 21:07:19.5096 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1148 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: <netdev.vger.kernel.org> X-Mailing-List: netdev@vger.kernel.org |
From: Tom Lendacky <thomas.lendacky@amd.com> Date: Wed, 4 Jan 2017 15:07:16 -0600 > When running in single IRQ mode, the additional IRQ routines were being > skipped because only the XGMAC interrupt status was being checked. > Update the code so that the additional IRQ routines are checked whenever > an interrupt is received. > > Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com> Applied.
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c index 155190d..9943629 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c @@ -539,6 +539,7 @@ static irqreturn_t xgbe_isr(int irq, void *data) } } +isr_done: /* If there is not a separate AN irq, handle it here */ if (pdata->dev_irq == pdata->an_irq) pdata->phy_if.an_isr(irq, pdata); @@ -551,7 +552,6 @@ static irqreturn_t xgbe_isr(int irq, void *data) if (pdata->vdata->i2c_support && (pdata->dev_irq == pdata->i2c_irq)) pdata->i2c_if.i2c_isr(irq, pdata); -isr_done: return IRQ_HANDLED; }
When running in single IRQ mode, the additional IRQ routines were being skipped because only the XGMAC interrupt status was being checked. Update the code so that the additional IRQ routines are checked whenever an interrupt is received. Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com> --- drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)