From patchwork Mon Jan 2 11:56:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 710164 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3tsbCB5Xm8z9t0v for ; Mon, 2 Jan 2017 22:56:38 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="MdXpXAX1"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755582AbdABL4f (ORCPT ); Mon, 2 Jan 2017 06:56:35 -0500 Received: from mail-lf0-f68.google.com ([209.85.215.68]:35884 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755536AbdABL4c (ORCPT ); Mon, 2 Jan 2017 06:56:32 -0500 Received: by mail-lf0-f68.google.com with SMTP id t196so23281756lff.3; Mon, 02 Jan 2017 03:56:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=1Aw8pPwuy7lw259otKyaFzYLFIWKBi7B3P7YCQBzhN8=; b=MdXpXAX1hiE8yLyxR19GNotE63cQXqKeuvAVKDoVXiV7ppmkDJWQjFzz+G/Zp/XdKT cHEspMWnsqLATr90BUzqlDowNDBCCN/BXETMbk/SnZqgzu4W2+9tHuhsJ8BgWkIaBmKP wlFSVa8FyAwuOZ8iHRqhl6udqFqLjDVW8ZXrBc6+2Gk1LauX89EX0UT460hdadejCo4f BeP0mDNT2nvya1h1h3Q1KkTBwo2WVoobWtxPpkwRN9dpJ7cOzAbJ/KYVh0iHW2MFYqj8 ib4vhtWnH0FgYgM8efzBuDh3xy6nF+nJdLch9bkfVoLCwMEY0ewjsv3fDKUde1jVt/65 Rw9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=1Aw8pPwuy7lw259otKyaFzYLFIWKBi7B3P7YCQBzhN8=; b=W5Ugz7kaWuyXyLnK70cWBGSTVma35ky6y3aWTnw21gcCpt3S2Pl987WcZOqhB54/kM tceKlzxOIJaFyDefd81JwJrz7JF2tgIPLoYev28D7rjd+FGGZz0FIWDn2hNpB3+ACGrK LdhzyNxkCHyWUny4rhrssSx3F6xAA+djdlCt362HnrXwEtMYxu/W8bj6Jl6ykEzV6FGX 5v3kpYja9kJc1Xtip8uo9QOrsITSCqmoSpv5jXT3PdKGxJfXNF0f6OUORGadqT5Wa3R8 1xuT8m0ntjYgZ4a/bAz1PLdm80yiOmAeaRs+K/4jUOAvhKFSBhXNirx8UcsmTaCbsBRK v33w== X-Gm-Message-State: AIkVDXI7+mkkvuM/6szQ7x3NYafbs02AmSSNj/BWg3ekFdxq4DmNphKAZTyRRMSsa3O+AA== X-Received: by 10.25.203.148 with SMTP id b142mr15866401lfg.145.1483358190912; Mon, 02 Jan 2017 03:56:30 -0800 (PST) Received: from xi.terra (c-04aadb54.07-184-6d6c6d4.cust.bredbandsbolaget.se. [84.219.170.4]) by smtp.gmail.com with ESMTPSA id z26sm15854293lja.49.2017.01.02.03.56.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Jan 2017 03:56:30 -0800 (PST) Received: from johan by xi.terra with local (Exim 4.88) (envelope-from ) id 1cO1E5-0008Si-4y; Mon, 02 Jan 2017 12:56:29 +0100 From: Johan Hovold To: "David S. Miller" Cc: Giuseppe Cavallaro , Alexandre Torgue , Neil Armstrong , netdev@vger.kernel.org, linux-oxnas@lists.tuxfamily.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH net 1/3] net: stmmac: dwmac-oxnas: fix of-node leak Date: Mon, 2 Jan 2017 12:56:02 +0100 Message-Id: <20170102115604.32482-2-johan@kernel.org> X-Mailer: git-send-email 2.10.2 In-Reply-To: <20170102115604.32482-1-johan@kernel.org> References: <20170102115604.32482-1-johan@kernel.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Use the syscon lookup-by-phandle helper so that the reference taken by of_parse_phandle() is released when done with the node. Fixes: 5ed7414062e7 ("net: stmmac: Add OXNAS Glue Driver") Signed-off-by: Johan Hovold --- drivers/net/ethernet/stmicro/stmmac/dwmac-oxnas.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-oxnas.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-oxnas.c index c35597586121..fcc237e0aae1 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-oxnas.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-oxnas.c @@ -109,16 +109,9 @@ static int oxnas_dwmac_probe(struct platform_device *pdev) { struct plat_stmmacenet_data *plat_dat; struct stmmac_resources stmmac_res; - struct device_node *sysctrl; struct oxnas_dwmac *dwmac; int ret; - sysctrl = of_parse_phandle(pdev->dev.of_node, "oxsemi,sys-ctrl", 0); - if (!sysctrl) { - dev_err(&pdev->dev, "failed to get sys-ctrl node\n"); - return -EINVAL; - } - ret = stmmac_get_platform_resources(pdev, &stmmac_res); if (ret) return ret; @@ -134,7 +127,8 @@ static int oxnas_dwmac_probe(struct platform_device *pdev) dwmac->dev = &pdev->dev; plat_dat->bsp_priv = dwmac; - dwmac->regmap = syscon_node_to_regmap(sysctrl); + dwmac->regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, + "oxsemi,sys-ctrl"); if (IS_ERR(dwmac->regmap)) { dev_err(&pdev->dev, "failed to have sysctrl regmap\n"); return PTR_ERR(dwmac->regmap);