From patchwork Mon Nov 28 12:51:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Vadai X-Patchwork-Id: 699961 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3tS65X37wQz9vFp for ; Mon, 28 Nov 2016 23:52:16 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754661AbcK1MwL (ORCPT ); Mon, 28 Nov 2016 07:52:11 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34506 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754642AbcK1MwJ (ORCPT ); Mon, 28 Nov 2016 07:52:09 -0500 Received: by mail-wm0-f68.google.com with SMTP id g23so18851069wme.1 for ; Mon, 28 Nov 2016 04:52:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TJwh6gmD07Q/SNkm4vSLMC10asF6rYvYlV3OjUzk0vU=; b=GdBdNMubf39ZnpSneBDTduN5IZHGc709L94XXNZiTiR1/bk9ILysBUzQsQHIAhxqPW 1EZEI9fSV8R9xSDu9/gsTXxPP/nLvdatgXDbLWPFx/D9f6FqO/ZYtlTri+TbER7M+4oE pOcCveIAEShnrLZd/vgc7RBvzlYLvXAp2ZtNf+ER7TFsISWihcWKAeMYYYg7jFlTW1Lh YsaXI6+qVmutWzj6t9RQxQJwEEL+NG0w/cJu3MMQE5H1IDc+X1mDgT22Ub8VMYV7zFpw l9LPsAQ7oScQxEGa9wDrIDm2AYKzR/RlVPp2FxqkdgfzGFFgCo5v8VymWkM8bgNmM7Yd szWQ== X-Gm-Message-State: AKaTC01RBW4SG3GXCfaQEI6WxuqYNAUUcF4KkUsbXVJhOSIpCryj3wFxywcsm6ssSXEqIQ== X-Received: by 10.28.104.213 with SMTP id d204mr18522248wmc.101.1480337526876; Mon, 28 Nov 2016 04:52:06 -0800 (PST) Received: from office.vadai.me ([192.116.94.216]) by smtp.gmail.com with ESMTPSA id m145sm28662110wma.3.2016.11.28.04.52.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Nov 2016 04:52:06 -0800 (PST) From: Amir Vadai To: Stephen Hemminger Cc: netdev@vger.kernel.org, "David S. Miller" , Jiri Benc , Or Gerlitz , Hadar Har-Zion , Roi Dayan , Amir Vadai Subject: [PATCH iproute2 V2 1/2] tc/cls_flower: Classify packet in ip tunnels Date: Mon, 28 Nov 2016 14:51:35 +0200 Message-Id: <20161128125136.3393-2-amir@vadai.me> X-Mailer: git-send-email 2.10.2 In-Reply-To: <20161128125136.3393-1-amir@vadai.me> References: <20161128125136.3393-1-amir@vadai.me> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Introduce classifying by metadata extracted by the tunnel device. Outer header fields - source/dest ip and tunnel id, are extracted from the metadata when classifying. For example, the following will add a filter on the ingress Qdisc of shared vxlan device named 'vxlan0'. To forward packets with outer src ip 11.11.0.2, dst ip 11.11.0.1 and tunnel id 11. The packets will be forwarded to tap device 'vnet0': $ tc filter add dev vxlan0 protocol ip parent ffff: \ flower \ enc_src_ip 11.11.0.2 \ enc_dst_ip 11.11.0.1 \ enc_key_id 11 \ dst_ip 11.11.11.1 \ action mirred egress redirect dev vnet0 Signed-off-by: Amir Vadai --- man/man8/tc-flower.8 | 17 ++++++++++- tc/f_flower.c | 85 ++++++++++++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 98 insertions(+), 4 deletions(-) diff --git a/man/man8/tc-flower.8 b/man/man8/tc-flower.8 index 74f76647753b..0e0b0cf4bb72 100644 --- a/man/man8/tc-flower.8 +++ b/man/man8/tc-flower.8 @@ -36,7 +36,11 @@ flower \- flow based traffic control filter .BR dst_ip " | " src_ip " } { " .IR ipv4_address " | " ipv6_address " } | { " .BR dst_port " | " src_port " } " -.IR port_number " }" +.IR port_number " } | " +.B enc_key_id +.IR KEY-ID " | {" +.BR enc_dst_ip " | " enc_src_ip " } { " +.IR ipv4_address " | " ipv6_address " } | " .SH DESCRIPTION The .B flower @@ -121,6 +125,17 @@ which has to be specified in beforehand. Match on layer 4 protocol source or destination port number. Only available for .BR ip_proto " values " udp " and " tcp , which has to be specified in beforehand. +.TP +.BI enc_key_id " NUMBER" +.TQ +.BI enc_dst_ip " ADDRESS" +.TQ +.BI enc_src_ip " ADDRESS" +Match on IP tunnel metadata. Key id +.I NUMBER +is a 32 bit tunnel key id (e.g. VNI for VXLAN tunnel). +.I ADDRESS +must be a valid IPv4 or IPv6 address. .SH NOTES As stated above where applicable, matches of a certain layer implicitly depend on the matches of the next lower layer. Precisely, layer one and two matches ( diff --git a/tc/f_flower.c b/tc/f_flower.c index 2d31d1aa832d..1cf0750b5b83 100644 --- a/tc/f_flower.c +++ b/tc/f_flower.c @@ -41,7 +41,10 @@ static void explain(void) fprintf(stderr, " dst_ip [ IPV4-ADDR | IPV6-ADDR ] |\n"); fprintf(stderr, " src_ip [ IPV4-ADDR | IPV6-ADDR ] |\n"); fprintf(stderr, " dst_port PORT-NUMBER |\n"); - fprintf(stderr, " src_port PORT-NUMBER }\n"); + fprintf(stderr, " src_port PORT-NUMBER |\n"); + fprintf(stderr, " enc_dst_ip [ IPV4-ADDR | IPV6-ADDR ] |\n"); + fprintf(stderr, " enc_src_ip [ IPV4-ADDR | IPV6-ADDR ] |\n"); + fprintf(stderr, " enc_key_id [ KEY-ID ] }\n"); fprintf(stderr, " FILTERID := X:Y:Z\n"); fprintf(stderr, " ACTION-SPEC := ... look at individual actions\n"); fprintf(stderr, "\n"); @@ -121,8 +124,9 @@ static int flower_parse_ip_addr(char *str, __be16 eth_type, family = AF_INET; } else if (eth_type == htons(ETH_P_IPV6)) { family = AF_INET6; + } else if (!eth_type) { + family = AF_UNSPEC; } else { - fprintf(stderr, "Illegal \"eth_type\" for ip address\n"); return -1; } @@ -130,8 +134,10 @@ static int flower_parse_ip_addr(char *str, __be16 eth_type, if (ret) return -1; - if (addr.family != family) + if (family && (addr.family != family)) { + fprintf(stderr, "Illegal \"eth_type\" for ip address\n"); return -1; + } addattr_l(n, MAX_MSG, addr.family == AF_INET ? addr4_type : addr6_type, addr.data, addr.bytelen); @@ -181,6 +187,20 @@ static int flower_parse_port(char *str, __u8 ip_port, return 0; } +static int flower_parse_key_id(char *str, int type, struct nlmsghdr *n) +{ + int ret; + __be32 key_id; + + ret = get_be32(&key_id, str, 10); + if (ret) + return -1; + + addattr32(n, MAX_MSG, type, key_id); + + return 0; +} + static int flower_parse_opt(struct filter_util *qu, char *handle, int argc, char **argv, struct nlmsghdr *n) { @@ -339,6 +359,38 @@ static int flower_parse_opt(struct filter_util *qu, char *handle, fprintf(stderr, "Illegal \"src_port\"\n"); return -1; } + } else if (matches(*argv, "enc_dst_ip") == 0) { + NEXT_ARG(); + ret = flower_parse_ip_addr(*argv, 0, + TCA_FLOWER_KEY_ENC_IPV4_DST, + TCA_FLOWER_KEY_ENC_IPV4_DST_MASK, + TCA_FLOWER_KEY_ENC_IPV6_DST, + TCA_FLOWER_KEY_ENC_IPV6_DST_MASK, + n); + if (ret < 0) { + fprintf(stderr, "Illegal \"enc_dst_ip\"\n"); + return -1; + } + } else if (matches(*argv, "enc_src_ip") == 0) { + NEXT_ARG(); + ret = flower_parse_ip_addr(*argv, 0, + TCA_FLOWER_KEY_ENC_IPV4_SRC, + TCA_FLOWER_KEY_ENC_IPV4_SRC_MASK, + TCA_FLOWER_KEY_ENC_IPV6_SRC, + TCA_FLOWER_KEY_ENC_IPV6_SRC_MASK, + n); + if (ret < 0) { + fprintf(stderr, "Illegal \"enc_src_ip\"\n"); + return -1; + } + } else if (matches(*argv, "enc_key_id") == 0) { + NEXT_ARG(); + ret = flower_parse_key_id(*argv, + TCA_FLOWER_KEY_ENC_KEY_ID, n); + if (ret < 0) { + fprintf(stderr, "Illegal \"enc_key_id\"\n"); + return -1; + } } else if (matches(*argv, "action") == 0) { NEXT_ARG(); ret = parse_action(&argc, &argv, TCA_FLOWER_ACT, n); @@ -509,6 +561,14 @@ static void flower_print_port(FILE *f, char *name, __u8 ip_proto, fprintf(f, "\n %s %d", name, ntohs(rta_getattr_u16(attr))); } +static void flower_print_key_id(FILE *f, char *name, + struct rtattr *attr) +{ + if (!attr) + return; + fprintf(f, "\n %s %d", name, ntohl(rta_getattr_u32(attr))); +} + static int flower_print_opt(struct filter_util *qu, FILE *f, struct rtattr *opt, __u32 handle) { @@ -577,6 +637,25 @@ static int flower_print_opt(struct filter_util *qu, FILE *f, tb[TCA_FLOWER_KEY_TCP_SRC], tb[TCA_FLOWER_KEY_UDP_SRC]); + flower_print_ip_addr(f, "enc_dst_ip", + tb[TCA_FLOWER_KEY_ENC_IPV4_DST_MASK] ? + htons(ETH_P_IP) : htons(ETH_P_IPV6), + tb[TCA_FLOWER_KEY_ENC_IPV4_DST], + tb[TCA_FLOWER_KEY_ENC_IPV4_DST_MASK], + tb[TCA_FLOWER_KEY_ENC_IPV6_DST], + tb[TCA_FLOWER_KEY_ENC_IPV6_DST_MASK]); + + flower_print_ip_addr(f, "enc_src_ip", + tb[TCA_FLOWER_KEY_ENC_IPV4_SRC_MASK] ? + htons(ETH_P_IP) : htons(ETH_P_IPV6), + tb[TCA_FLOWER_KEY_ENC_IPV4_SRC], + tb[TCA_FLOWER_KEY_ENC_IPV4_SRC_MASK], + tb[TCA_FLOWER_KEY_ENC_IPV6_SRC], + tb[TCA_FLOWER_KEY_ENC_IPV6_SRC_MASK]); + + flower_print_key_id(f, "enc_key_id", + tb[TCA_FLOWER_KEY_ENC_KEY_ID]); + if (tb[TCA_FLOWER_FLAGS]) { __u32 flags = rta_getattr_u32(tb[TCA_FLOWER_FLAGS]);