From patchwork Tue Nov 15 22:11:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Lendacky X-Patchwork-Id: 695298 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3tJM6y6Hhzz9t0m for ; Wed, 16 Nov 2016 09:11:38 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="DipF0BPA"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161010AbcKOWL3 (ORCPT ); Tue, 15 Nov 2016 17:11:29 -0500 Received: from mail-cys01nam02on0081.outbound.protection.outlook.com ([104.47.37.81]:36682 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935038AbcKOWLZ (ORCPT ); Tue, 15 Nov 2016 17:11:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=dWAnUVYfOQwbTjcVhXM8v3FxOMEw9LFnxfmcmH5abdo=; b=DipF0BPAba25A6efnvIN0GM0qkOw2PlSNMASKuYZc0XdcZn+87qh8012hyvQx2Axm9pD14kbauC5DXcygvs1w9OVrWzGHITW4usvlqzD9Amcf6aWg9DSHyhGeGtde28woIeSWlWLiRsbpwRomKfKyj6olB3KCHGECqGnGgqA8DQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Received: from tlendack-t1.amdoffice.net (165.204.78.1) by MWHPR12MB1151.namprd12.prod.outlook.com (10.169.204.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.721.10; Tue, 15 Nov 2016 22:11:20 +0000 From: Tom Lendacky Subject: [PATCH net-next 2/2] amd-xgbe: Fix maximum GPIO value check To: CC: , David Miller , Date: Tue, 15 Nov 2016 16:11:15 -0600 Message-ID: <20161115221115.12403.53949.stgit@tlendack-t1.amdoffice.net> In-Reply-To: <20161115221055.12403.90574.stgit@tlendack-t1.amdoffice.net> References: <20161115221055.12403.90574.stgit@tlendack-t1.amdoffice.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: BLUPR05CA0082.namprd05.prod.outlook.com (10.141.20.52) To MWHPR12MB1151.namprd12.prod.outlook.com (10.169.204.15) X-Microsoft-Exchange-Diagnostics: 1; MWHPR12MB1151; 2:ot2boYrDNeqmRu1ZAjlYvkcGhbK0bJs9R06vdBYCVDoeSbDlVbzwwpsLp7HuFK8uLckBkbzLFxgtAYAw9Vivx7Eydi9FN3WYQOWPb7un7BnMK4zF5lM4z9ibnmkHbeukYdWYannMiBNk06DaqQ7DoXMKciz3gBaN/E/mXdioIxg=; 3:NUgp7pm8t2pOmNMYPbe2uTeseRB9RALV5lUNeOTUadi/CZ0n4bf+iuWlzBsMjRyOAyB3LJY7PHjeiwdfNv5tZxynw6vQxwIFIkAAh5lotjrgVh7uqjGGT8wx+E6YucfQmBqOowR7UNGAYiCYB7y8ZjJJWXO4Owr+aMcs/mD2/7w=; 25:9r/nEKoaaHgD8AEByfgsdvX1q8ZuzZKVLV/qZUz2+HeYnLI/3gx/yPWQE804PxtmL1vSVzRmVa64LhTCer+CV2oxSjgoy90sY7kS7oVlUFusK+GbZ3Xu77eLdUIVt4A03xqvHfepsxrQ86mKgHXbQMUVvxCySzZG8C5O/dA2u/66sd+bezghDTjWUxIaY8fh7h4SNLcjC3TDPTWPiBhIuh5ev2lfC8WEBpZQz92rnqcTlXUYGjFMLHoNOF9l5uCCskU+1jDB7cxQyNuoWlrCmbViK1hOFAoqEEs0rgWt5y4t/VARd0Yb4bqiUe/QMNM8BCpmsRQDKj3Rc2quY/RVMW/IyWOSvtWYuGUb2xnwh790YzrJxyg3LNUUZ/bonLz82vUFKhG+CQ74cTFI8O08XY7sox+znQqpUz7wr8M+buNH5Xny7QhUZsOE1YgHo5qX0+0BVQuNdICJyOkZUOWS7Q== X-MS-Office365-Filtering-Correlation-Id: 12fe6e58-aa1d-45a9-eb3d-08d40da454b2 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:MWHPR12MB1151; X-Microsoft-Exchange-Diagnostics: 1; MWHPR12MB1151; 31:ro9J5/illnr+cXvR5jE0amT6BpTpF9RX5VRHykMUX8IjaNd1w71Fi15iFzBixghM83om7aHOrpWR4p76mwxcakOC17gQC3HJwyw3t6ZtQxZFouWcGMkEQmSMRE2V7LPK8rAo3bLZILNUO+WjgllnJ8D33RbWmgmrtTuNr5Clk+fkFQNMOuDo0Kt5LmkOLZD8z8s5i7tl/3+Li/9cS1OhtPObujOCiOm6zTkgTBahHBc+TKuPyah8ErjS95JKPvtgAjhLSajAeikm4A8ApTg/fQ==; 20:m95Z1WwAy1SLZFyGuzaezr5tkBnHvoTgRq/p+DxGC5dfcoLWau3YUjmEgzRyycIpbIeeZQK9ah8jkSbLi0dUgWc7ix/OyvCMntasHXhueDMz6kE64X0jp2rBlUzUwTn6SgZcBb0p5K/Krq/XEocT4UVhpejZ+f2CATnBzn0xqbIaNzBRyX2NevHNignGhvMQCjJMZI33bU3sCu27ezUreNk0BLRVnZmAFPZMm5qhaN3spL7KNE06mgMRFG3kMmmu1MQgWcFTQXfZ/ocjL652KKcmNcCXhcjgqRThJXHbWLUwYrm0r0L4HbDq87PwDGVA2EJnCUCWdazkceiqufG8tMitIvsveJD1yxZKRCoRMDFS077wnwz6A2wcxQIK5tLmUnbXxpZ4tcVvbzVbEzUMw+X2cf9iy+Z1lHJlw5W1rVbmMBpr6lnPVPBPrQCfgm3cwOhYU+anaGTjvbrjWu3b2KSRkdVZ8glwSdXwQ2Qc3yTfsJ+BbJSnH+7kuLfWKFY2 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110)(198206253151910); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6060326)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6061324); SRVR:MWHPR12MB1151; BCL:0; PCL:0; RULEID:; SRVR:MWHPR12MB1151; X-Microsoft-Exchange-Diagnostics: 1; MWHPR12MB1151; 4:6+MAE8mEIb79e6N37irfKjvSaCXnqFtvNE/rlpsZwd/yQYRmaJDnlZ80x1y3SjoGZUHHW3p0bm1vAHp1doXn01TXpotD6Aus/z1pV9xUF4GG8+if6zjNsIFgTQ6t3ksm8ZDKk+kPvW3PColGvT1vdo4KMoo9ocnk8lSQxClrD9BA/gHy5+4r9SGDRQW+H0hQmf9o+JKyHh7aVX8uCiyoRR8Nqlkp4zD5YA3bCTgC/tASdkSGiap/Zp3eeBHI2oDp92oPO8KGw5eFAP96/mz1gRsF6dvI7PVU5pCrsng/cb1EzNjlV+4Wltvj1Or/ByCK/eef2dxzqPVyb9E5YGY1MB5iFJiDFkpJqdBNsjdIs1vjQJpsvP68tLOMD/If/wQtmIDrwqjZvRoDR9OJNvATPcAjighBmgZZaR3eitp0YoOKrtQMhINgAi7FBeoiEvoxZXSyspOXuzPBgHZQiQ/zG9YU+yLPH4AQM6ycnHX5ET6sJAsjBtE/e8s6C5KXP0BvR+bc2lE+Ob+eRBHcqX3s+g== X-Forefront-PRVS: 012792EC17 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(199003)(83506001)(33646002)(77096005)(101416001)(4326007)(66066001)(97746001)(68736007)(47776003)(50466002)(6666003)(50986999)(54356999)(7736002)(7846002)(5660300001)(9686002)(1076002)(8676002)(2906002)(81156014)(2950100002)(6116002)(305945005)(76176999)(6916009)(81166006)(3846002)(189998001)(23676002)(97736004)(103116003)(86362001)(110136003)(69596002)(106356001)(2351001)(42186005)(92566002)(105586002)(53416004)(4001350100001)(230700001)(71626007); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR12MB1151; H:tlendack-t1.amdoffice.net; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjEyTUIxMTUxOzIzOjY4ZnlwZTVrVEJuUzZJVHVPVndHMkNzRDBR?= =?utf-8?B?cjRBUzlLYUFSTVFYS090bjFtQm5ITXJZdk1zZkpJSHhiOWJ3ZnRpWjVITXl4?= =?utf-8?B?VzlWY3BhQ01wUVB5ZW5WV3gydzNVY05oeU90Q05BVW1UQ0xsYVJ5Ym9ydTA4?= =?utf-8?B?Y3phcDN4b0VoWXNDM1NsK05UZHp5TWpFZ2o3L3MzaXZkTEtYRmw3TTB0bFpu?= =?utf-8?B?aWxLNTlqSmNFTmVVU1hLdzlvVjdHTjY1eGtUSm9xVG82dThTeFhzNllVRG5n?= =?utf-8?B?YnJhRHlES1hDcGtiYWwrTWtTWm5nR2puL1pEbmlTZXhpdGtGVG13SlJ6OVBq?= =?utf-8?B?Tk8wdEQ3N0xaVUM2UjRkMUxGcFNIelVhMVoxUlMvOUxrYzRpK2FmYkpiSGVJ?= =?utf-8?B?YnFkRWc0azJ5ZUFZeGhsRTlPWldHS0JDWXNvWHBRNFFZN2NjTzFubGhyRENj?= =?utf-8?B?RkZpNE40UzRRSko4eDdBSktPV1ZocFJnU3FGS08wbkNVNWpqc1VLUUE5cGRK?= =?utf-8?B?dktPMHJwSXV2R1VmSk0yWmdWWDZQWFFXOWoza09sd0NtbE1Vb1lpRnpjWkhy?= =?utf-8?B?c1JLa3d5UzhyeWtMYmU1ZWVHVzU3aFVib011c3c3cS9BanZTT0tvTW5wdkR1?= =?utf-8?B?QTNaelhPbVJydTBTbTRLSUwvTzRXTG1WUnEwK1NpWlNLa1dtNlZ4TTRIOHdY?= =?utf-8?B?M2U1QW1xMXF5U3JmanFsa1ZmRU52SDdVQ0FKMVRNUTVqay93SDBhMGFlWlFZ?= =?utf-8?B?MXp5SDloTk5VazA2ZXpCV3dPbUFpWWNhU0FmT3hMVFJOUE5ES3pBek95bmxn?= =?utf-8?B?RFhLNGZXYThyOS9PSm5PWmlJa0RjTUdtazA2Rytlc1dFdW83MXl3SWgyeGcx?= =?utf-8?B?TVV6YllCT1c3ZS94S1JtNCtYc1l0T3FxOHU4enpyeUhXZnlWY3p1bDdvR3RV?= =?utf-8?B?WU9RN0hkeG05a1hsWWJQN2c0Ujd3a3htQkloUGtqbnlTQ29RdWY3MkRPMVkv?= =?utf-8?B?VjcreFZBT3I2K2liM0psV01rVUYweXJBNVUxU0huQ25yNXZ1dWZkeVlPRXpa?= =?utf-8?B?Rk9xNlprR3V2K3NVL2pldWg1NVl3VlNsMm41dnYwV1FCdk1vYytWeDV6UHB1?= =?utf-8?B?b25DRG1CT1BCdXI5MG1veU81QnRDTHBLcGFkMjhXY2NBNlZkZjlTMHptY2l6?= =?utf-8?B?MEYzdFhJakdJbzR5aElDZnZ1Z2dlR0FVazhvZnlhMEJCWUFDa0lNaFRTbkZT?= =?utf-8?B?dnJzak9pQmFhZ001b2tPZHkvRFhXZDVWeXlGSDQvTGwwRUUwbFRlV3hkcUdz?= =?utf-8?B?Z1EzVU0xTUxLSGlCbi80MHhJN0YrNE5NVUJBTzFpd3VYcjd5dndXUHQxYXNw?= =?utf-8?B?c3NFblc4amt1YkVBeW9TL0Z5UUd5bEZubVFpMWxmK0NRU1VlYTRmVFNqSENx?= =?utf-8?B?VkNVK0l3UHZ1YjJ1OGw2YloxNXBCVVZyMWpQdHZTQ2xkY1MyZ3gveGQralNh?= =?utf-8?B?OVl0SkJEcSt1cVdLaW91U3lXU3YzV0pVaTlNQ291QXJPQ0tmbjNTd2pCV3FZ?= =?utf-8?B?VlhLajdZZnhYQi9pY3VCUXgzL1FNeENlcmVyT2JZSStCRGtiTXlYaXI1VFpV?= =?utf-8?Q?7KSA9zvANaA6ZnKhKNuO?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR12MB1151; 6:/DSNxkrX6mmI0LMMQ3DMbZPuDxhS3q2L8TveRoAneAdo8q2USA66xT+5rOZv2lLevLFBIp9l46aCiQJOPSnncNthLs5DOWNfKXIY0RrhXBc75h2JE2Cp4z03TONFkxDfzeyub5MIHAxRAv0XAdi9CWDiMQaUoQiC5lxUaeWzUyW86mXHMtJn97kai1xMOkzz84EGkXlKw/CK5AQZxF71FdZbqb42EI+S7nU6qzIxsZZZxsPRKI6JZUIeoIIEVW6PjtUs7etMeAjGOpk//WXPj/Fp9mdCLil4Vbdn2+L8qHaopBOpyYDl/0ZhcVm37P3Hk3GU/g8VYWKRVIR2Dqq3hNt9AI4h3nFJRbwDLMJsd5MfpBMKAiIBJEwJUuCGZHiR; 5:8ns4W9rzZ6lUxNL1cDmjTnFT0p5VV3ofBBuJCwDHSL3qLQR6h1JRu3hBwWXA49MNarKqiANtzyH46RStI5Tci4EWJIBGfamHeElYZs1yQD86hl0OOBHvldfJf4X3b4uJCL85Rn8ny2eCEhVssatnraBSxr84W1gIYeYVBQThMUQ=; 24:upLrFcDLYwA0RKdrJdcVKIdcfhmgcx+yNKuhFgHCbsJyChNH8XSc23ccH/PlLqxqEWYl5smSi/Smwy+YhKDVlwNUs7EoOThIOhOHL/1xxSQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; MWHPR12MB1151; 7:gGdSm/UcQE4vm0AiAimdI2nF+Su8MnmNiyJlxZPxDy7QjKZrfD+Bex69Kfk1baYNH/ZRTNYs1uJ+6LUXDFRt9+0iAAUOTkMczJRG0touGmdFHwHNgRcFdU0YRrtRB7ONs7kA6dbsRRdXcwn50e8LZB2UUhOXbGK91YJkUN9fSECyoiCGBaaz99CDpfw64O3J6pXP1jy8aWQUFlDBxyFF8OBge4XIjEzT/A6VxnXR6P6CR3ks7Q0tapBNmJXnb44luVn3JAoajn5KMF+VubC0IzHRAAD1VohkdTMyQ1DKCqDINsNDMP76SzeQbrNJE1Ns5fFv5D/1UrNz9aSiTQy93X72yt2v19kHLwwSoJZgnBQ=; 20:QWjEguF4GWruQdvvfdW2++b9MPrm9Mtyn/hv9/NR+PyjuO4QOfKvF4FYDc+rbbZUL2bVBQg6LRKpsgwYHyifFYBQPFJ6rWguyAFO+TFkm1fYK2qOA2saPisDy6JGTOmq25/c8D6MBxgi3UOHQWOf8B7LZV7ewGghLbwYAmp7fLc1Gz43uddBb3iukG0MCdPwmZoSu0lHDO0/3NFg+ZkdvT9QfpZHzd4dSKzfXjpMbV6b42QCi2AxXj1m00S/q7Tw X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2016 22:11:20.5345 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1151 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The GPIO support in the hardware allows for up to 16 GPIO pins, enumerated from 0 to 15. The driver uses the wrong value (16) to validate the GPIO pin range in the routines to set and clear the GPIO output pins. Update the code to use the correct value (15). Reported-by: Colin Ian King Signed-off-by: Tom Lendacky --- drivers/net/ethernet/amd/xgbe/xgbe-dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c index 30056e2..aaf0350 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c @@ -1099,7 +1099,7 @@ static int xgbe_clr_gpio(struct xgbe_prv_data *pdata, unsigned int gpio) { unsigned int reg; - if (gpio > 16) + if (gpio > 15) return -EINVAL; reg = XGMAC_IOREAD(pdata, MAC_GPIOSR); @@ -1114,7 +1114,7 @@ static int xgbe_set_gpio(struct xgbe_prv_data *pdata, unsigned int gpio) { unsigned int reg; - if (gpio > 16) + if (gpio > 15) return -EINVAL; reg = XGMAC_IOREAD(pdata, MAC_GPIOSR);