From patchwork Tue Nov 15 22:11:05 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Lendacky X-Patchwork-Id: 695297 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3tJM6Z2xPRz9t0v for ; Wed, 16 Nov 2016 09:11:18 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="I4eBwBQB"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935091AbcKOWLO (ORCPT ); Tue, 15 Nov 2016 17:11:14 -0500 Received: from mail-by2nam03on0082.outbound.protection.outlook.com ([104.47.42.82]:13747 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935038AbcKOWLN (ORCPT ); Tue, 15 Nov 2016 17:11:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=R0lqs4ePwraAcrxRG+98ktv0k5h1ha8vrFg3pgRFMk0=; b=I4eBwBQBv+L1GMaMitEO8xVDcLgs8vnRYl8rGRvMd6YFdhbZo4P2IPEXqv0+1XwCz4+KKUvTcY9zvo6gsuu4+eMKs5kHuvGaVj25XS9/rGlNEEF7cM3VRKlHECNMYRBQGoOZR5PWSVEk6fb8QlPbifP84DVQqsDycvIe4RHDPVQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Received: from tlendack-t1.amdoffice.net (165.204.78.1) by MWHPR12MB1149.namprd12.prod.outlook.com (10.169.204.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.721.10; Tue, 15 Nov 2016 22:11:09 +0000 From: Tom Lendacky Subject: [PATCH net-next 1/2] amd-xgbe: Fix possible uninitialized variable To: CC: , David Miller , Date: Tue, 15 Nov 2016 16:11:05 -0600 Message-ID: <20161115221104.12403.96505.stgit@tlendack-t1.amdoffice.net> In-Reply-To: <20161115221055.12403.90574.stgit@tlendack-t1.amdoffice.net> References: <20161115221055.12403.90574.stgit@tlendack-t1.amdoffice.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: CY1PR08CA0008.namprd08.prod.outlook.com (10.163.94.146) To MWHPR12MB1149.namprd12.prod.outlook.com (10.169.204.13) X-Microsoft-Exchange-Diagnostics: 1; MWHPR12MB1149; 2:9vJuaYCk2/b/0sFr0cNtniWdO78WHd/XAQ/GNHea9so57K3torMA9j1XW8uFv9jcFedyoX4y2gOZho9PkPggs9w7goE/oe11Qb6q67PcaUP2aVpf2ETuzPq0pWHX8T8tu67vpFXbq2KKRrRVEEzXeO3DoiPosKZUPbOO1xQ5MCE=; 3:pVxeeoS5NOb76hD+ZqycGPZ5jIBi6CSD5FE3v0Evwi18rHizR9gMcW/QLI5Rf+5Eyg4JvBjIusLalzVxxaV3LyPZ5Z47yoNBZgtfxt285BrqjJKGMV36ERrMDqjN5EegJavjwuzCYHPYQVsPl7HyaYXUyV0Wv9SUY1oTGpDv+h4=; 25:UjhkVv2To+c2/h9L/4nO2jPS51QS5M0Jpsu0S+QWMgghsuFE2OyZRr9SI+b+TzJKEU/8toX/ExSJWqsXllOGg8nIDebRIjegR1bfMOyMrgVAROpOKD2uzLe6oOCc50RZYQP9i3lSIRIgQAatqjlzdQcfg9ie2p3gLiruNlOLeth61wKn8wzqliTKpVIW3HcImeygJeVDIrqa3MHkx7Z0pa4pjUXb5Iceq889vmA+IFxi+ONi+54tVrYYYHu2qBL3zQPoV7+GEpNHjKZ//pZiVDm6GN6qG8IJ4aMBzxottuNaE3tr0yyK4aTYIubp5kyXCD8fDzu6U4sHr42jL+vxipXO6X9zXf9PaJdewJ1W6sevSTVNB9sq9teodU1VrPzUbppEUEuWmUJioDLh77DRoPuC1EA6WHF9kNrV9l+a2zVEzCbMe1LD3qT6QLvgqQ8EyOyUQJq1vnw6ZWl/MJzN8Q== X-MS-Office365-Filtering-Correlation-Id: e0286bb3-2a64-4106-8c74-08d40da44db4 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:MWHPR12MB1149; X-Microsoft-Exchange-Diagnostics: 1; MWHPR12MB1149; 31:WDFhdokGBjtHzMf0KfasM6RCqVc5FV0yqfbQYfbnFUWeughyNydRU5UWseLtgZ8ScmOpI9t0V1YQWJA8xnuFLMOQTnrfXtuvjqcndD5Gk2nuzSgLLY/jXAuDwuhoUmmZvsjcCpge6OVEWgpggpYmbJHb3K8WTYHSbQnfBL5OZnluP5pSfnhi1cxUL9C9gZbezFG4noIIs0vv2/GTqjvwv4vg1Aps0TuOWYTIL5uA/r9DHs//qyXIdzrLGMvbpRDS9XepXfkfCKODbQ/zZbYDGw==; 20:UUYu7roifTseJWc0rUG699jbuZsQ4ipilvurnNF7UyuqB1Qw62NrCZ9W0eVpPPxUvaYHBI118EGGg5vtwAAAZQnYDdFfSLJIWJHbTk5fk8eWZxDNK/y5U7xmA/zmP71VpOewIxwjrSBFs3YsmD/1FGSs9uRQFvVUBI+LvJt2pLyQvGRLtLbc2X32YFoDC+Ni3nXn8PqR37LgPc9atLa750JTD/0WShAAs95FXTiYlmFNAiKGR02nAI7lUN0wQBdB1L7Php6jT0o+YIQNSVfeImmtOSGF2YHfg6GCCrFCi6zKhLjDRR67HpIBB7Dq3gx2dsb+A5h5r1BrOygxD6BcOPL6mQ78yhv4zQjCjq0WK2HWblKnMlOW5EkHqHPI7IcrmxCbj8J2+J3b+8tBZZzGbveYQe6WGT8dXiuvNnBMaf/HHGfuVC3PCDof9IU75kC/xbMNKgacsfRpPhP9dPu32WFrFbjO92Aqfx0PEMh3/c3+XUvi++go77sDEKhbk/eB X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110)(146099531331640); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6060326)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6061324); SRVR:MWHPR12MB1149; BCL:0; PCL:0; RULEID:; SRVR:MWHPR12MB1149; X-Microsoft-Exchange-Diagnostics: 1; MWHPR12MB1149; 4:bBeRR40NoNmKIg1ZIrk4y/DQ5Ab2vHSMZt/CkSCPHE9c+7ICo3+jKI8aqZj+xLnSehEkWrPWfFJuAsJr9OFMWnZBpgnRBFptvP1uo8d4khoXWqIiyHrJ++XOf9ggmgeP1S3PWlHzdwMEAxdTD1lzjl/2pwp9BkiqUG7gMU9dZ4AWoyB0Ry0g5ux/ohKHJfX+P1TJq7HSxetpGTAqTlkEFX/qczh4X7SFxJaEfAOazJ8zLJYFJI1UIt7o7OX4oqfExvIIT/OVmU0otql1OB4NZQlLZr0TjIkALK7hDVIVk5rGqkc0CAYGeQVnJECV4eYRIurtqCKvtVnxKRv2cJej89gdGqhLPqF6/h1ByMNtCOY95A7QB1raISafS6EDiQfFaQzSHKL/JmYZx1bJ7SEVsVoYkIA5yqFwyAnV5pbQLMVlL8WDjr5D+mU3mEXoIOkOqkvg/oNKcGo7hranTSislvOpGLKTTTs0/0i+/sQTSxAeQ5iPqIz4xRBOJlzZeuQVJqon3mDcc2JGTpwOnSFKqw== X-Forefront-PRVS: 012792EC17 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(199003)(97746001)(42186005)(5660300001)(86362001)(53416004)(7846002)(105586002)(50466002)(47776003)(2351001)(106356001)(103116003)(66066001)(101416001)(4001350100001)(50986999)(7736002)(54356999)(76176999)(97736004)(83506001)(230700001)(305945005)(8676002)(68736007)(6666003)(81166006)(1076002)(2906002)(92566002)(3846002)(9686002)(81156014)(23676002)(6116002)(33646002)(110136003)(4326007)(189998001)(6916009)(69596002)(77096005)(2950100002)(71626007); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR12MB1149; H:tlendack-t1.amdoffice.net; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjEyTUIxMTQ5OzIzOnQvdkUwQTVLaEJZZmFWUS9reDFvNmxPN0Fv?= =?utf-8?B?ZFFVNy9tOGhKTWEwYnZPM0RKSmRiWm9ET0lnRHlLd044VEVEcWFMci9lWWZ3?= =?utf-8?B?MlB5WmlET1RZQkdIWmZZeDRHNHdkR1BIcUV4cnd5a0NDeWdkUVlKTnRxZlNC?= =?utf-8?B?NWllTkhMV1dIRFZjNHVBdkRZd2RSMU1XY3kyL2JaTUcza1NKdXd0cE1yTWd5?= =?utf-8?B?WC9qbVFZM0I1TmZ5ZVFqUDJQWkVQL0hBY3Z0SUZCdnRZWmlTV3BMblF6M2tx?= =?utf-8?B?YWszVnhhWEtweGFOY3NDeCtsK1dJUU9CMDdDTXMrcC9DbzdzMnRObisyV1Jx?= =?utf-8?B?VGRoRWxKaWNEK2lmZGlRcmJoNjFtNTFDQ21TV1BqYmwyTlpkeGF0VXpaVC8r?= =?utf-8?B?S2UzVGRISm54WnpvUVMyQWJRcmFrelVQSUtDV2NRVnI5U1NaRWJuTS9wWkpE?= =?utf-8?B?RkR4dzFZbkFsTkFwYWduNTk1ZVJlNzVseVcwamVCRDFGNmtybFppbEcwMlhx?= =?utf-8?B?bDNWQ2pzVys2alY3TS82WlFvbnZlZUJ5UzdHS0QwVDJwQVFleDFuVmlxbHdE?= =?utf-8?B?cXk0TUpaT0JhR3JIcXBDQXFoaG5pc0VHamhpTGVENCtBSDVqbUNLYm0zL1lr?= =?utf-8?B?TGM5Y0x0Kzl1MVozNkViZDhBcU11ai9RMVVDL0h1TGMrZXFMekRZMWRMZkVH?= =?utf-8?B?cFo5Q1poY3Bwbjh1ejE4Z1Y5azBxbXNvWkFkaVNwQUVLalVveWttVTlhMEdE?= =?utf-8?B?eGxqRWxMdk0wODlrRTNEOERVc3o1MlkraWl0VUpGcWJZN1VJdUtXUFlnMkNN?= =?utf-8?B?UlRtVmRpb0pEdysxeGRQc0dTSEYzUmNSOW40dVVhMlQwMWJtUi90THd0b2Qz?= =?utf-8?B?KzBuV3U4WlVhZU1acGFwSjY3KzBlOFhEaXBNb01GaXBpY0lwSnJ2SGZtV2hO?= =?utf-8?B?cG1QTjBUWGUwR0hOSGJ6L2tHTGFGdE5KUmpCYkluQUFnR3p1Wi9SZEtGdGNU?= =?utf-8?B?ZUZrM2gyenBlMXB1eFRSbHdqMUtLK3liTkhsaWVvc3Z0a2ZleDRmTitkdWpn?= =?utf-8?B?TVZFSERiSm82aFo4d0Uvcm9mWHBndnpmUVN4bWRoYmNkVSt5T2ZiZ2VRZzZR?= =?utf-8?B?WEwzOENUa1dXS2VWcU9yVkt3R0FtcWlub0pWcHNSc2ZVSkFEaWk0bnlISk5Q?= =?utf-8?B?THNRbExPR3lWTzQxMWFNY1RBV3lUaTQ2dk4ralRJQzM1dEk1SCs5Q1NUNFZy?= =?utf-8?B?T2kyTVNRU2kzL2hRc1dHRjNGQmlOK2JYNzBPSjhMcmIvNzFWSlhkbEcxM0hQ?= =?utf-8?B?eGwxd2ZmaDlBZWxEMTNsNUUrZU51cDFwYk5IVGY5WCtaZ2N4RGJ6N0I0VVhD?= =?utf-8?B?ZE13elJZVGtMS3pLdlVndUdhNlM1SCtudXZuUWpmU3ZvK1pidjFaUEZ4dklL?= =?utf-8?B?dnhPZ1drQm1iemwxV0FKM1A0Q3NzT0lMVm9KRUNkUUkyRmFMcDlhRnBjRFFn?= =?utf-8?B?SEhnUDMyMkR3eU80RUpnRTc2dVNyUjFkRGNjTkQ0QkpLa3lTcXVjRnNCU3ZM?= =?utf-8?B?K0g2azlWSWg5bUFXNjdwOUs1Vlp6RFh4dDFDazJCNmdBRk1UNjhyU3JNa2NH?= =?utf-8?Q?AIt2efQ+sYodo3nC08NV?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR12MB1149; 6:wRIJaemFPymwj/xFqOZO+iqX7nJb3xm6YbV5qwASNgdQG3dQ0zgoi4Y8Wey5MFWNzvOmJ1PW5CAZO6ZazgMYOSFmwjq+rCsllXIN75YMezE7YMHxyzzKQ4w+8aniRCE7D795e2HScTQcf1tU8VPf5I/Ei33/t5QYHl9w+UbU7HLOrkKRLgR2Ohlhbbj59vmfeQLO69aO9/RkdypPxpUb1K/fm3xfkapGnLGfoiqXwemrEPwS/8wOMHe3dNpBX85dhA8SdOwJYlgLEVaV7t/M47Jaf79FdINU8ianqQzdxMDMKuHqJsq74qvoYs5Fn8Y1XYozeeS/IOJw1BwHttmnEoJs4hJHWMlRxrw7jy1BuY0FSUA1Mq+Ep9S/QFn2zy4F; 5:F1WOr7LMPa4Byxa+X6soKqGoyA6cDhqgKWDsAz7+L46pYmKks5HD2OINYjPPrClzod8lOI3TxPNlK+GCLDYvNvKX04ACjWYTzAkWvn9xKD2Xb07GYm7rfVveJyfWfOPHz+Td8ApCeJ84qZgrnzCUjHpZEy0X+OIoUqxwAxwPtX8=; 24:/iF3kTYTU2/qfGG1r5Y83BMVoQQ2D31o7UQSB5kFtYYZqPXmYBC3XA1COrfajHp2qQE70Gc1poIGo4FpYdsjP+pUjkRy6t4pJtm84X299wk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; MWHPR12MB1149; 7:74Sk2v7fDhJeDGzzW9SaBF+Py8dUanczjuLyyIhmFwWLVbfTBpiJ7v2QE/Hymdsijgb+zELMKF0QDN3kkb0COs5leRVqzu/qkli/xqLk5BUtEUJw5mJVBfGd+Tdm7eKqmicuJqVFrox9ffB3NvXENaGqp+YBCg65haNq/Dcg5oxEANgKvfwqSxZNyM6xHXi5ZZtvSrfFVlpYY3yBRAdOP1zGJHCLc4xhp1ievDdkt92HPZ7xpw/dGOtsc9Q7y4b+bEmfyA8CvTILsw7uP6JWAzpgdos2Qs6BLEaakS02y/04ctUt/qKkzllODdLhe8gUs1ca/DRqMcERUEB4mHsA3Trv4wTIsZQHlwpmOIgGyxY=; 20:AmulBKkcPCXzlG0oIkUmPYsQlDEcfVNxUEONquRPp5PV5AYWsMsgxA3WGn2iaX4zcqjzaRR83qBgnGzaLz03e9Ms55lCYRfSsactZhdlI6HgNy/wqyVYYnP1Wlm2hheI7SngBzs93hyfJETxFOfdIJOZclVjPOXfNcy8QuaPuXgOFIzcNS8ZCrEODpzsZ9jbf7sOO0KMIkQWXicqI5i31Un5jmbvt7X2VCqb1m0Zbd5Y0AGFoQSEJJEbW9lUHsDP X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2016 22:11:09.1274 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1149 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The debugfs support in the driver uses a common routine to write the debugfs values. In this routine, if the input file position is non-zero then the write routine will not return an error and an output parameter will not have been set. Because an error isn't returned an uninitialized value will be written into a register. Fix the common write routine to return an error if the input file position is non-zero, which will propagate back to the caller. Reported-by: Dan Carpenter Signed-off-by: Tom Lendacky --- drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c b/drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c index 0c0140d..7546b66 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c @@ -153,7 +153,7 @@ static ssize_t xgbe_common_write(const char __user *buffer, size_t count, int ret; if (*ppos != 0) - return 0; + return -EINVAL; if (count >= sizeof(workarea)) return -ENOSPC;