From patchwork Mon Nov 14 22:39:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Lendacky X-Patchwork-Id: 694753 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3tHlnP2HmJz9rxm for ; Tue, 15 Nov 2016 09:39:21 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="sRR/dHGV"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941093AbcKNWjR (ORCPT ); Mon, 14 Nov 2016 17:39:17 -0500 Received: from mail-bl2nam02on0046.outbound.protection.outlook.com ([104.47.38.46]:7872 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933841AbcKNWjO (ORCPT ); Mon, 14 Nov 2016 17:39:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NdonXNL9BReht1xpp7uDCFLVOGoAsSztXWlhVdrEYvo=; b=sRR/dHGViYBq/X4h/BzrTOvQYxVZ15JRuBM4O04vTvTatGLXfefgbP7PJ1UVU4JpgrQwXWOObVXRBfNOJ2bztKVuz4+rle3j8b1jFuQXMqyENotLqVH5vfpjDs3b/eSLTrxeIsY37cHkqIb7kxwcrr3dcFhtRAQLX9mhbtPLdSk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Received: from tlendack-t1.amdoffice.net (165.204.77.1) by CY4PR12MB1141.namprd12.prod.outlook.com (10.168.163.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.707.6; Mon, 14 Nov 2016 22:39:10 +0000 From: Tom Lendacky Subject: [PATCH net-next v2 1/2] amd-xgbe: Fix mask appliciation for Clause 37 register To: CC: , , David Miller Date: Mon, 14 Nov 2016 16:39:07 -0600 Message-ID: <20161114223907.25437.50884.stgit@tlendack-t1.amdoffice.net> In-Reply-To: <20161114223856.25437.13649.stgit@tlendack-t1.amdoffice.net> References: <20161114223856.25437.13649.stgit@tlendack-t1.amdoffice.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: DM5PR15CA0019.namprd15.prod.outlook.com (10.173.207.157) To CY4PR12MB1141.namprd12.prod.outlook.com (10.168.163.149) X-Microsoft-Exchange-Diagnostics: 1; CY4PR12MB1141; 2:TyJogz1BbqnPi/gOdHtrdEZxALOt9f7qFb5YieTRyjtt9H0nv0VtbWncJXgcTPKTEbaQ/9kQIST2h1VGYGe5xm677+SMOSWs3lIqPMAAKHRXwc02JMp3XpFZWACfDxUsIBDcd3bi/nOdvCCBNttbPQ2zmY6pQDPpNije878CtCM=; 3:2hABFJ9mwiNofxGhc3XMB7vTO4QBWsua+kCQpTA+pjjvzxZ6dD3MCDLHcS2zwf4AZ+s7fcP7usn0SXcgi4DScIQ0nV8fg5qpy/t1XFC502b4lTZsZYxVnV4EeTkRXHEVwdF5ELrxf+7kWls1A/V4OBOEo0rnKwj+cncxsdcok04=; 25:1WH/GfxxjiYNIn4xZza431vKQtepJPRVeEHcW175HBESQqPedhGSpgnfOVwi0f1bFGjX+WdEFVlswi/+VghZN4If/jL0d7BPmt5jNKffdo6tUV/Ui0GYYzWUP+jqn+PwGj9FMm+ydS5jtgM8JX78FmEYTMz5hSyYBxUpUc2d0d2BGPNxrTWUgEkkJKvVkJPmSyKyjQ6HSaQn01cIanDVNWD6xITv/8QToT6X5ENYL6+TaMbwE4Tw7tPqWIUUsxKqmJQsbMm9kUlu+/ezSfegBDc+55Hc11GbflWbrI6JVUMtZs6/gYE6jsJATqKiMXYvBwAJHE7vbMJAb1T0Ptex0O8a4PUhgo46qId4TlRkKPGldm8FLvSEN3r9EG9m2eBDLafwFtImmCtKqtZTC2TZDdaLfTw1Rlr+3PFxHBNeJFutMrYfuuKgqw9jAuQ2OECB X-MS-Office365-Filtering-Correlation-Id: 3e58e833-1514-4bd7-f698-08d40cdf0d44 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:CY4PR12MB1141; X-Microsoft-Exchange-Diagnostics: 1; CY4PR12MB1141; 31:3OT2UR1PUCJKlKwtBPonT/9j+hStn0JuchHNW9OF57q9UwGAcSSdnv76FLVcMlAW6z3YI4l55tf/a9K4sQTx2obBPOVduME+Upbyddudl28aajVUMLf1+Bup39Lu9PGGLL3j2UznC7usG5eRNMROVbdy7nt8P0PsPNQyKK1FHWh4+bjKvRSQz1DsAxMUvPMDK3oPV8QJc1dHVNKYzMOge/xQLmXLAflX03oitNR3VomSGiSWztkEQ7G+Tw6My7Wvk2SKx6oSiZVWGvjr2JK+UxrdgYidgdMz6s6DCjJXdco=; 20:8smEitCpshSTEYPRZM9A/1i4s+GR4ckI5rUNIj23Rn/tgKbH+txG+T/c4Qn5it7XRUKR8lWlw4mvJFpTuuMI5goHqxsAbl9Bs79sEEPVePdwNRC3Ixjul6yJNajq+1rkuhjaAsUsDjiqZmoOKsoSZwVT2KDzPPflM94zOsxgYjmWyTfDgZhL3uQdoBkLUZoztwEIjWBQNx1C6w1wB645Y0oNti/OjqhK+KJQY7BdWavHYSW7rr/i2iv4BR47tBH/wgIfEvWVsNwvg1BVq/u0wPknEZjgShxnJXzH19ENhVT6jnjQONkuEEIbD+dJZVawzyPutY82jxz6FMdX7JrQCNTMz2q+Lrt/61rZ1+z/6EAufWkMMP8u/EVJMBTca60j5vUgo2zyXK1e0EV9HUZJpCLlkO8DyM3Rtx5FqiRBCWtD+5eloYQi7fu0cGG9WsdMXS5kLP4Tny65fQqY+Wj7MYkLyS6IjpqAu8fe6q1KjCQhjQSGf4IvtXbpdYhQ8SFG X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110)(155761271638844); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6060326)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6061324); SRVR:CY4PR12MB1141; BCL:0; PCL:0; RULEID:; SRVR:CY4PR12MB1141; X-Microsoft-Exchange-Diagnostics: 1; CY4PR12MB1141; 4:iFPf4Ft9OnteRVZBtmPskdOjT0RNTeGuIQeIGAma/L84MY5h8VlzGCe3cERf4bwV+Sc1MS+NjT0GQWdTw90MArmTMtdfGh23/Wqm1ziPtkvR5aFhxi0SmeBqYWqG2pNT9burEazK/YMRH+2RHKE81USxFx+sGDKdi1i1NTV0yclIZCx3DDehjZoAFCMo5BX0FvUqrDhloM0ZhwMdIcVEHCPNfQoWyEnAuzE3Jbe/Q+JejrFq27lRrgtxilIR3SacpHwWLf2aHSHCsKuR/egX+0X+tPNPrqpJNEm0dRw4VEz8Neo2L5sefUGNHFeVUuZqbOW4qERkV5fn5tJLXQ7jNqctLHv7WOfLePbGsB8556T1FSNv3VGmGmVB5iGlxsSx98lXJBgEBspxfkPu1adRJiQT+z2rbDrN3aERFvAb0AlDRuCt3WsRqKcBVBF4oAXJQlG2z14XyIxS9xTqi7ojrb+aSNc91RMmDtIjTgPcbjRutS0lpMhIoKhZjnBdO0tz X-Forefront-PRVS: 0126A32F74 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(199003)(83506001)(105586002)(8676002)(9686002)(103116003)(53416004)(92566002)(110136003)(66066001)(42186005)(97746001)(47776003)(6116002)(2351001)(189998001)(3846002)(33646002)(6916009)(81166006)(68736007)(23676002)(2950100002)(2906002)(7736002)(230700001)(4001350100001)(76176999)(101416001)(81156014)(54356999)(305945005)(1076002)(106356001)(50986999)(5660300001)(97736004)(7846002)(6666003)(4326007)(69596002)(86362001)(50466002)(77096005)(71626007); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR12MB1141; H:tlendack-t1.amdoffice.net; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjEyTUIxMTQxOzIzOjg3QXFKMjhuL1NFTWd0SnNPMnd2MFZ1ZTF1?= =?utf-8?B?NmwzaDJMOUhBRXZ3SmlwdkJRalhQQnQwck5hY3p0cTFXVkxZSENqdnRTRUJR?= =?utf-8?B?emR3S1NxSWZTc1JlTm4vUTNmOFpqaDgxQUI1QmEvUFlUMHdhK1NoMnB1aFN5?= =?utf-8?B?Y3lNOEQ3d1dpWFhUTzhGaFZkcG9PNWJDSldlZkoyUDZxVW1kK3NXREdPdWhy?= =?utf-8?B?UVBQWGhrb0MvM2ltMjF4c0FOUi9obTZTTGR6QzY0WHVDVkN4WHpQalQ5amNu?= =?utf-8?B?TzZHVmdMZUYvYy9rdi9UaGFvMTMrRmtxWFNwL2ppN281dTRFWGlHUGdaUCs5?= =?utf-8?B?N1hCYmtzRzBQN0s0MmhuRXJYZFdDaFpGbXNKVG9kNkh6cDlXZm9sN0tOejhP?= =?utf-8?B?WGhDcURDMWNLRnFCTm9CYjZiZWJBZHRka0NmTStxQWk4TnBSL1JtVC9aNHVt?= =?utf-8?B?dlFibHEvUW1abW9wOEZoc201RE9DNTRPc21CcWNWTmg5ekpQdEFtN0E3eFFq?= =?utf-8?B?SUg0YWNIanEzZjFsSUNuY0ZMSnIrUzlZTWs3aVNST3ExUmVvc1A0L0YvTW9v?= =?utf-8?B?Rk43YnhhYjYwTDNaNnZTeEJsVXMzVVZwREVHU1JxbjF3UXNPRS8zVllORThi?= =?utf-8?B?aDVGTnQ1cnJtRkZCeEs3S3NGUGxwZ1ppVk1Gd3JnZmprNEJMeWY2WEp5d2JF?= =?utf-8?B?NUxUS3g0Qmtsa2xubFhKd0o5ZzErTEs0NUZLS2JOb2lUaUZiYXdONW82c01q?= =?utf-8?B?WEo0WmNZMjJUSVI5dEdTV3FRK0E0a0NjcFQyN0M1MS9qMnVhWlJyWVhLQmJr?= =?utf-8?B?Rjl5dk5NcCt2MnJjeTFETTNPN2s1V2pSU0czdmZ3b0oxaFZyUE9ERStmbFp6?= =?utf-8?B?eXRkQVR1bzBRSUhFSGRMck0wRE5nc2R2QkJ0czJRUHJ3YjlvWm1Qb3BHZ0ow?= =?utf-8?B?dUYwMG5aRGIyOE1vbFh2UmlHME5nY2NrdW41QnBmamdkcnFKZyt1ZGFHNkhW?= =?utf-8?B?UkRUVlVjSGZEZDcvSXcwMjJYTVY3dkRKT29FeGtJTHdEdWFFa3dwWGtHdFhS?= =?utf-8?B?OVdKeXBYUlc0c3lWNzJ0ejBwVmU5QWluUFFnQVp4Lyt3QWMzYU9taThEenkz?= =?utf-8?B?MFFNN0w1alQ1dVIvZXJEYXVNRWhQRktZc2xhbzVSRmdicDVvMXdYVWs3TTdv?= =?utf-8?B?bGtmQVZ1NUQ4OXZpT05ZS2dBSGVGQnVORmRsRHJSdEl3aG9rVFZ5b1FtYnpy?= =?utf-8?B?dmhNTzIvK1BDTE5jNVNZUGZZRzhRZDVPUEFMajRwLzBUOUZ5cFBmRndydU9s?= =?utf-8?B?WEVCOXdqRFFIUU5VckZVOVhmUnhCamZpVzZqNkdLbmNpTFVMb2prNWQ0blBM?= =?utf-8?B?SlJKMjY2b2VPWGI1NC94a240bEdFUHM5SHJ3UUF1cncvOG1vYVFyclV2SS9V?= =?utf-8?B?TFFkMGM5a1d6R0RpM0tZQVVOdVU2Q3VvNjlYSG80Y2tCTlNqMVBlOHptM2lh?= =?utf-8?B?dm94S1hMYzBvcXRIdTlrUE5RL20rUWFPUGVRektqWEJJd1N4dXBmU1E0eXgw?= =?utf-8?B?SW1wdGhIeHdFSTB1dXVlaTN0WlB6Mk14L2tnRmloZ1NrWWpnb2lSaXNoUUla?= =?utf-8?Q?Mdzjhfq9ea/b2Oc1ftba?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR12MB1141; 6:1Jx/hjD2DPTudA8kIzN/JqXFmJDrPgFitZqfcARJKCpA8Rm9RKJocioGSr+V5GSyGGIG+G83bBVRY+I4Gx2ZWbc+/GKKkPj7ylv8avZ1WgLBDYW1MZBrdbdp+c0BzDb4kUYztefLPqP9G2yx93Z6KjP70O+hF0hhY0bt/pjeMhttS4O6dXvIrB2aaFV1ROr6iMV8NX5jyHGhxMeGSM5KviU/rE23Idqp9q62pKwJSD2o0k1Uv+AHoCRQAFDtTsWuS6rZ7sO4F2wNnl5s27nTrybKciQeLKn4eghfSTH0xnLlzfIMH4e1XHoETKShlA14Zpg+a4K8Z5InmEyTG1opYhj0en0uzRB3n8cDkmgCtC5kR29r/Oainc3mxFG42Jbk; 5:WBniXF1mtlQjb1Xfl5AMTt+Nri5ij+l1l5AxB4jT41QvuS9SseKMk0XU+6PFWOpKjD6teMqQGFNegR/uXc7E0b25FirveYfqrp3NyrtvTiQEKW14AVpuVutHD01GxczU6Rzitmur0TCgBA782kvrRw==; 24:BRcas0hDK4ZBoyEBxGuYUSVVwqeZvEk8suZYyvZLBWcxTJvUhR+abCPbnPwqCogqovVRrEMIQ3xooGVzcTsF2cYYQB25Cy9s4A2EcCAuFEY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR12MB1141; 7:w3afR6RGKnWeEXdH1cAydAXflZVrMH3W5w+x5GLxWoMDvi/l51/T04Hpx//JmZ4usaUoYLej51NMVYZ0JTD1eqW4MN5X+Evy7nyMe/FyIlKBj0vPw5B8RuB8lswbbyTdENtDH3vzqDFoi8AYuu5D7//1ZeBgwhxoJzhQByfUaapysIr5o7dIiO7hPzuJ/6oc8HG6SwZlHLC7h76UumJStU/V6CnTnrjhZfrpwV/oGcK9XKv5tW8acVPAwG4oDH0vOpGK5pNfJ7pQ+lBkSd/MFjVq6lFgO7gTOUJ5t02upxlZakWVykHHnDc9VscvaUka7bkCDhN4+dikelBhYoetdOnw1uJBe0M+fx9DLWuf9Jk=; 20:rb1FtFCXCQO6kVK2PrkarmsKWL9tKyrE9ArOPyQatdUu6VRTeYVscFk/aeofYMcLT3sWT2NFQQ7E9bQnK8bsjkKK5Nm0k/QBEzvL6wDIeejPEljNq2TraijHHkeAZ2kdiyCxKYoEjNSAtRZsaIuvBHfRYt8YWW9mQzrVuapedOpieiEZm/4Moi2IqKrhXkKMWyJbQob7dbypqrVnMOmaUEOjtz//YvBCndwsFTHsu3AhoFp9tMpI+LUegEAdj0Tc X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2016 22:39:10.3354 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1141 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The application of a mask to clear an area of a clause 37 register value was not properly applied. Update the code to do the proper application of the mask. Reported-by: Marion & Christophe JAILLET Signed-off-by: Tom Lendacky --- drivers/net/ethernet/amd/xgbe/xgbe-mdio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c index 0ecae70..4c5b90e 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c @@ -943,8 +943,8 @@ static void xgbe_an37_init(struct xgbe_prv_data *pdata) /* Set up the Control register */ reg = XMDIO_READ(pdata, MDIO_MMD_VEND2, MDIO_VEND2_AN_CTRL); - reg &= XGBE_AN_CL37_TX_CONFIG_MASK; - reg &= XGBE_AN_CL37_PCS_MODE_MASK; + reg &= ~XGBE_AN_CL37_TX_CONFIG_MASK; + reg &= ~XGBE_AN_CL37_PCS_MODE_MASK; switch (pdata->an_mode) { case XGBE_AN_MODE_CL37: