From patchwork Mon Nov 14 22:28:49 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Lendacky X-Patchwork-Id: 694750 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3tHlYY685fz9t0Z for ; Tue, 15 Nov 2016 09:29:05 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="eVHyP8gX"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965184AbcKNW3B (ORCPT ); Mon, 14 Nov 2016 17:29:01 -0500 Received: from mail-bn3nam01on0054.outbound.protection.outlook.com ([104.47.33.54]:59811 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S941060AbcKNW24 (ORCPT ); Mon, 14 Nov 2016 17:28:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NdonXNL9BReht1xpp7uDCFLVOGoAsSztXWlhVdrEYvo=; b=eVHyP8gX3VmLIbIGkigF034al7OLH0wi1Wk0lzz7lE6S+Nu9hgCYevI3UfZ2YdWnn5EhLYMSh4i2HmRJKJHB37TcrlycdArHBRI5ymG/tkKmob9YwuLH7Xbx/hqSfbZntzIbcSm28p9OotFkQE05ibKob5YZ4k5oyEG/EkjHod0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Received: from tlendack-t1.amdoffice.net (165.204.77.1) by DM5PR12MB1148.namprd12.prod.outlook.com (10.168.236.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.707.6; Mon, 14 Nov 2016 22:28:52 +0000 From: Tom Lendacky Subject: [PATCH 1/2] amd-xgbe: Fix mask appliciation for Clause 37 register To: CC: , , David Miller Date: Mon, 14 Nov 2016 16:28:49 -0600 Message-ID: <20161114222849.25160.71951.stgit@tlendack-t1.amdoffice.net> In-Reply-To: <20161114222827.25160.24791.stgit@tlendack-t1.amdoffice.net> References: <20161114222827.25160.24791.stgit@tlendack-t1.amdoffice.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: CY1PR14CA0012.namprd14.prod.outlook.com (10.163.13.150) To DM5PR12MB1148.namprd12.prod.outlook.com (10.168.236.143) X-Microsoft-Exchange-Diagnostics: 1; DM5PR12MB1148; 2:y6mePxMMB+r3I9JGOKjGovyeUkuIqgAVr7dh6xgKdXO2YjE4zEJb2/bVd7zDRPljKty/cTHXaQLXX2U4pN29Oe/HH1mhJ/CHAhw7xWbghhXXvt6uJPwZTywgrdnQh7n1o9Weu1nVP1nQx6HUhny/av+Xce5NKjdtEq08Ot6e1tg=; 3:f4oZmB3+X2oRUJJvgH4xDGntGPU3op0h0uXniEqChG3WoIp0TL6a1p2jg2WiBEH8RFnrKRcHJSvNDN0F+8x6/WqgXI7UO1nkMy/akWh9aUqfDFU2zF9cV/NBN8i5t2REKv3EQMpbsd1ku6UkMQOT/D/NZCDhEZHUJMUyXvpO0iI= X-MS-Office365-Filtering-Correlation-Id: b48d3392-6398-4bcc-c1ec-08d40cdd9d06 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:DM5PR12MB1148; X-Microsoft-Exchange-Diagnostics: 1; DM5PR12MB1148; 25:KBNqNjIcyqxZ7dLDdjtMRWRTUvXzN9YtsiZpCCRPEjTKWDkMqEwRlC8m/6jBriLCZzyGDsuzNlp3NmN7wNY9OjIY5DWNTgASuxaU8tW1k3700dwzXrTqxHxUobbbEUKPZG7nKHdGQUql2DpsN/ZfGmWIHxXtJPa5Zj9bS8xSBEfhFqmUSP2sBMKochdh8CuGZHyaIZW2FNlnJMt/yrEjir7OF4yVR5BtteDRJA+PvKKkOOIhFpkRbtsIqYYsG+6qIC6yYY6Y1D7zcb3N2b81KLDaJGKhFxmB5MUevyb8ZS9H8Tw4Pp66D7bFRR24Yo58CNsSck0cFaAhnydzdR3t92G6IeqRDEmStr49zVx6H3dXAtKGp1AMzaKoVxnTWa480zGUy6Pe+PGTaPxmHbecyuPub8Y2AA1XzyFmTe8ax+SinCKtiTuwOKcjgaCd4wo2IVJPYz0WH2vk7CLAo/1L5RqDm+44kzZ7L6lSra8qSmJB0n3iAVSVMXjF+6IHdNrDJvnL8/pk2CH8D4l62gNQC307ktMJgGvNLqNT3yu5S8Mx6kaCdg16dAYwjhdGqLB0iEjjxlia4YopJ6zAOI+WrNLhl1vcjPaWTjN6zmzNpnPODpzN5CoD6Xsrgi1fibZLY+m+dKuPBFiw/finp7vitRtQuEckf1+Ykd7aetaey+OAo06dbWAry1HOr6mUAMSUTmu1cCyRbUlij2OhFRXMbypl+tje99EnPawWhVrAvo8= X-Microsoft-Exchange-Diagnostics: 1; DM5PR12MB1148; 31:rSCWWDUI3bnP8Vgsamb05E2gJEfHvTbe7Dbr+3RVtySfr8XAj3JSWLg3QqM75eTG9zl7Zs2YzpqkS/MMHU7NsRJ1jc7IwLmbzDEUrWrQS0kGVz2iqt6Typh3yrtEOmvmUqWW0+wAuirD2xmgi+GOf+sPVgQv+NuLzvfSOelTX0KXGmg6qzsbtPo/90CalbNV84+3c5G71JgPJmFbR+fhmOWS9aT7VM6mylj0ci0b4CGJ/XJ91rCzJfc328ZPybQb; 20:iMbwkJLJmTGsoS2/YYtj8ROok+Bv2X9nObb8A2BB40swQZBa0Aaw1OvnT3mclCVuer/BhNvk+XLfmb9kQ7niP0truMECuydxWGW3OoMQJqbfymvwB6UFUBqohU8nVp0VWpA6ipUMEKv8Fo7G34Ox1M0yCq0ELgUsf7x7E5dhhvq4nuQvv/Ddjw4nvbuhWmlDxGOXyJ2/dsAP6r5asCx8KcBK6fRxPkhHX5ON1e9l/IieXCYc821SkE3ubXOl9D9XEE8laKNsAuuuBj8SilKxxQ26oDwcRM2ZGF96/7yF2l/qsJO26c/eVBLbs7H/KXSGOXAENhp8NiP6ZVL2WwJB+LjVa51RcKIZSMUJBMSMcYQoIWoMSwTnzLA9K7Rt9kC2Si92HR2DxGcF4ktSe+s7aGxOk9PIV/KVoHtUithTP6cWEdnkiesR1iD4K/0z9F6koKUL55qgswCPH1s7IJA3b5M+m4TWi0qLS57P6+hJStC58OCaZiaZYUaRIpVxC8Cc X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110)(155761271638844); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6060326)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6061324); SRVR:DM5PR12MB1148; BCL:0; PCL:0; RULEID:; SRVR:DM5PR12MB1148; X-Microsoft-Exchange-Diagnostics: 1; DM5PR12MB1148; 4:hWe/9Ii4Snv/rB+kLszlhxL+K4uim2YMj5ccbTKWaATLMwHQw/ZeYKoz6B0meiuB5q/zuoRLRTTvPJzoCWTxtSqNRweRRlLq+Tryp91kj629Is38j7wM+K4uwbeWmzoYPffj+9Tu5D0mXe+SRbnooIVEGXM0tK0I/H8BsmJRSStCftv8e45gP9kqF6vrESAOH2zDGFE5OVdkxE0K26sQy0gn351pOrvQtTpUfP3qv9Zn3vpE07nJydtIQjYGNpJ1SuxrMHJyhlAltc3AhQ2Kz3DK3WEJ0d6m41zQ0KistkZb6cLBMpvFAkI4aKCBk0CBEo5D0js2iXGoDNKNvWeAtdzUDfFslulhJpr6eaV2Dti/NXodx8D+zxaTQFXkgzc/1JBD4epUcK7ihEZaEJdz/m2ufCpj55slTXZ3rfqA7SOLwMUh3YvbYXiaw0aXnmgdsTc/ZajJfu2H1LtgzMGdykePOQmfnP362AXgEhJ/p5fPHieqLWBWqZoPmfTBi9Qy X-Forefront-PRVS: 0126A32F74 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(199003)(81166006)(230700001)(9686002)(81156014)(42186005)(8676002)(47776003)(4326007)(83506001)(189998001)(1076002)(105586002)(92566002)(3846002)(6666003)(6116002)(68736007)(66066001)(2351001)(53416004)(2906002)(106356001)(2950100002)(33646002)(103116003)(7736002)(23676002)(7846002)(50986999)(101416001)(76176999)(54356999)(50466002)(86362001)(4001350100001)(305945005)(77096005)(69596002)(5660300001)(97736004)(97746001)(110136003)(6916009)(71626007); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR12MB1148; H:tlendack-t1.amdoffice.net; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjEyTUIxMTQ4OzIzOjBaM2ZkNkRJTGJSRXY4Tkg0Z1hMM2VzRW5K?= =?utf-8?B?dzNpN01QTEdybUVXNWpGZEhNbUV4SE12d1VrTlhPTksyeW81VXJpTmQzTWhE?= =?utf-8?B?Ly9SWE9vQlBCdUVVcmxBUmYxVEtWMThHQzlYNkljRW1ra1R0WUU0cFFpVzB6?= =?utf-8?B?UWFKUDQ2SjZseHNMV3F5b01YUERUbTd6SnJZMXlVeXpPNExNSnZIYjVGNURP?= =?utf-8?B?c0sxNzZ1MEUycHdYeGJ6Mk1uQzFObE1zSHFramJWSTNLMnJTSURRQnBHVWk4?= =?utf-8?B?Yi9ZR2IzRWNqQ2FVcytvV3NYRnFuQ2NOaU4ra2RhQkZtYUxRL1BSWU1JbWJs?= =?utf-8?B?MVkybGxLa0JYd3h5ZE5lLzJJWG5NRUJ1ZkdpODhUMlRPVVlIQUR6TnpYRk81?= =?utf-8?B?bU5ueFQzbzUrRzJ2bVNZMnJXQlJ2QnlqWnZSdHI3WkZYS3llM1dtclpKb21L?= =?utf-8?B?Z2pTSkt3U3IyWGU5eUc0M1h0VVk1cmJ0ZU9rVE9MRWorZDh2MHB3SGMzZXpE?= =?utf-8?B?UU13NGpvTk9UVCtIc0VsL3pjdDVxZnlKY3FHTmFxS1pTamxzMkxHaTJUNHUx?= =?utf-8?B?bkNVSldXREZtNTQ5SDR2YllIRkxnU0JOV3YxZk9yQXF0c2FKZUZpQ2FienRo?= =?utf-8?B?UTBlSWYwaFRkNSs4OWVEWDZma2FMTWZxZWhGZ3RwWDJvREZlT09qUnBrQ2ZX?= =?utf-8?B?UDhweE8xdisxVUtlb0lSdkYxcWtFenBwQ3FBS2lIUWErcUgwb3B3VXJVVWg2?= =?utf-8?B?NFQ4R0tTT0NyRkhmYVZacUFOUWJEZDB2Z1BEYmRKYmQ3ekRwR3BZL3RGYzRr?= =?utf-8?B?eWJwZmZyNmp6SjFDNGRZZ2grdEVUS1lRcWVIbHdRZUtScUk1QlpLZGZnWnlQ?= =?utf-8?B?Kzl6TEZNcm1wbzZOTkt2TzI3MUJJdmN5QWtQVVJobmZXa25pY2FZa0pQUkxK?= =?utf-8?B?OWxONnBTNTI3ZEgyWnNWbXUvK0ExOGJtMjFpRHdmeWcyTTFrMXdMUWpJNnJy?= =?utf-8?B?bzR5aFFjL3RsUDM3dkJkSUJRcGQ5VWdnZHpJZXZGTG1qV2VNVXBGTzdGM3FO?= =?utf-8?B?VjhOdld6MGQ1U2xQZS9PU25yTk9kRHdUT3RGY0d6eHQ0enJPRzBNajE4TlhH?= =?utf-8?B?eDdsVmdlSkRzMUthem92bDBqMWtpM2IwN0hxM001amhQZlpJUkNycXp0K1dE?= =?utf-8?B?N05WWS9iNi9TWmY2akhZU3l3Q1RkOTVBNCs2ZFh4NkpMSEZ5Zjc4dmZVRnJp?= =?utf-8?B?TVpINXk4bitOOUt1eE5HN3UweXZnRjg4eWZ1aG9BK3lNV2NXVlkySmVXTDAz?= =?utf-8?B?M1FaRis0d3Q1M2JoeHlOQlJQUTRJaDlwUGVQQm1IMWxoZFd1dHBzdFF6WW9z?= =?utf-8?B?QlN0VENMcjE4REwrMjBkUFROWXROQ0dlRGVzOFVGN2hWQ2k5bUZGM2RMczZ4?= =?utf-8?B?ZmlQaStxVy94Q2MzWTZ1YXUvT3kwTnZteXFYMmpuR1FNNThlUURNaVVzRC9D?= =?utf-8?B?N1RKU2ZtWUhQUk4zekc0dVk3TjVWdEU3bnZPc2g0R2h6R1VqOVhGOVloY2VN?= =?utf-8?B?eW1iQmd4M1ZCNzREbTV4Z21xL2NhekR4ZEJnMXI5dEFEU0ZycXE5eUttaXFm?= =?utf-8?Q?eotrQmDSGiTJjK0cZbqa?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR12MB1148; 6:os7rwIidDnFCvMUN8cAeecLaxBu93Fwrrl/boQWdJcn3ybw50uGxdzF6tkOWSM7BHdWSLfr5BEH2bQ7S8GbsZqHHHF8Lg678m91oRx6OTjWR3tGsUfin8V1VnnFwB2x/eovyuc3MJip1fHLZ3OOr6ePn88RNCS7rPcVwHNo9SmOlmI08zwHsYx+8Qu4srNvSBgy5hPPJ89qPkxgreImHkFf04SA+iIqIRLGXuvdIENogPCfaeeBOrRT/5+bDMgRCMONrjJJpzDaTezFlgl380jX1eVz7T840AvZnOcsXczyVOWMOE6DFKz+rYnvay9ShCAPXfN+cqYVQ1gRzditf8Gr7Ar/TsMs7NjvcHCl79po4joBBzTcyrqx1TejQYGMj; 5:qC6wbYy72l4MnXJ/vmHyHHtOk2FXJFyw2JN4VY2YrI6vwreBWnO4nkQ1Jd3DqD+P7auIZxBaWpXPZulBNF7iPvQE+PxvyQUaWiGM68PLSsMW0eBjzt4aNPRPFVIO8tEFRAUyb6wsTpbBo3Mmx7nl1g==; 24:mnTyu1uTU9ew2+7jM1PcVPYUE5ZFkjZHK0Cjcwvw33Ydi2bxgf2nvT3wc9oVTF5Z8c2gIT288GcERX5jpX1fKk8gckMeO0dqUv7PPKkRH+A= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR12MB1148; 7:5R4h8Eqr96AZkoPEjrTviJd6OO8cagAr5z9RzJ+CrSnRMpCpf3LNCy//dvT2EnH/q+thgwvcALke1DfTE6ECND5aym32LYj5xXgUNaeNnj1eB3HnUIKtvsvUPNQAcJQ3ltUi4r2W6rmn8IXi/Gv1Crq+5U0/DUjdNQ2mpx8FA7P2MIS+lMNJNXcJFsPTQz/O99+X7zG+9Qr7X+nz+hGa8pIPkx24i1SOPIdCvkHk6EDHdOVBqeO31qzdtnzZkWzKLD4NFh4r7v+f6DojmWlAsEJ9niYAtJTIzajraz4fEAz84EyJFmU+3NiQ3I6C3ZmlUrXI8Gt54S3lWjaNMczGGMXzLI21cFEjalNJnxmxT4c=; 20:K92+UwUGH5cds38I2X7Pmej10TQOfgOH2p4k9PTAErqkxPRyztXgpSrdIPX6yPT9eVGlLHVEMzDoEGctiVzvPrBdK26+kpNY9f+PdVk5mEOh71KyuqHywVHJ8KgskvCsvsfFQUWPqVH03nKNh9WiuOzccqLyMyFvxQE76QwQ+8cHQTBLTb/ou6aO6/d46PMDLO03qqaCOO87/lSrOk7SFadUjcNv9hIJTPOJz5TzIxZtpBpsz9lRxHzn282CA3yY X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2016 22:28:52.4671 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1148 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The application of a mask to clear an area of a clause 37 register value was not properly applied. Update the code to do the proper application of the mask. Reported-by: Marion & Christophe JAILLET Signed-off-by: Tom Lendacky --- drivers/net/ethernet/amd/xgbe/xgbe-mdio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c index 0ecae70..4c5b90e 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c @@ -943,8 +943,8 @@ static void xgbe_an37_init(struct xgbe_prv_data *pdata) /* Set up the Control register */ reg = XMDIO_READ(pdata, MDIO_MMD_VEND2, MDIO_VEND2_AN_CTRL); - reg &= XGBE_AN_CL37_TX_CONFIG_MASK; - reg &= XGBE_AN_CL37_PCS_MODE_MASK; + reg &= ~XGBE_AN_CL37_TX_CONFIG_MASK; + reg &= ~XGBE_AN_CL37_PCS_MODE_MASK; switch (pdata->an_mode) { case XGBE_AN_MODE_CL37: