From patchwork Fri Oct 14 08:07:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Trippelsdorf X-Patchwork-Id: 682159 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3swKvk0NHzz9s9x for ; Fri, 14 Oct 2016 19:07:30 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=trippelsdorf.de header.i=@trippelsdorf.de header.b=qomBJrVq; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753924AbcJNIHZ (ORCPT ); Fri, 14 Oct 2016 04:07:25 -0400 Received: from ud10.udmedia.de ([194.117.254.50]:56348 "EHLO mail.ud10.udmedia.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752463AbcJNIHU (ORCPT ); Fri, 14 Oct 2016 04:07:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=trippelsdorf.de; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=k1; bh=KI52B9Ra7bL9akL+q1rnY5Ce1rpA JBMAmAWVXIAUoAI=; b=qomBJrVqzGnkx4Asta1HuZMdO8bM/JYRUJiASuZ1jVbf caMYlS/JkrHUSYyfmsHhSDTUuyppMH2V8FjhO3qWJM8zZUbP5L+7GNQi+MmIKdP/ g4i+CFA4FUuLTdkzWvlcmbzfmiExa1bJScAjHkjLVhBdQIThfIYhcS5IXFW8kIE= Received: (qmail 25704 invoked from network); 14 Oct 2016 10:07:16 +0200 Received: from ip5b405f78.dynamic.kabel-deutschland.de (HELO x4) (ud10?360p3@91.64.95.120) by mail.ud10.udmedia.de with ESMTPSA (ECDHE-RSA-AES256-SHA encrypted, authenticated); 14 Oct 2016 10:07:16 +0200 Date: Fri, 14 Oct 2016 10:07:16 +0200 From: Markus Trippelsdorf To: Eric Dumazet Cc: Neal Cardwell , netdev@vger.kernel.org Subject: Re: [PATCH trivial] net: add bbr to config DEFAULT_TCP_CONG Message-ID: <20161014080716.GA306@x4> References: <20161014073333.GA10006@x4> <1476431026.5650.38.camel@edumazet-glaptop3.roam.corp.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1476431026.5650.38.camel@edumazet-glaptop3.roam.corp.google.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2016.10.14 at 09:43 +0200, Eric Dumazet wrote: > On Fri, 2016-10-14 at 09:33 +0200, Markus Trippelsdorf wrote: > > While playing with BBR I noticed that it was missing in the list of > > possible config DEFAULT_TCP_CONG choices. Fixed thusly. > > > > Signed-off-by: Markus Trippelsdorf > > > > diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig > > index 300b06888fdf..b54b3ca939db 100644 > > --- a/net/ipv4/Kconfig > > +++ b/net/ipv4/Kconfig > > @@ -715,6 +715,7 @@ config DEFAULT_TCP_CONG > > default "reno" if DEFAULT_RENO > > default "dctcp" if DEFAULT_DCTCP > > default "cdg" if DEFAULT_CDG > > + default "bbr" if DEFAULT_BBR > > default "cubic" > > Not sure if we want this at this moment. > > BBR needs FQ packet scheduler, and this is not exactly trivial to > achieve. For a start, it could be automatically selected: diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig index 300b06888fdf..845d8d3e9e27 100644 --- a/net/ipv4/Kconfig +++ b/net/ipv4/Kconfig @@ -642,6 +642,8 @@ config TCP_CONG_CDG config TCP_CONG_BBR tristate "BBR TCP" + select NET_SCHED + select NET_SCH_FQ default n ---help---