| Message ID | 20160926191140.12107-1-albert.aribaud@3adev.fr |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
... and of course I only see the typo /now/...
Le Mon, 26 Sep 2016 21:11:40 +0200, "Albert ARIBAUD (3ADEV)"
<albert.aribaud@3adev.fr> a écrit :
> If the MDIO enf-of-transfer wait loop does not time out,
~~~~~~~~~~~~~~~
Make that "end-of-transfer".
Should I post a v2?
Cordialement,
Albert ARIBAUD
3ADEV
Hello. On 09/26/2016 10:11 PM, Albert ARIBAUD (3ADEV) wrote: > If the MDIO enf-of-transfer wait loop does not time out, > 0 should be returned to the caller through ret, but ret > was not reset to 0 after receiving the return value of > pm_runtime_get_sync(). Reset ret when no time out occurred. > > Signed-off-by: Albert ARIBAUD (3ADEV) <albert.aribaud@3adev.fr> > --- > drivers/net/ethernet/freescale/fec_main.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c > index 01f7e81..0413c05 100644 > --- a/drivers/net/ethernet/freescale/fec_main.c > +++ b/drivers/net/ethernet/freescale/fec_main.c > @@ -1818,6 +1818,8 @@ static int fec_enet_mdio_write(struct mii_bus *bus, int mii_id, int regnum, > netdev_err(fep->netdev, "MDIO write timeout\n"); > ret = -ETIMEDOUT; > } > + else } else { > + ret = 0; } [...] MBR, Sergei
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 01f7e81..0413c05 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -1818,6 +1818,8 @@ static int fec_enet_mdio_write(struct mii_bus *bus, int mii_id, int regnum, netdev_err(fep->netdev, "MDIO write timeout\n"); ret = -ETIMEDOUT; } + else + ret = 0; pm_runtime_mark_last_busy(dev); pm_runtime_put_autosuspend(dev);
If the MDIO enf-of-transfer wait loop does not time out, 0 should be returned to the caller through ret, but ret was not reset to 0 after receiving the return value of pm_runtime_get_sync(). Reset ret when no time out occurred. Signed-off-by: Albert ARIBAUD (3ADEV) <albert.aribaud@3adev.fr> --- drivers/net/ethernet/freescale/fec_main.c | 2 ++ 1 file changed, 2 insertions(+)