From patchwork Wed Aug 24 20:43:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Andrey Jr. Melnikov" X-Patchwork-Id: 662512 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3sKK5B0xqbz9sCj for ; Thu, 25 Aug 2016 06:43:10 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=e2gSMLdx; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932849AbcHXUnG (ORCPT ); Wed, 24 Aug 2016 16:43:06 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:35436 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752059AbcHXUnF (ORCPT ); Wed, 24 Aug 2016 16:43:05 -0400 Received: by mail-lf0-f68.google.com with SMTP id l89so1488060lfi.2 for ; Wed, 24 Aug 2016 13:43:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=6DUHmtTqF9kp6zOIv4c4xJnZRy5GnyGaWBR+l6FFm94=; b=e2gSMLdxSbGlKs+rMsZuG0ntE9JOcLi2RjL+wmvo9CCkIx3oAsVCn9PHNOSuATgQ/V Zsk6myPiQLGaEB0fUJX7KuruVhYaO9S6ZDAfq2fAcQQE5q4lI2T6I38YpwUqzAS3OPfC 8WbJ1S1HwQv4UMJa3rOBhOOGB2ap1dE16x1YhMGutS3eIgABDd+tTI/hEdDL820ZfUjB m7iBCx4yJbcIDTBPJ3UEgYesoiE7wSSYeZ0n0F312Wl/N84J6mrfFJBZht0yzQKUFPEA wNfKGlGO2NRPYGCqG6rBww2d8CQL/IKV6GqEXnkH7w+E4OqwxwJH/FaLE7A6dAyPdDuj oWKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=6DUHmtTqF9kp6zOIv4c4xJnZRy5GnyGaWBR+l6FFm94=; b=NlG99oJeOKeNCGFDgngqmJcwhqUzPtFiIZXKRz8rFvZEXfJjMsAkNV3AkzVjVy+NBC 19qclPBEz4cTK0EfDNZ4yjAfsN+I2358umGhDk7DhCKWgxTa1DIfF5uM2E0AZkSoSs6B ssEeYFz5bo8bAou9nZ48d+ckDb0IDZ6ma1knqSMiMGgxTl2XFbCvgorGvSypZrAtvFqe oiBBZrHxk9gWcXN5Neu1K4gktPYW8WHvNNTfOZzrSuD2O9CCG81pTha+51CMmv4lDSmf Muc5gs4ZibiaLOgjNcSLu2FfD3Nd1zPS0TznZZgpyI9p8mp8J1Lrtz3drKAPXVpEcjK9 m2Qw== X-Gm-Message-State: AE9vXwPhn837B8MGU85kT2/ZAe5zC2MynpdKpiQyMNhQiMloULjsejolkW7zHBHxBttGfQ== X-Received: by 10.25.86.85 with SMTP id k82mr1523586lfb.65.1472071383968; Wed, 24 Aug 2016 13:43:03 -0700 (PDT) Received: from ppc.Dlink ([2001:470:28:152::2]) by smtp.gmail.com with ESMTPSA id f22sm2303474lji.13.2016.08.24.13.43.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Aug 2016 13:43:02 -0700 (PDT) Date: Wed, 24 Aug 2016 23:43:00 +0300 From: "Andrey Jr. Melnikov" To: Stephen Hemminger Cc: netdev@vger.kernel.org Subject: [PATCH] iproute: disallow ip rule del without parameters Message-ID: <20160824204252.2melotzdx6ftzgaq@ppc.Dlink> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.6.2-neo (2016-07-23) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Disallow run `ip rule del` without any parameter to avoid delete any first rule from table. Signed-off-by: Andrey Jr. Melnikov diff --git a/ip/iprule.c b/ip/iprule.c index 8f24206..70562c5 100644 --- a/ip/iprule.c +++ b/ip/iprule.c @@ -346,6 +346,11 @@ static int iprule_modify(int cmd, int argc, char **argv) req.r.rtm_type = RTN_UNICAST; } + if (cmd == RTM_DELRULE && argc == 0) { + fprintf(stderr, "\"ip rule del\" requires arguments.\n"); + return -1; + } + while (argc > 0) { if (strcmp(*argv, "not") == 0) { req.r.rtm_flags |= FIB_RULE_INVERT;