From patchwork Mon Jul 18 17:16:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brenden Blanco X-Patchwork-Id: 649657 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rtVG85Wvzz9s6r for ; Tue, 19 Jul 2016 03:16:48 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=plumgrid-com.20150623.gappssmtp.com header.i=@plumgrid-com.20150623.gappssmtp.com header.b=AYMutyU4; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751615AbcGRRQo (ORCPT ); Mon, 18 Jul 2016 13:16:44 -0400 Received: from mail-pf0-f173.google.com ([209.85.192.173]:33800 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751254AbcGRRQn (ORCPT ); Mon, 18 Jul 2016 13:16:43 -0400 Received: by mail-pf0-f173.google.com with SMTP id p64so33720670pfb.1 for ; Mon, 18 Jul 2016 10:16:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=plumgrid-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hyk7qI1IzRjO/R9e1u9Xe+8a57e80F/PNGXIG+lifyg=; b=AYMutyU4Ho/YeyW1zA2yvB8LbwI5zzsJp+n+VOligO2ghSdihgk8iGUZcSAecBi4On rvnRS2f5acDpVB8zz83d1WnojxChWLqoXyHQ1i7WQ0Oj6PzhRHihH7Wiv9j/yotOuRUW BO1dl/1hca/bsTFVeAQRhRYSkHFZro68hmxJJUoP4aCjLLwpFLFVjOtQ9K8K9M0W4E7e U3uNKZtE5bLv38qNa6E/NTpdoKJh0WrYvk8x7WGaO4JlBeXTll7rBGHH0cV/1aKDQrc6 jzBTfCj6KUQCdIvSqKjCU1Pkp0jhe7NAJxE2d+7uy+JVAIWn4YAnQ+CycYG3kv1hv1oy 7NWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hyk7qI1IzRjO/R9e1u9Xe+8a57e80F/PNGXIG+lifyg=; b=hyEZtQpnTg+9lXvXBOppPi042REFVfJrg3hHyRu3gsH1SwiJ/6w7bBAEhGpo27hdh2 dqbUK6ZxfLt89tl9i6gVNsscBuSd2rZ18k9t/qVfhooy7ziN7yveMnXMZhynW2IdXe46 jwH1+16yZGIYRzKJyXfkNfgbTnfiKn5Gd1TFJ+PN2G1Z00mrts5ZlEa/sBlSK1lAoU0/ e/BOQiAtuTVrr4d1+9dYWSxPIeGkhX8Ozxz9LCt9rwAbaa8QMZVB2rnWtVZALOujq1+R awqT5B744KrMgZgEjjDGy9BGB4QaQeVSsMKSq9xlRR+RKKanJHvCVWeT8ExpSxQ6qyfx i9qg== X-Gm-Message-State: ALyK8tLagUnFCG2yHDKEmc1LgRtlQgpJQ33LPQKSYtBXce6guwtV2ALOBzpXATqIyhE3OQlL X-Received: by 10.66.160.41 with SMTP id xh9mr58775686pab.85.1468862200131; Mon, 18 Jul 2016 10:16:40 -0700 (PDT) Received: from gmail.com ([12.97.19.194]) by smtp.gmail.com with ESMTPSA id w8sm5938469paz.32.2016.07.18.10.16.38 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 18 Jul 2016 10:16:39 -0700 (PDT) Date: Mon, 18 Jul 2016 10:16:37 -0700 From: Brenden Blanco To: Tariq Toukan Cc: davem@davemloft.net, netdev@vger.kernel.org, Jamal Hadi Salim , Saeed Mahameed , Martin KaFai Lau , Jesper Dangaard Brouer , Ari Saha , Alexei Starovoitov , Or Gerlitz , john.fastabend@gmail.com, hannes@stressinduktion.org, Thomas Graf , Tom Herbert , Daniel Borkmann Subject: Re: [PATCH v9 00/11] Add driver bpf hook for early packet drop and forwarding Message-ID: <20160718171635.GB29243@gmail.com> References: <1468625338-32391-1-git-send-email-bblanco@plumgrid.com> <20160718163827.GA29243@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160718163827.GA29243@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jul 18, 2016 at 09:38:28AM -0700, Brenden Blanco wrote: > On Mon, Jul 18, 2016 at 04:39:38PM +0300, Tariq Toukan wrote: > > After applying the patchset, I get no ping between two VLAN > > interfaces (w/o activating any BPF program). > > I'm debugging it, and will update once I find the bug. > > > > Brenden, please check if you can repro the issue. > I was able to reproduce it also. I suspect a bug in patch 8/11. I clearly didn't test vlans, sorry for that! The fix is pretty obvious, see below if you want to double check. I will fix up 8/11 in the next iteration. > > > > Regards, > > Tariq > > diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c b/drivers/net/ethernet/mellanox/mlx4/en_tx.c index 5d8452d..9df87ca 100644 --- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c @@ -833,7 +831,7 @@ netdev_tx_t mlx4_en_xmit(struct sk_buff *skb, struct net_device *dev) bf_ok = ring->bf_enabled; if (skb_vlan_tag_present(skb)) { - qpn_vlan.vlan_tag = skb_vlan_tag_get(skb); + qpn_vlan.vlan_tag = cpu_to_be16(skb_vlan_tag_get(skb)); vlan_proto = be16_to_cpu(skb->vlan_proto); if (vlan_proto == ETH_P_8021AD) qpn_vlan.ins_vlan = MLX4_WQE_CTRL_INS_SVLAN;