From patchwork Thu Mar 17 17:08:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Bohac X-Patchwork-Id: 599174 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3qQvvx233Yz9sdg for ; Fri, 18 Mar 2016 04:09:01 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030768AbcCQRJA (ORCPT ); Thu, 17 Mar 2016 13:09:00 -0400 Received: from mx2.suse.de ([195.135.220.15]:49562 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030300AbcCQRI6 (ORCPT ); Thu, 17 Mar 2016 13:08:58 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 582B8ABC7; Thu, 17 Mar 2016 17:08:56 +0000 (UTC) Date: Thu, 17 Mar 2016 18:08:55 +0100 From: Jiri Bohac To: Steffen Klassert Cc: Herbert Xu , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH] xfrm: don't segment UFO packets Message-ID: <20160317170855.GA21145@midget.suse.cz> References: <20160129234424.GC7907@midget.suse.cz> <20160130042102.GA22809@gondor.apana.org.au> <20160316160026.GB19258@midget.suse.cz> <20160317050359.GA3840@gondor.apana.org.au> <20160317094115.GA11706@midget.suse.cz> <20160317102459.GG3347@gauss.secunet.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160317102459.GG3347@gauss.secunet.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Mar 17, 2016 at 11:24:59AM +0100, Steffen Klassert wrote: > In IPv6 this check is missing, so this could be the > problem if this is IPv6. indeed, this patch also fixes my problem: I can't say which is better. Herbert originally seemed to like the fix inside xfrm_output(). The IPv4 part is fixed by commit c146066ab80267c3305de5dda6a4083f06df9265 (ipv4: Don't use ufo handling on later transformed packets) Thanks, --- a/net/ipv6/ip6_output.c +++ b/net/ipv6/ip6_output.c @@ -1353,6 +1353,7 @@ emsgsize: (skb && skb_is_gso(skb))) && (sk->sk_protocol == IPPROTO_UDP) && (rt->dst.dev->features & NETIF_F_UFO) && + !rt->dst.header_len && (sk->sk_type == SOCK_DGRAM)) { err = ip6_ufo_append_data(sk, queue, getfrag, from, length, hh_len, fragheaderlen,