From patchwork Mon Dec 14 16:24:06 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tejun Heo X-Patchwork-Id: 556553 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E1F6C1402DE for ; Tue, 15 Dec 2015 03:24:33 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=B4xl9t0O; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751737AbbLNQYM (ORCPT ); Mon, 14 Dec 2015 11:24:12 -0500 Received: from mail-qk0-f181.google.com ([209.85.220.181]:36659 "EHLO mail-qk0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751356AbbLNQYK (ORCPT ); Mon, 14 Dec 2015 11:24:10 -0500 Received: by qkht125 with SMTP id t125so142362147qkh.3; Mon, 14 Dec 2015 08:24:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=CM4mZDX5QwZztTb2XIztcWQvj9oFHbR5rqPWWEFZO88=; b=B4xl9t0OjaYHNZtHQlM9NYK2D7gTTL6/W4d4nMjmJUHkWOBsEebROwqvimY4ycdzN+ cQaDpXYYdP9Y9IV1qJlABSkDYkT+fPyRvb68aXImbeETsUlu25gXxRj6/avvWc8tAKfA fYU+8MPLPGAnyRbLWdqUhn5guosA8ltyTvAgrdRQmYOaCafhgO0avMRQZINtZKCsNSzG XvBHMz+RzMy7ltuW2ppY1fkz/xyJ9Np6mAja+BDgA0TGO6GR0bmu+ypZT22zjuyUSr/X v8f3M9Zgof9j/zIYvAI/0xIZ0aA9BazblMNSQlmjhXnfVycYAC0SWeXqOmruYngFkvT2 DEPA== X-Received: by 10.13.252.131 with SMTP id m125mr19688998ywf.104.1450110248946; Mon, 14 Dec 2015 08:24:08 -0800 (PST) Received: from localhost ([2620:10d:c091:200::d:65e]) by smtp.gmail.com with ESMTPSA id q63sm23237525ywf.16.2015.12.14.08.24.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Dec 2015 08:24:07 -0800 (PST) Date: Mon, 14 Dec 2015 11:24:06 -0500 From: Tejun Heo To: "davem@davemloft.net" Cc: Dexuan Cui , "pablo@netfilter.org" , "kaber@trash.net" , "kadlec@blackhole.kfki.hu" , "daniel@iogearbox.net" , "daniel.wagner@bmw-carit.de" , "nhorman@tuxdriver.com" , "lizefan@huawei.com" , "hannes@cmpxchg.org" , "netdev@vger.kernel.org" , "netfilter-devel@vger.kernel.org" , "coreteam@netfilter.org" , "cgroups@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel-team@fb.com" , "ninasc@fb.com" Subject: [PATCH net-next] net, cgroup: cgroup_sk_updat_lock was missing initializer Message-ID: <20151214162406.GA4026@mtj.duckdns.org> References: <1449527935-27056-1-git-send-email-tj@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org bd1060a1d671 ("sock, cgroup: add sock->sk_cgroup") added global spinlock cgroup_sk_update_lock but erroneously skipped initializer leading to uninitialized spinlock warning. Fix it by using DEFINE_SPINLOCK(). Signed-off-by: Tejun Heo Reported-by: Dexuan Cui Fixes: bd1060a1d671 ("sock, cgroup: add sock->sk_cgroup") --- Hello, Dexuan. Oops, sorry about that. Somehow thought it was a different problem which is already fixed. This should do it. Thanks. kernel/cgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/kernel/cgroup.c b/kernel/cgroup.c index 4f8f792..4466273f 100644 --- a/kernel/cgroup.c +++ b/kernel/cgroup.c @@ -5790,7 +5790,7 @@ EXPORT_SYMBOL_GPL(cgroup_get_from_path); #if defined(CONFIG_CGROUP_NET_PRIO) || defined(CONFIG_CGROUP_NET_CLASSID) -spinlock_t cgroup_sk_update_lock; +DEFINE_SPINLOCK(cgroup_sk_update_lock); static bool cgroup_sk_alloc_disabled __read_mostly; void cgroup_sk_alloc_disable(void)