| Message ID | 20151024151100.GA46525@lkp-hsx03 |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
Acked-by: Jon Maloy <jon.maloy@ericsson.com> > -----Original Message----- > From: netdev-owner@vger.kernel.org [mailto:netdev- > owner@vger.kernel.org] On Behalf Of kbuild test robot > Sent: Saturday, 24 October, 2015 11:11 > To: kbuild-internal@linux.intel.com; lkp@eclists.intel.com > Cc: kbuild-all@01.org; netdev@vger.kernel.org > Subject: [RFC PATCH net-next] tipc: tipc_link_is_active() can be static > > TO: "David S. Miller" <davem@davemloft.net> > CC: netdev@vger.kernel.org > CC: Jon Maloy <jon.maloy@ericsson.com> > CC: Ying Xue <ying.xue@windriver.com> > CC: tipc-discussion@lists.sourceforge.net > CC: linux-kernel@vger.kernel.org > > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > --- > link.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/tipc/link.c b/net/tipc/link.c index 4449fa0..b637276 100644 > --- a/net/tipc/link.c > +++ b/net/tipc/link.c > @@ -173,7 +173,7 @@ bool link_is_bc_rcvlink(struct tipc_link *l) > return ((l->bc_rcvlink == l) && !link_is_bc_sndlink(l)); } > > -int tipc_link_is_active(struct tipc_link *l) > +static int tipc_link_is_active(struct tipc_link *l) > { > return l->active; > } > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in the body > of a message to majordomo@vger.kernel.org More majordomo info at > http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: kbuild test robot <fengguang.wu@intel.com> Date: Sat, 24 Oct 2015 23:11:00 +0800 > TO: "David S. Miller" <davem@davemloft.net> > CC: netdev@vger.kernel.org > CC: Jon Maloy <jon.maloy@ericsson.com> > CC: Ying Xue <ying.xue@windriver.com> > CC: tipc-discussion@lists.sourceforge.net > CC: linux-kernel@vger.kernel.org > > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Why doesn't the kbuild robot run on it's own changes? :-/ CC [M] net/tipc/link.o net/tipc/link.c:176:12: warning: ‘tipc_link_is_active’ defined but not used [-Wunused-function]
On Sun, Oct 25, 2015 at 06:33:18AM -0700, David Miller wrote: > From: kbuild test robot <fengguang.wu@intel.com> > Date: Sat, 24 Oct 2015 23:11:00 +0800 > > > TO: "David S. Miller" <davem@davemloft.net> > > CC: netdev@vger.kernel.org > > CC: Jon Maloy <jon.maloy@ericsson.com> > > CC: Ying Xue <ying.xue@windriver.com> > > CC: tipc-discussion@lists.sourceforge.net > > CC: linux-kernel@vger.kernel.org > > > > > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > > Why doesn't the kbuild robot run on it's own changes? :-/ It does, however it detects only build failures (which indicates a false sparse warning) to avoid sending bad make-it-static patch and the false warning. The build warning looks easier to be discovered and fixed in the larger loop of apply patch => git push => 0day build test > CC [M] net/tipc/link.o > net/tipc/link.c:176:12: warning: ‘tipc_link_is_active’ defined but not used [-Wunused-function] If the robot detected the above warning, it'll still need to send the report out. Otherwise we lose a chance to notice tipc_link_is_active() is not used. However it may be valuable to include possible new warnings inside the patch changelog, so that maintainers can immediately see the consequences of applying the patch. Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/tipc/link.c b/net/tipc/link.c index 4449fa0..b637276 100644 --- a/net/tipc/link.c +++ b/net/tipc/link.c @@ -173,7 +173,7 @@ bool link_is_bc_rcvlink(struct tipc_link *l) return ((l->bc_rcvlink == l) && !link_is_bc_sndlink(l)); } -int tipc_link_is_active(struct tipc_link *l) +static int tipc_link_is_active(struct tipc_link *l) { return l->active; }
TO: "David S. Miller" <davem@davemloft.net> CC: netdev@vger.kernel.org CC: Jon Maloy <jon.maloy@ericsson.com> CC: Ying Xue <ying.xue@windriver.com> CC: tipc-discussion@lists.sourceforge.net CC: linux-kernel@vger.kernel.org Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- link.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html