| Message ID | 20150901180741.1451e146@endymion.delvare |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Jean Delvare <jdelvare@suse.de> Date: Tue, 1 Sep 2015 18:07:41 +0200 > The temperature registers appear to report values in degrees Celsius > while the hwmon API mandates values to be exposed in millidegrees > Celsius. Do the conversion so that the values reported by "sensors" > are correct. > > Fixes: aed93e0bf493 ("tg3: Add hwmon support for temperature") > Signed-off-by: Jean Delvare <jdelvare@suse.de> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- linux-4.2.orig/drivers/net/ethernet/broadcom/tg3.c 2015-09-01 17:38:59.786648348 +0200 +++ linux-4.2/drivers/net/ethernet/broadcom/tg3.c 2015-09-01 17:47:14.237152813 +0200 @@ -10757,7 +10757,7 @@ static ssize_t tg3_show_temp(struct devi tg3_ape_scratchpad_read(tp, &temperature, attr->index, sizeof(temperature)); spin_unlock_bh(&tp->lock); - return sprintf(buf, "%u\n", temperature); + return sprintf(buf, "%u\n", temperature * 1000); }
The temperature registers appear to report values in degrees Celsius while the hwmon API mandates values to be exposed in millidegrees Celsius. Do the conversion so that the values reported by "sensors" are correct. Fixes: aed93e0bf493 ("tg3: Add hwmon support for temperature") Signed-off-by: Jean Delvare <jdelvare@suse.de> Cc: Prashant Sreedharan <prashant@broadcom.com> Cc: Michael Chan <mchan@broadcom.com> Cc: stable@vger.kernel.org [v3.6+] --- drivers/net/ethernet/broadcom/tg3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)