From patchwork Fri Jul 10 00:15:01 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 493600 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id DCF83140280 for ; Fri, 10 Jul 2015 10:15:34 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b=mLnVtQaM; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751449AbbGJAPH (ORCPT ); Thu, 9 Jul 2015 20:15:07 -0400 Received: from mail-ig0-f182.google.com ([209.85.213.182]:35609 "EHLO mail-ig0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751299AbbGJAPE (ORCPT ); Thu, 9 Jul 2015 20:15:04 -0400 Received: by igcqs7 with SMTP id qs7so2100130igc.0 for ; Thu, 09 Jul 2015 17:15:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=JbSxUYT5XTDD7xJVnhflFollFRqlfO86hpCPglW10dA=; b=mLnVtQaMBw/2CKIyhZksZ6X9fQcZ7wHFRXPV/64b4Bd1SIAV+nBDhNKCIQHcGCHh0r 9GGXojFsdTBUTUPuMwpQ+Bu18qy3E7fTnSndxv8AXYqaXP8ZvjSFmtpKKdjtkPjeuwVc 0ZvMTGdHvnIlc5T9tK3/PtpZK8BQ0iKhBUIV9wqapgRYZs/plswc8JzvxzX6nJZNIpsO jIAA8lg+Ya18YXv44M2YCkczGEhPv7LmmPNiFO4PJV36FhpdCg/7Pm9TH8ENPAbXglGT 3GdJHbeb+s29b/IS/OgknrfsD7EyoZUpPoV/B+VF75VJcTpjQYc/MM+e+RvJjjFS5Bme svdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-type:content-disposition:user-agent; bh=JbSxUYT5XTDD7xJVnhflFollFRqlfO86hpCPglW10dA=; b=OCHSVq+291sVy7qqEKe/eDukQkugkcrgJH/TTdpXk9EbaKkZkjmwypCOSSigiB8+VO 9T6ntJ+8GDZ/MleZjWZyZIRLplIgzVsLbZy80pVtZKAiZZzJej86ddKks3fhf2VWTtOB cCzNBIvuGtBYPtkpvGbn/DwTKwQYBv6qE1hQ0DlgpctqJWUsFfWpurhdCB9TuJbPQxyj +yEU5ih4SYMqkY5aZVmEjbhLkBZNV7wujWLJSPGJoEHYh8GQIoVT3E/PFMn4m8bYDsRQ d1l4+tJcfdffjUBb11EI83oTcIqwzhcTyDwwJRNKr4avE5r/PA8mcaEnf/uHKcgIJmrO 1j/A== X-Gm-Message-State: ALoCoQkGWKBvn7QZK/2RVtJ+edWFel1xBaIsfNAEIO3KCBQLnR8lJC2i+N2RFoI00y4Q/3AL6/Sd X-Received: by 10.50.225.103 with SMTP id rj7mr445034igc.59.1436487303826; Thu, 09 Jul 2015 17:15:03 -0700 (PDT) Received: from dtor-ws ([2620:0:1000:1301:c556:cc24:8d7f:cc82]) by smtp.gmail.com with ESMTPSA id z195sm5301367iod.33.2015.07.09.17.15.03 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 09 Jul 2015 17:15:03 -0700 (PDT) Date: Thu, 9 Jul 2015 17:15:01 -0700 From: Dmitry Torokhov To: "David S. Miller" Cc: Pablo Neira Ayuso , Patrick McHardy , Jozsef Kadlecsik , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] nf: IDLETIMER: fix lockdep warning Message-ID: <20150710001501.GA32570@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Dynamically allocated sysfs attributes should be initialized with sysfs_attr_init() otherwise lockdep will be angry with us: [ 45.468653] BUG: key ffffffc030fad4e0 not in .data! [ 45.468655] ------------[ cut here ]------------ [ 45.468666] WARNING: CPU: 0 PID: 1176 at /mnt/host/source/src/third_party/kernel/v3.18/kernel/locking/lockdep.c:2991 lockdep_init_map+0x12c/0x490() [ 45.468672] DEBUG_LOCKS_WARN_ON(1) [ 45.468672] CPU: 0 PID: 1176 Comm: iptables Tainted: G U W 3.18.0 #43 [ 45.468674] Hardware name: XXX [ 45.468675] Call trace: [ 45.468680] [] dump_backtrace+0x0/0x10c [ 45.468683] [] show_stack+0x10/0x1c [ 45.468688] [] dump_stack+0x74/0x94 [ 45.468692] [] warn_slowpath_common+0x84/0xb0 [ 45.468694] [] warn_slowpath_fmt+0x4c/0x58 [ 45.468697] [] lockdep_init_map+0x128/0x490 [ 45.468701] [] __kernfs_create_file+0x80/0xe4 [ 45.468704] [] sysfs_add_file_mode_ns+0x104/0x170 [ 45.468706] [] sysfs_create_file_ns+0x58/0x64 [ 45.468711] [] idletimer_tg_checkentry+0x14c/0x324 [ 45.468714] [] xt_check_target+0x170/0x198 [ 45.468717] [] check_target+0x58/0x6c [ 45.468720] [] translate_table+0x30c/0x424 [ 45.468723] [] do_ipt_set_ctl+0x144/0x1d0 [ 45.468728] [] nf_setsockopt+0x50/0x60 [ 45.468732] [] ip_setsockopt+0x8c/0xb4 [ 45.468735] [] raw_setsockopt+0x10/0x50 [ 45.468739] [] sock_common_setsockopt+0x14/0x20 [ 45.468742] [] SyS_setsockopt+0x88/0xb8 [ 45.468744] ---[ end trace 41d156354d18c039 ]--- Change-Id: I1da5cd96fc8e1e1e4209e81eba1165a42d4d45e9 Signed-off-by: Dmitry Torokhov --- net/netfilter/xt_IDLETIMER.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/netfilter/xt_IDLETIMER.c b/net/netfilter/xt_IDLETIMER.c index 31f76cd..0975c993 100644 --- a/net/netfilter/xt_IDLETIMER.c +++ b/net/netfilter/xt_IDLETIMER.c @@ -286,6 +286,7 @@ static int idletimer_tg_create(struct idletimer_tg_info *info) goto out; } + sysfs_attr_init(&info->timer->attr.attr); info->timer->attr.attr.name = kstrdup(info->label, GFP_KERNEL); if (!info->timer->attr.attr.name) { ret = -ENOMEM;