From patchwork Thu May 14 23:17:08 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 472546 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 660701400B7 for ; Fri, 15 May 2015 09:17:18 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b=Oem4559H; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161209AbbENXRO (ORCPT ); Thu, 14 May 2015 19:17:14 -0400 Received: from mail-ie0-f181.google.com ([209.85.223.181]:33242 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933134AbbENXRL (ORCPT ); Thu, 14 May 2015 19:17:11 -0400 Received: by iebgx4 with SMTP id gx4so74788287ieb.0 for ; Thu, 14 May 2015 16:17:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=subject:to:from:cc:date:message-id:user-agent:mime-version :content-type:content-transfer-encoding; bh=nie3RoApZKcbX5efD7bIYwxcYNOfEoqZa0rVNyEtqqw=; b=Oem4559HqDHDgO0ANbN91TOBa4nvIZIsZnAYInqsMaoJvD+HcCZckPamMAtaU3uGxm +4aOPEQDW4cdFcz2W5tBJwXIHuwDNI6JPVqhYMBlkwkPHWt/eK/XkqM2eJVbjVW9xul3 Kl9sh/lRMs3dSYZe9ZLGB+RFloh3YiTI8ahn9QS984jNl/IAPkC7Q1e0GWZTqbbv4LE9 0IP1J+nryvZWaHUHJ/U8o2R7KbftXL32n3LXH7Xmk3IKKtscM+DSguJb4H8uMZFuUuh9 jZokbfV6XcLxAnrOyN9uCQrrcHjf/FHX7DZCt1VzRU2fExqDF+z0qDeuNvNsvyaZ5BJU Tlbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:from:cc:date:message-id:user-agent :mime-version:content-type:content-transfer-encoding; bh=nie3RoApZKcbX5efD7bIYwxcYNOfEoqZa0rVNyEtqqw=; b=DKLVV5rcw9m+nb1JKxpUufGYXRDPx/EIiGT0FfZmpJ/x5bCquk8TTPNGbAso5A9REy UnuZ2kjRH8GyfKd38VqWeW/fY216DLAe/WXKsym1PvB44r3MYImRgHvmtCvEo+kOnQzW xHU6788/6WFcFabqfgtFD00j0mglDJOvmV24E8Wffrt4ObSLtRdq21EjvRPRu4SUyBj9 6pE93udvBdb3T6Ql7bXMbf0U9V8SC+WgO2+LKfYgJeNygieg4s9M9kZeOhzxrADSTS71 +YSzMvnSWCRZrdF06BIaMZXUXZ1dl0TVbvB7pT/L2OubImKjNgPzpCLzvFIjYS9YC09J XVaw== X-Gm-Message-State: ALoCoQlpCYro8USQDjeIZ9xd4uJX0w9+/9VVhsmmzm2QOv7kxhgMuvCfb42b/y2NlJtQWGXVTXcM X-Received: by 10.43.92.199 with SMTP id br7mr4834089icc.43.1431645430407; Thu, 14 May 2015 16:17:10 -0700 (PDT) Received: from localhost ([69.71.1.1]) by mx.google.com with ESMTPSA id p8sm111590iga.13.2015.05.14.16.17.09 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 14 May 2015 16:17:09 -0700 (PDT) Subject: [PATCH] net/mlx4: Avoid 'may be used uninitialized' warnings To: Or Gerlitz , Jack Morgenstein , Matan Barak From: Bjorn Helgaas Cc: Ido Shamay , netdev@vger.kernel.org, Yishai Hadas , Amir Vadai , linux-kernel@vger.kernel.org, Roland Dreier , "David S. Miller" Date: Thu, 14 May 2015 18:17:08 -0500 Message-ID: <20150514231708.13594.13610.stgit@bhelgaas-glaptop2.roam.corp.google.com> User-Agent: StGit/0.16 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org With a cross-compiler based on gcc-4.9, I see warnings like the following: drivers/net/ethernet/mellanox/mlx4/resource_tracker.c: In function 'mlx4_SW2HW_CQ_wrapper': drivers/net/ethernet/mellanox/mlx4/resource_tracker.c:3048:10: error: 'cq' may be used uninitialized in this function [-Werror=maybe-uninitialized] cq->mtt = mtt; I think the warning is spurious because we only use cq when cq_res_start_move_to() returns zero, and it always initializes *cq in that case. The srq case is similar. But maybe gcc isn't smart enough to figure that out. Initialize cq and srq explicitly to avoid the warnings. Signed-off-by: Bjorn Helgaas --- .../net/ethernet/mellanox/mlx4/resource_tracker.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c index c7f28bf..cdd32f4 100644 --- a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c +++ b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c @@ -3187,7 +3187,7 @@ int mlx4_SW2HW_CQ_wrapper(struct mlx4_dev *dev, int slave, int cqn = vhcr->in_modifier; struct mlx4_cq_context *cqc = inbox->buf; int mtt_base = cq_get_mtt_addr(cqc) / dev->caps.mtt_entry_sz; - struct res_cq *cq; + struct res_cq *cq = NULL; struct res_mtt *mtt; err = cq_res_start_move_to(dev, slave, cqn, RES_CQ_HW, &cq); @@ -3223,7 +3223,7 @@ int mlx4_HW2SW_CQ_wrapper(struct mlx4_dev *dev, int slave, { int err; int cqn = vhcr->in_modifier; - struct res_cq *cq; + struct res_cq *cq = NULL; err = cq_res_start_move_to(dev, slave, cqn, RES_CQ_ALLOCATED, &cq); if (err) @@ -3362,7 +3362,7 @@ int mlx4_SW2HW_SRQ_wrapper(struct mlx4_dev *dev, int slave, int err; int srqn = vhcr->in_modifier; struct res_mtt *mtt; - struct res_srq *srq; + struct res_srq *srq = NULL; struct mlx4_srq_context *srqc = inbox->buf; int mtt_base = srq_get_mtt_addr(srqc) / dev->caps.mtt_entry_sz; @@ -3406,7 +3406,7 @@ int mlx4_HW2SW_SRQ_wrapper(struct mlx4_dev *dev, int slave, { int err; int srqn = vhcr->in_modifier; - struct res_srq *srq; + struct res_srq *srq = NULL; err = srq_res_start_move_to(dev, slave, srqn, RES_SRQ_ALLOCATED, &srq); if (err)