diff mbox

[net-next] net: Fix ifdef typo in net_device definition

Message ID 20150511183152.13432.73713.stgit@ahduyck-vm-fedora22
State Not Applicable, archived
Delegated to: David Miller
Headers show

Commit Message

Alexander Duyck May 11, 2015, 6:31 p.m. UTC
While trying to build for some performance testing I received the error
message below multiple times:

include/linux/netdevice.h:1658:5: warning: "CONFIG_NET_CLS_ACT" is not defined [-Wundef]
 #if CONFIG_NET_CLS_ACT

It looks like this was just a typo and should have been "#ifdef" instead of
"#if".

Fixes: d2788d34885d4 ("net: sched: further simplify handle_ing")
Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
---
 include/linux/netdevice.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Daniel Borkmann May 11, 2015, 6:39 p.m. UTC | #1
On 05/11/2015 08:31 PM, Alexander Duyck wrote:
> While trying to build for some performance testing I received the error
> message below multiple times:
>
> include/linux/netdevice.h:1658:5: warning: "CONFIG_NET_CLS_ACT" is not defined [-Wundef]
>   #if CONFIG_NET_CLS_ACT
>
> It looks like this was just a typo and should have been "#ifdef" instead of
> "#if".
>
> Fixes: d2788d34885d4 ("net: sched: further simplify handle_ing")
> Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>

It's already here, sorry for that:

   https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=4cda01e86f68dacc758b2daf6e8809f2ce915b85

Best,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alexander Duyck May 11, 2015, 7:52 p.m. UTC | #2
On 05/11/2015 11:39 AM, Daniel Borkmann wrote:
> On 05/11/2015 08:31 PM, Alexander Duyck wrote:
>> While trying to build for some performance testing I received the error
>> message below multiple times:
>>
>> include/linux/netdevice.h:1658:5: warning: "CONFIG_NET_CLS_ACT" is 
>> not defined [-Wundef]
>>   #if CONFIG_NET_CLS_ACT
>>
>> It looks like this was just a typo and should have been "#ifdef" 
>> instead of
>> "#if".
>>
>> Fixes: d2788d34885d4 ("net: sched: further simplify handle_ing")
>> Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
>
> It's already here, sorry for that:
>
> https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=4cda01e86f68dacc758b2daf6e8809f2ce915b85
>
> Best,
> Daniel

No problem.  Just as long as it is fixed I am happy since it is one less 
patch to carry in my tree.

- Alex
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index c4e1caf6056f..a6d706b2a947 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1655,7 +1655,7 @@  struct net_device {
 	rx_handler_func_t __rcu	*rx_handler;
 	void __rcu		*rx_handler_data;
 
-#if CONFIG_NET_CLS_ACT
+#ifdef CONFIG_NET_CLS_ACT
 	struct tcf_proto __rcu  *ingress_cl_list;
 #endif
 	struct netdev_queue __rcu *ingress_queue;