| Message ID | 20150330164138.1335.47547.stgit@ahduyck-vm-fedora22 |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
On Mon, 2015-03-30 at 09:41 -0700, Alexander Duyck wrote: > The ixgbe driver hasn't used call_rcu to free the rings for some time > now. > Since that is the case the call to rcu_barrier can be dropped since > calls > to kfree_rcu don't require it. > > Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com> > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 -- > 1 file changed, 2 deletions(-) Thanks Alex, I will add you patch to my queue.
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 395dc6bb5d82..d628c0173e29 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -8977,8 +8977,6 @@ static void __exit ixgbe_exit_module(void) pci_unregister_driver(&ixgbe_driver); ixgbe_dbg_exit(); - - rcu_barrier(); /* Wait for completion of call_rcu()'s */ } #ifdef CONFIG_IXGBE_DCA
The ixgbe driver hasn't used call_rcu to free the rings for some time now. Since that is the case the call to rcu_barrier can be dropped since calls to kfree_rcu don't require it. Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com> --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 -- 1 file changed, 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html