| Message ID | 20150313140822.GA30448@oracle.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On 3/13/15, 7:08 AM, Venkat Venkatsubra wrote: > On adding an interface br_add_if() sets the MTU to the min of > all the interfaces. Do the same thing on removing an interface too > in br_del_if. > > Signed-off-by: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com> > --- > net/bridge/br_if.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c > index b087d27..1849d96 100644 > --- a/net/bridge/br_if.c > +++ b/net/bridge/br_if.c > @@ -563,6 +563,8 @@ int br_del_if(struct net_bridge *br, struct net_device *dev) > */ > del_nbp(p); > > + dev_set_mtu(br->dev, br_min_mtu(br)); > + > spin_lock_bh(&br->lock); > changed_addr = br_stp_recalculate_bridge_id(br); > spin_unlock_bh(&br->lock); This looks good to me. Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: roopa <roopa@cumulusnetworks.com> Date: Fri, 13 Mar 2015 19:12:52 -0700 > On 3/13/15, 7:08 AM, Venkat Venkatsubra wrote: >> On adding an interface br_add_if() sets the MTU to the min of >> all the interfaces. Do the same thing on removing an interface too >> in br_del_if. >> >> Signed-off-by: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com> >> --- >> net/bridge/br_if.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c >> index b087d27..1849d96 100644 >> --- a/net/bridge/br_if.c >> +++ b/net/bridge/br_if.c >> @@ -563,6 +563,8 @@ int br_del_if(struct net_bridge *br, struct >> net_device *dev) >> */ >> del_nbp(p); >> + dev_set_mtu(br->dev, br_min_mtu(br)); >> + >> spin_lock_bh(&br->lock); >> changed_addr = br_stp_recalculate_bridge_id(br); >> spin_unlock_bh(&br->lock); > This looks good to me. > > Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com> Applied, thanks everyone. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index b087d27..1849d96 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -563,6 +563,8 @@ int br_del_if(struct net_bridge *br, struct net_device *dev) */ del_nbp(p); + dev_set_mtu(br->dev, br_min_mtu(br)); + spin_lock_bh(&br->lock); changed_addr = br_stp_recalculate_bridge_id(br); spin_unlock_bh(&br->lock);
On adding an interface br_add_if() sets the MTU to the min of all the interfaces. Do the same thing on removing an interface too in br_del_if. Signed-off-by: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com> --- net/bridge/br_if.c | 2 ++ 1 file changed, 2 insertions(+)