From patchwork Sat Jan 3 00:25:26 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: kbuild test robot X-Patchwork-Id: 425076 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D445714007F for ; Sat, 3 Jan 2015 11:26:16 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752451AbbACAZx (ORCPT ); Fri, 2 Jan 2015 19:25:53 -0500 Received: from mga14.intel.com ([192.55.52.115]:54858 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752207AbbACAZv (ORCPT ); Fri, 2 Jan 2015 19:25:51 -0500 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 02 Jan 2015 16:21:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,686,1413270000"; d="scan'208";a="656171893" Received: from bee.sh.intel.com (HELO bee) ([10.239.97.14]) by fmsmga002.fm.intel.com with ESMTP; 02 Jan 2015 16:25:42 -0800 Received: from kbuild by bee with local (Exim 4.83) (envelope-from ) id 1Y7CXG-000TqU-7a; Sat, 03 Jan 2015 08:25:42 +0800 Date: Sat, 3 Jan 2015 08:25:26 +0800 From: kbuild test robot To: Roger Chen Cc: kbuild-all@01.org, Giuseppe Cavallaro , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] GMAC: fix simple_return.cocci warnings Message-ID: <20150103002526.GA15863@waimea.lkp.intel.com> References: <201501030822.7cG5bXrm%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201501030822.7cG5bXrm%fengguang.wu@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:425:1-4: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci CC: Roger Chen Signed-off-by: Fengguang Wu --- dwmac-rk.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c @@ -422,11 +422,7 @@ static int rk_gmac_init(struct platform_ if (ret) return ret; - ret = gmac_clk_enable(bsp_priv, true); - if (ret) - return ret; - - return 0; + return gmac_clk_enable(bsp_priv, true); } static void rk_gmac_exit(struct platform_device *pdev, void *priv)