diff mbox

[2/2] lec: Fix bug introduced by b67bfe0d42cac56c512dd5da4b1b347a23f4b70a

Message ID 201408121224.s7CCOKCk008781@thirdoffive.cmf.nrl.navy.mil
State Superseded, archived
Delegated to: David Miller
Headers show

Commit Message

chas williams - CONTRACTOR Aug. 12, 2014, 12:24 p.m. UTC
b67bfe0d42cac56c512dd5da4b1b347a23f4b70a dropped the node parameters
from iterators which lec_tbl_walk() was using to iterate the list.

Signed-off-by: Chas Williams <chas@cmf.nrl.navy.mil>
---
 net/atm/lec.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Sergei Shtylyov Aug. 12, 2014, 12:34 p.m. UTC | #1
Hello.

On 8/12/2014 4:24 PM, chas williams - CONTRACTOR wrote:

> b67bfe0d42cac56c512dd5da4b1b347a23f4b70a dropped the node parameters

    Please also specify that commit's summary line in parens.

> from iterators which lec_tbl_walk() was using to iterate the list.

> Signed-off-by: Chas Williams <chas@cmf.nrl.navy.mil>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/atm/lec.c b/net/atm/lec.c
index 4c5b8ba..e4853b5 100644
--- a/net/atm/lec.c
+++ b/net/atm/lec.c
@@ -833,7 +833,6 @@  static void *lec_tbl_walk(struct lec_state *state, struct hlist_head *tbl,
 			  loff_t *l)
 {
 	struct hlist_node *e = state->node;
-	struct lec_arp_table *tmp;
 
 	if (!e)
 		e = tbl->first;
@@ -842,9 +841,7 @@  static void *lec_tbl_walk(struct lec_state *state, struct hlist_head *tbl,
 		--*l;
 	}
 
-	tmp = container_of(e, struct lec_arp_table, next);
-
-	hlist_for_each_entry_from(tmp, next) {
+	for (; e; e = e->next) {
 		if (--*l < 0)
 			break;
 	}