From patchwork Wed Jun 25 15:47:31 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Luis R. Rodriguez" X-Patchwork-Id: 364066 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 7D67414009B for ; Thu, 26 Jun 2014 01:47:55 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757306AbaFYPri (ORCPT ); Wed, 25 Jun 2014 11:47:38 -0400 Received: from mail-pb0-f47.google.com ([209.85.160.47]:52687 "EHLO mail-pb0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756777AbaFYPrg (ORCPT ); Wed, 25 Jun 2014 11:47:36 -0400 Received: by mail-pb0-f47.google.com with SMTP id up15so1867024pbc.20 for ; Wed, 25 Jun 2014 08:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=NbZsLJ+ofZe0/QMdPzyZNIDYErFWnEZdHiHa+VeA58w=; b=Fd7z8s5bVjNTNutI599M0HjZhzVJxzS5Tw1fmFu5g6MzfiS+r5hudrtqj0sHRalvnz IeVeQj79PZGViMC2UaBWV37TSDQwq1TO01LKveREP9B++v16ilcHSbOBz/XfuOb22WSG A+RnivC5GOa4wFiLl9L0OF6T6DfUuci7k/6aN5W6MtC5o0mbztdImENZetXTN4zEGYf0 D1tfTEUGWRrd/DoU7jjdfywV/ZUuhBrV1y3k1OdOYVYsXkleHiv7xbLfp5aWYABamQua c+gJM3C6s601SjI9KhBd78fbZeHKh7Y8KAmdk6H7/bZ/kGENjKT3eDIU50ETe44/ll20 2hqA== X-Received: by 10.66.161.199 with SMTP id xu7mr8128687pab.89.1403711256161; Wed, 25 Jun 2014 08:47:36 -0700 (PDT) Received: from mcgrof@gmail.com (c-98-234-145-61.hsd1.ca.comcast.net. [98.234.145.61]) by mx.google.com with ESMTPSA id qj3sm5802946pbc.91.2014.06.25.08.47.32 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 25 Jun 2014 08:47:34 -0700 (PDT) Received: by mcgrof@gmail.com (sSMTP sendmail emulation); Wed, 25 Jun 2014 08:47:31 -0700 Date: Wed, 25 Jun 2014 08:47:31 -0700 From: "Luis R. Rodriguez" To: Ben Hutchings Cc: Kalle Valo , "linux-kernel@vger.kernel.org" , David Woodhouse , linux-wireless , ath10k@lists.infradead.org, "netdev@vger.kernel.org" Subject: Re: [PATCH 3/3] ath10k: add firmware files Message-ID: <20140625154731.GJ1390@garbanzo.do-not-panic.com> References: <20140314084501.23100.13103.stgit@x230> <20140314084514.23100.72654.stgit@x230> <1394996230.15764.113.camel@deadeye.wl.decadent.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Mar 16, 2014 at 01:17:52PM -0700, Luis R. Rodriguez wrote: > On Sun, Mar 16, 2014 at 11:57 AM, Ben Hutchings wrote: > > On Fri, 2014-03-14 at 05:36 -0700, Luis R. Rodriguez wrote: > >> On Fri, Mar 14, 2014 at 1:45 AM, Kalle Valo wrote: > > [...] > >> > + NO LICENSES OR OTHER RIGHTS, > >> > +WHETHER EXPRESS, IMPLIED, BASED ON ESTOPPEL OR OTHERWISE, ARE GRANTED > >> > +TO ANY PARTY'S PATENTS, PATENT APPLICATIONS, OR PATENTABLE INVENTIONS > >> > +BY VIRTUE OF THIS LICENSE OR THE DELIVERY OR PROVISION BY QUALCOMM > >> > +ATHEROS, INC. OF THE SOFTWARE. > >> > >> This -- however is new to linux-firmware -- and I hereby raise a big > >> red fucking flag. All other licenses on linux-firmware provide at the > >> very least a limited patent grant. What makes Qualcomm special ? > > [...] > > > > There are several licence texts that don't mention patents at all. I'm > > assuming that the companies submitting firmware for inclusion in Linux > > or linux-firmware do intend to grant whatever licences are required to > > distribute it to end users. > > Agreed, this would be the only fair thing. > > > Several licence texts explicitly exclude patent licences relating to any > > *other* products of the same company, but that's quite redundant. > > Sure. > > > However this language seems to explicitly exclude *any* patent licence. > > Yeap, they are making it crystal clear. > > > You're right to raise a red flag because, assuming Qualcomm does have > > patents that cover the firmware alone, this seems to disallow > > redistribution in whatever jurisdictions those patents apply. > > I'm also fearful of this setting a precedent for other vendors. <-- snip --> > To avoid patches as this one should we define some basic guidelines > for linux-firmware acceptable licenses? How about this small change to clarify ? From b0b9bd8328f797836ce0db6157232d017220594b Mon Sep 17 00:00:00 2001 From: "Luis R. Rodriguez" Date: Wed, 25 Jun 2014 08:41:25 -0700 Subject: [PATCH] README: clarify redistribution requirements covering patents Firmware licenses should include an implicit or explicit patent grant to end users for full device operation. Signed-off-by: Luis R. Rodriguez --- README | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/README b/README index f2ed92e..d2a56ec 100644 --- a/README +++ b/README @@ -18,7 +18,10 @@ and also cc: to related mailing lists. Your commit should include an update to the WHENCE file clearly identifying the licence under which the firmware is available, and -that it is redistributable. If the licence is long and involved, it's +that it is redistributable. Being redistributable includes ensuring +the firmware license provided includes an implicit or explicit +patent grant to end users to ensure full functionality of device +operation with the firmware. If the licence is long and involved, it's permitted to include it in a separate file and refer to it from the WHENCE file. And if it were possible, a changelog of the firmware itself.