From patchwork Fri May 2 19:43:36 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 345249 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9D243140140 for ; Sat, 3 May 2014 05:43:51 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752687AbaEBTnj (ORCPT ); Fri, 2 May 2014 15:43:39 -0400 Received: from cmexedge2.ext.emulex.com ([138.239.224.100]:20364 "EHLO CMEXEDGE2.ext.emulex.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752485AbaEBTnj (ORCPT ); Fri, 2 May 2014 15:43:39 -0400 Received: from CMEXHTCAS1.ad.emulex.com (138.239.115.217) by CMEXEDGE2.ext.emulex.com (138.239.224.100) with Microsoft SMTP Server (TLS) id 14.3.174.1; Fri, 2 May 2014 12:44:10 -0700 Received: from emulex.com (138.239.131.156) by smtp.emulex.com (138.239.115.207) with Microsoft SMTP Server (TLS) id 14.3.174.1; Fri, 2 May 2014 12:43:38 -0700 Date: Fri, 2 May 2014 14:43:36 -0500 From: Ajit Khaparde To: Subject: [PATCH net 2/2] be2net: Reset multicast promiscuous mode when its enabled Message-ID: <20140502194336.GA20113@emulex.com> Reply-To: Ajit Khaparde MIME-Version: 1.0 Content-Disposition: inline X-URL: http://www.emulex.com Organization: Emulex Corp User-Agent: "Ajit's Mutt" X-OS: Linux i686 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Currently we are resetting the multicast promiscuous mode everytime we send a multicast list to the FW. It is unnecessary. With this fix we disable multicast promiscuous mode only when enabled. Signed-off-by: Ajit Khaparde --- drivers/net/ethernet/emulex/benet/be_cmds.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.c b/drivers/net/ethernet/emulex/benet/be_cmds.c index d1ec15a..78888ab 100644 --- a/drivers/net/ethernet/emulex/benet/be_cmds.c +++ b/drivers/net/ethernet/emulex/benet/be_cmds.c @@ -1858,9 +1858,11 @@ int be_cmd_rx_filter(struct be_adapter *adapter, u32 flags, u32 value) /* Reset mcast promisc mode if already set by setting mask * and not setting flags field */ - req->if_flags_mask |= - cpu_to_le32(BE_IF_FLAGS_MCAST_PROMISCUOUS & - be_if_cap_flags(adapter)); + if (adapter->flags & BE_FLAGS_MCAST_PROMISC) + req->if_flags_mask |= + cpu_to_le32(BE_IF_FLAGS_MCAST_PROMISCUOUS & + be_if_cap_flags(adapter)); + req->mcast_num = cpu_to_le32(netdev_mc_count(adapter->netdev)); netdev_for_each_mc_addr(ha, adapter->netdev) memcpy(req->mcast_mac[i++].byte, ha->addr, ETH_ALEN);