From patchwork Sun Dec 29 21:51:37 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: stephen hemminger X-Patchwork-Id: 305679 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A901D2C00A6 for ; Mon, 30 Dec 2013 08:59:57 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752704Ab3L2Vvv (ORCPT ); Sun, 29 Dec 2013 16:51:51 -0500 Received: from mx0a-000f0801.pphosted.com ([67.231.144.122]:15312 "EHLO mx0a-000f0801.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752424Ab3L2Vvu (ORCPT ); Sun, 29 Dec 2013 16:51:50 -0500 Received: from pps.filterd (m0000542 [127.0.0.1]) by mx0a-000f0801.pphosted.com (8.14.5/8.14.5) with SMTP id rBTLFowm026898; Sun, 29 Dec 2013 13:51:42 -0800 Received: from hq1wp-exchub01.corp.brocade.com ([144.49.131.13]) by mx0a-000f0801.pphosted.com with ESMTP id 1h2nu9rgnq-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Sun, 29 Dec 2013 13:51:42 -0800 Received: from HQ1WP-EXHUB01.corp.brocade.com (10.70.36.14) by HQ1WP-EXCHUB01.corp.brocade.com (10.70.36.99) with Microsoft SMTP Server (TLS) id 14.3.123.3; Sun, 29 Dec 2013 13:51:42 -0800 Received: from nehalam.linuxnetplumber.net (172.16.180.50) by imap.brocade.com (10.70.36.22) with Microsoft SMTP Server (TLS) id 8.3.298.1; Sun, 29 Dec 2013 13:51:41 -0800 Date: Sun, 29 Dec 2013 13:51:37 -0800 From: Stephen Hemminger To: Eli Cohen , David Miller CC: Subject: [PATCH net-next] mlx5: remove dead code Message-ID: <20131229135137.7a8566da@nehalam.linuxnetplumber.net> Organization: Brocade X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.11.87, 1.0.14, 0.0.0000 definitions=2013-12-29_03:2013-12-27, 2013-12-29, 1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1305240000 definitions=main-1312290161 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org There are 3 functions in the mlx5 driver which are used and should be deleted. Upstream is not the repository to hold old dead code, or code which is used by outside drivers, or code intended for future undetermined features. Signed-off-by: Stephen Hemminger --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/net/ethernet/mellanox/mlx5/core/cq.c 2013-10-06 14:48:23.738461842 -0700 +++ b/drivers/net/ethernet/mellanox/mlx5/core/cq.c 2013-12-29 13:40:54.666481807 -0800 @@ -199,13 +199,6 @@ int mlx5_core_query_cq(struct mlx5_core_ } EXPORT_SYMBOL(mlx5_core_query_cq); - -int mlx5_core_modify_cq(struct mlx5_core_dev *dev, struct mlx5_core_cq *cq, - int type, struct mlx5_cq_modify_params *params) -{ - return -ENOSYS; -} - int mlx5_init_cq_table(struct mlx5_core_dev *dev) { struct mlx5_cq_table *table = &dev->priv.cq_table; --- a/drivers/net/ethernet/mellanox/mlx5/core/mr.c 2013-12-05 14:47:25.812499721 -0800 +++ b/drivers/net/ethernet/mellanox/mlx5/core/mr.c 2013-12-29 13:40:05.899556889 -0800 @@ -98,49 +98,3 @@ int mlx5_core_destroy_mkey(struct mlx5_c return err; } EXPORT_SYMBOL(mlx5_core_destroy_mkey); - -int mlx5_core_query_mkey(struct mlx5_core_dev *dev, struct mlx5_core_mr *mr, - struct mlx5_query_mkey_mbox_out *out, int outlen) -{ - struct mlx5_destroy_mkey_mbox_in in; - int err; - - memset(&in, 0, sizeof(in)); - memset(out, 0, outlen); - - in.hdr.opcode = cpu_to_be16(MLX5_CMD_OP_QUERY_MKEY); - in.mkey = cpu_to_be32(mlx5_mkey_to_idx(mr->key)); - err = mlx5_cmd_exec(dev, &in, sizeof(in), out, outlen); - if (err) - return err; - - if (out->hdr.status) - return mlx5_cmd_status_to_err(&out->hdr); - - return err; -} -EXPORT_SYMBOL(mlx5_core_query_mkey); - -int mlx5_core_dump_fill_mkey(struct mlx5_core_dev *dev, struct mlx5_core_mr *mr, - u32 *mkey) -{ - struct mlx5_query_special_ctxs_mbox_in in; - struct mlx5_query_special_ctxs_mbox_out out; - int err; - - memset(&in, 0, sizeof(in)); - memset(&out, 0, sizeof(out)); - - in.hdr.opcode = cpu_to_be16(MLX5_CMD_OP_QUERY_SPECIAL_CONTEXTS); - err = mlx5_cmd_exec(dev, &in, sizeof(in), &out, sizeof(out)); - if (err) - return err; - - if (out.hdr.status) - return mlx5_cmd_status_to_err(&out.hdr); - - *mkey = be32_to_cpu(out.dump_fill_mkey); - - return err; -} -EXPORT_SYMBOL(mlx5_core_dump_fill_mkey); --- a/include/linux/mlx5/cq.h 2013-10-06 14:48:24.762451839 -0700 +++ b/include/linux/mlx5/cq.h 2013-12-29 13:40:47.454639349 -0800 @@ -157,8 +157,6 @@ int mlx5_core_create_cq(struct mlx5_core int mlx5_core_destroy_cq(struct mlx5_core_dev *dev, struct mlx5_core_cq *cq); int mlx5_core_query_cq(struct mlx5_core_dev *dev, struct mlx5_core_cq *cq, struct mlx5_query_cq_mbox_out *out); -int mlx5_core_modify_cq(struct mlx5_core_dev *dev, struct mlx5_core_cq *cq, - int type, struct mlx5_cq_modify_params *params); int mlx5_debug_cq_add(struct mlx5_core_dev *dev, struct mlx5_core_cq *cq); void mlx5_debug_cq_remove(struct mlx5_core_dev *dev, struct mlx5_core_cq *cq); --- a/include/linux/mlx5/driver.h 2013-12-05 14:47:26.036496073 -0800 +++ b/include/linux/mlx5/driver.h 2013-12-29 13:40:10.647451164 -0800 @@ -687,10 +687,6 @@ int mlx5_core_create_mkey(struct mlx5_co mlx5_cmd_cbk_t callback, void *context, struct mlx5_create_mkey_mbox_out *out); int mlx5_core_destroy_mkey(struct mlx5_core_dev *dev, struct mlx5_core_mr *mr); -int mlx5_core_query_mkey(struct mlx5_core_dev *dev, struct mlx5_core_mr *mr, - struct mlx5_query_mkey_mbox_out *out, int outlen); -int mlx5_core_dump_fill_mkey(struct mlx5_core_dev *dev, struct mlx5_core_mr *mr, - u32 *mkey); int mlx5_core_alloc_pd(struct mlx5_core_dev *dev, u32 *pdn); int mlx5_core_dealloc_pd(struct mlx5_core_dev *dev, u32 pdn); int mlx5_core_mad_ifc(struct mlx5_core_dev *dev, void *inb, void *outb,