Message ID | 20130627195601.29830.15576.stgit@srivatsabhat.in.ibm.com |
---|---|
State | Not Applicable, archived |
Delegated to: | David Miller |
Headers | show |
diff --git a/kernel/softirq.c b/kernel/softirq.c index 3d6833f..c289722 100644 --- a/kernel/softirq.c +++ b/kernel/softirq.c @@ -644,14 +644,17 @@ static void remote_softirq_receive(void *data) static int __try_remote_softirq(struct call_single_data *cp, int cpu, int softirq) { + get_online_cpus_atomic(); if (cpu_online(cpu)) { cp->func = remote_softirq_receive; cp->info = &softirq; cp->flags = 0; __smp_call_function_single(cpu, cp, 0); + put_online_cpus_atomic(); return 0; } + put_online_cpus_atomic(); return 1; } #else /* CONFIG_USE_GENERIC_SMP_HELPERS */
Once stop_machine() is gone from the CPU offline path, we won't be able to depend on disabling preemption to prevent CPUs from going offline from under us. Use the get/put_online_cpus_atomic() APIs to prevent CPUs from going offline, while invoking from atomic context. Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Sedat Dilek <sedat.dilek@gmail.com> Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> --- kernel/softirq.c | 3 +++ 1 file changed, 3 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html