From patchwork Mon Mar 19 22:40:09 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Jones X-Patchwork-Id: 147670 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C703AB6FE1 for ; Tue, 20 Mar 2012 09:40:54 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964851Ab2CSWkQ (ORCPT ); Mon, 19 Mar 2012 18:40:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6079 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757610Ab2CSWkO (ORCPT ); Mon, 19 Mar 2012 18:40:14 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2JMeCit004257 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 19 Mar 2012 18:40:12 -0400 Received: from gelk.kernelslacker.org ([10.3.113.8]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q2JMeAkA005419 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 19 Mar 2012 18:40:11 -0400 Received: from gelk.kernelslacker.org (localhost [127.0.0.1]) by gelk.kernelslacker.org (8.14.5/8.14.5) with ESMTP id q2JMe98F023446; Mon, 19 Mar 2012 18:40:10 -0400 Received: (from davej@localhost) by gelk.kernelslacker.org (8.14.5/8.14.5/Submit) id q2JMe9gf023445; Mon, 19 Mar 2012 18:40:09 -0400 X-Authentication-Warning: gelk.kernelslacker.org: davej set sender to davej@redhat.com using -f Date: Mon, 19 Mar 2012 18:40:09 -0400 From: Dave Jones To: venkat.x.venkatsubra@oracle.com Cc: netdev@vger.kernel.org Subject: Improve rds_sendmsg printk Message-ID: <20120319224008.GA23036@redhat.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org - Given this can be called by any user, prevent them from flooding the logs by using printk_ratelimited - Also add a rds: prefix, so it's clear where the message is coming from. Signed-off-by: Dave Jones --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- linux/net/rds/send.c 2011-11-07 12:00:32.000000000 -0500 +++ linux/net/rds/send.c 2012-03-19 18:36:21.804991923 -0400 @@ -935,7 +935,7 @@ int rds_sendmsg(struct kiocb *iocb, stru /* Mirror Linux UDP mirror of BSD error message compatibility */ /* XXX: Perhaps MSG_MORE someday */ if (msg->msg_flags & ~(MSG_DONTWAIT | MSG_CMSG_COMPAT)) { - printk(KERN_INFO "msg_flags 0x%08X\n", msg->msg_flags); + printk_ratelimited(KERN_INFO "rds: msg_flags 0x%08X\n", msg->msg_flags); ret = -EOPNOTSUPP; goto out; }