From patchwork Tue Jan 24 16:59:01 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanislav Kinsbursky X-Patchwork-Id: 137595 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 051BDB6EE8 for ; Wed, 25 Jan 2012 03:59:29 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756076Ab2AXQ71 (ORCPT ); Tue, 24 Jan 2012 11:59:27 -0500 Received: from mailhub.sw.ru ([195.214.232.25]:35918 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752699Ab2AXQ70 (ORCPT ); Tue, 24 Jan 2012 11:59:26 -0500 Received: from localhost6.localdomain6 ([10.30.20.35]) by relay.sw.ru (8.13.4/8.13.4) with ESMTP id q0OGx2ch003668; Tue, 24 Jan 2012 20:59:03 +0400 (MSK) Subject: [PATCH] Lockd: don't mark freshly created sockets with XPT_CHNGBUF To: Trond.Myklebust@netapp.com From: Stanislav Kinsbursky Cc: linux-nfs@vger.kernel.org, xemul@parallels.com, neilb@suse.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jbottomley@parallels.com, bfields@fieldses.org, davem@davemloft.net, devel@openvz.org Date: Tue, 24 Jan 2012 20:59:01 +0400 Message-ID: <20120124165826.22037.58630.stgit@localhost6.localdomain6> User-Agent: StGit/0.15 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This is a cleanup patch. XPT_CHNGBUF bit is set on UDP socket creation. Calling svc_sock_update_bufs from lockd after sockets creation looks redundant. Below is Lockd UDP sockets creating call trace: lockd_up { make_socks create_lockd_family create_lockd_listener svc_create_xprt __svc_xpo_create svc_udp_create svc_create_socket svc_setup_socket svc_udp_init (raise XPT_CHNGBUF) .... svc_sock_update_bufs (raise XPT_CHNGBUF again) .... } Signed-off-by: Stanislav Kinsbursky --- fs/lockd/svc.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c index ff379ff..55fea92 100644 --- a/fs/lockd/svc.c +++ b/fs/lockd/svc.c @@ -292,7 +292,6 @@ int lockd_up(void) goto destroy_and_out; } - svc_sock_update_bufs(serv); serv->sv_maxconn = nlm_max_connections; nlmsvc_task = kthread_run(lockd, nlmsvc_rqst, serv->sv_name);