From patchwork Wed Oct 5 05:38:59 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krishna Kumar X-Patchwork-Id: 117740 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 26CAFB6F92 for ; Wed, 5 Oct 2011 16:40:06 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932889Ab1JEFjo (ORCPT ); Wed, 5 Oct 2011 01:39:44 -0400 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:51412 "EHLO e23smtp02.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932860Ab1JEFjn (ORCPT ); Wed, 5 Oct 2011 01:39:43 -0400 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [202.81.31.246]) by e23smtp02.au.ibm.com (8.14.4/8.13.1) with ESMTP id p955X2E7002511; Wed, 5 Oct 2011 16:33:02 +1100 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p955bRMi1020084; Wed, 5 Oct 2011 16:37:27 +1100 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p955dcIt027563; Wed, 5 Oct 2011 16:39:39 +1100 Received: from krkumar2.in.ibm.com ([9.124.219.119]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p955daQI026503; Wed, 5 Oct 2011 16:39:36 +1100 From: Krishna Kumar To: rusty@rustcorp.com.au, mst@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Krishna Kumar , virtualization@lists.linux-foundation.org Date: Wed, 05 Oct 2011 11:08:59 +0530 Message-Id: <20111005053859.5825.1089.sendpatchset@krkumar2.in.ibm.com> Subject: [RFC] [PATCH] virtio: Dont add "config" to list for !per_vq_vector Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org For the MSI but non-per_vq_vector case, the config/change vq also gets added to the list of vqs that need to process the MSI interrupt. This is not needed as config has it's own handler (vp_config_changed). In any case, vring_interrupt() finds nothing needs to be done on this vq. I tested this patch by testing the "Fallback:" and "Finally fall back" cases in vp_find_vqs(). Please review. Signed-off-by: Krishna Kumar Acked-by: Michael S. Tsirkin --- drivers/virtio/virtio_pci.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff -ruNp org/drivers/virtio/virtio_pci.c new/drivers/virtio/virtio_pci.c --- org/drivers/virtio/virtio_pci.c 2011-10-03 09:10:11.000000000 +0530 +++ new/drivers/virtio/virtio_pci.c 2011-10-04 19:16:34.000000000 +0530 @@ -415,9 +415,13 @@ static struct virtqueue *setup_vq(struct } } - spin_lock_irqsave(&vp_dev->lock, flags); - list_add(&info->node, &vp_dev->virtqueues); - spin_unlock_irqrestore(&vp_dev->lock, flags); + if (callback) { + spin_lock_irqsave(&vp_dev->lock, flags); + list_add(&info->node, &vp_dev->virtqueues); + spin_unlock_irqrestore(&vp_dev->lock, flags); + } else { + INIT_LIST_HEAD(&info->node); + } return vq;