From patchwork Wed Aug 24 11:30:28 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 111323 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 98D19B6F68 for ; Wed, 24 Aug 2011 21:32:51 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754878Ab1HXLcr (ORCPT ); Wed, 24 Aug 2011 07:32:47 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:48578 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751057Ab1HXLcp (ORCPT ); Wed, 24 Aug 2011 07:32:45 -0400 Received: by wyg24 with SMTP id 24so754817wyg.19 for ; Wed, 24 Aug 2011 04:32:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=nsYykUyE5K5LU8HqRsNBHtqz6c5LdXtARdTbhQ0/HeA=; b=CVRhL2nHUcn30nU2c6inM5m9Ysl9DEj8p1WesQrw+wO9zg5/OFxpvGowctbuVU1xtN wNLsCYaheO7fiKB0nzshcFRUxDqwGAq5j+c76fkdw0Weh/GpoDD4JEtCgSqByKNSm3cj 3E16RxthyJGh/miWFg4jvOG7OJmau+SEkARJk= Received: by 10.216.169.205 with SMTP id n55mr4355648wel.53.1314185564236; Wed, 24 Aug 2011 04:32:44 -0700 (PDT) Received: from shale.localdomain ([212.49.88.34]) by mx.google.com with ESMTPS id t44sm628242wec.3.2011.08.24.04.32.40 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 24 Aug 2011 04:32:43 -0700 (PDT) Date: Wed, 24 Aug 2011 14:30:28 +0300 From: Dan Carpenter To: Rasesh Mody Cc: Debashis Dutt , "open list:BROCADE BNA 10 GI..." , kernel-janitors@vger.kernel.org Subject: [patch -next] bna: off by one in bfa_msgq_rspq_pi_update() Message-ID: <20110824113028.GD5975@shale.localdomain> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The rspq->rsphdlr[] array has BFI_MC_MAX elements, so this test was off by one. Signed-off-by: Dan Carpenter Acked-by: Rasesh Mody --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ethernet/brocade/bna/bfa_msgq.c b/drivers/net/ethernet/brocade/bna/bfa_msgq.c index ed52187..dd36427 100644 --- a/drivers/net/ethernet/brocade/bna/bfa_msgq.c +++ b/drivers/net/ethernet/brocade/bna/bfa_msgq.c @@ -483,7 +483,7 @@ bfa_msgq_rspq_pi_update(struct bfa_msgq_rspq *rspq, struct bfi_mbmsg *mb) mc = msghdr->msg_class; num_entries = ntohs(msghdr->num_entries); - if ((mc > BFI_MC_MAX) || (rspq->rsphdlr[mc].cbfn == NULL)) + if ((mc >= BFI_MC_MAX) || (rspq->rsphdlr[mc].cbfn == NULL)) break; (rspq->rsphdlr[mc].cbfn)(rspq->rsphdlr[mc].cbarg, msghdr);