From patchwork Thu Aug 18 11:37:51 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Schmidt X-Patchwork-Id: 110511 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 90ABFB6F18 for ; Thu, 18 Aug 2011 21:38:06 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755686Ab1HRLiB (ORCPT ); Thu, 18 Aug 2011 07:38:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61150 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755718Ab1HRLiA (ORCPT ); Thu, 18 Aug 2011 07:38:00 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7IBbxXV026370 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 18 Aug 2011 07:37:59 -0400 Received: from brian.englab.brq.redhat.com (brian.brq.redhat.com [10.34.26.27]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p7IBbv6F006529; Thu, 18 Aug 2011 07:37:58 -0400 Date: Thu, 18 Aug 2011 13:37:51 +0200 From: Michal Schmidt To: eilong@broadcom.com Cc: "netdev@vger.kernel.org" , "Dmitry Kravkov" , "Vladislav Zolotarov" Subject: Re: [PATCH] bnx2x: downgrade Max BW error message to debug Message-ID: <20110818133751.3ba77279@brian.englab.brq.redhat.com> In-Reply-To: <1313603055.12483.3.camel@lb-tlvb-eilong.il.broadcom.com> References: <20110812143324.5740.45824.stgit@dhcp-29-224.brq.redhat.com> <1313405680.31417.6.camel@lb-tlvb-eilong.il.broadcom.com> <4E490A1E.3060209@redhat.com> <1313411585.31417.35.camel@lb-tlvb-eilong.il.broadcom.com> <4E493798.7010405@redhat.com> <1313434042.30399.0.camel@lb-tlvb-eilong.il.broadcom.com> <4E4A56C0.4030009@redhat.com> <1313498708.24298.0.camel@lb-tlvb-eilong.il.broadcom.com> <20110817175037.2777724a@brian.englab.brq.redhat.com> <1313603055.12483.3.camel@lb-tlvb-eilong.il.broadcom.com> Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 17 Aug 2011 20:44:15 +0300 Eilon Greenstein wrote: > I think that we should use DP instead of DBG_ERR. How about this one: ... > Can you sing-off on somethign like this? OK, let's use DP. Thanks! Subject: [PATCH v2] bnx2x: downgrade Max BW error message to debug There are valid configurations where Max BW is configured to zero for some VNs. Print the message only if debugging is enabled and do not call the configuration "illegal". [v2: use DP(), not BNX2X_DBG_ERR(); recommended by Eilon Greenstein.] Signed-off-by: Michal Schmidt Acked-by: Eilon Greenstein --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h index 223bfee..9059aef 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h @@ -1481,8 +1481,8 @@ static inline u16 bnx2x_extract_max_cfg(struct bnx2x *bp, u32 mf_cfg) u16 max_cfg = (mf_cfg & FUNC_MF_CFG_MAX_BW_MASK) >> FUNC_MF_CFG_MAX_BW_SHIFT; if (!max_cfg) { - BNX2X_ERR("Illegal configuration detected for Max BW - " - "using 100 instead\n"); + DP(NETIF_MSG_LINK, + "Max BW configured to 0 - using 100 instead\n"); max_cfg = 100; } return max_cfg;