Message ID | 20110818133751.3ba77279@brian.englab.brq.redhat.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
On Thu, 2011-08-18 at 04:37 -0700, Michal Schmidt wrote: > On Wed, 17 Aug 2011 20:44:15 +0300 Eilon Greenstein wrote: > > I think that we should use DP instead of DBG_ERR. How about this one: > ... > > Can you sing-off on somethign like this? > > OK, let's use DP. Thanks! > > > Subject: [PATCH v2] bnx2x: downgrade Max BW error message to debug > > There are valid configurations where Max BW is configured to zero for > some VNs. > Print the message only if debugging is enabled and do not call the > configuration "illegal". > > [v2: use DP(), not BNX2X_DBG_ERR(); recommended by Eilon Greenstein.] > > Signed-off-by: Michal Schmidt <mschmidt@redhat.com> Acked-by: Eilon Greenstein <eilong@broadcom.com> Thanks Michal! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: "Eilon Greenstein" <eilong@broadcom.com> Date: Thu, 18 Aug 2011 15:22:00 +0300 > On Thu, 2011-08-18 at 04:37 -0700, Michal Schmidt wrote: >> On Wed, 17 Aug 2011 20:44:15 +0300 Eilon Greenstein wrote: >> > I think that we should use DP instead of DBG_ERR. How about this one: >> ... >> > Can you sing-off on somethign like this? >> >> OK, let's use DP. Thanks! >> >> >> Subject: [PATCH v2] bnx2x: downgrade Max BW error message to debug >> >> There are valid configurations where Max BW is configured to zero for >> some VNs. >> Print the message only if debugging is enabled and do not call the >> configuration "illegal". >> >> [v2: use DP(), not BNX2X_DBG_ERR(); recommended by Eilon Greenstein.] >> >> Signed-off-by: Michal Schmidt <mschmidt@redhat.com> > > Acked-by: Eilon Greenstein <eilong@broadcom.com> Applied, thanks everyone. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h index 223bfee..9059aef 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h @@ -1481,8 +1481,8 @@ static inline u16 bnx2x_extract_max_cfg(struct bnx2x *bp, u32 mf_cfg) u16 max_cfg = (mf_cfg & FUNC_MF_CFG_MAX_BW_MASK) >> FUNC_MF_CFG_MAX_BW_SHIFT; if (!max_cfg) { - BNX2X_ERR("Illegal configuration detected for Max BW - " - "using 100 instead\n"); + DP(NETIF_MSG_LINK, + "Max BW configured to 0 - using 100 instead\n"); max_cfg = 100; } return max_cfg;